[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-03-12 04:54:25 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zgX32XawN3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 --- Comment #13 from Fedora Update System --- rubygem-httpclient-2.3.2-4.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PT7JxEhoua&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 --- Comment #12 from Fedora Update System --- rubygem-httpclient-2.3.2-4.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T553ZpKQfr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0tmq0UeZHK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 --- Comment #11 from Fedora Update System --- rubygem-httpclient-2.3.2-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-httpclient-2.3.2-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jlui4ihbaH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VJ7Uwq0oZc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bzvNCuJKqI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 Troy Dawson changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Troy Dawson --- New Package SCM Request === Package Name: rubygem-httpclient Short Description: HTTP Client interface for ruby Owners: tdawson maxamillion Branches: f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XFzodlScSV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 Michael Scherer changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from Michael Scherer --- So should be ok now -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9M8hWCctn3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 Troy Dawson changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #7 from Troy Dawson --- Spec URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-httpclient.spec SRPM URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-httpclient-2.3.2-4.fc18.src.rpm - License: I'm not sure where I got it from, but I could have sworn that GPL thing was the correct license for Ruby. But you are right, and I changed it. It is now "(Ruby or BSD) and Public Domain", just like ruby. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2zJ1fzSMjs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=902503
--- Comment #6 from Michael Scherer ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[!]: License field in the package spec file matches the actual license.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/misc/checkout/git/FedoraReview/902503-rubygem-
httpclient/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
httpclient-doc
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ruby:
[x]: Platform dependent files must all go under %{gem_extdir}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package contains Requires: ruby(abi).
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]:
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 --- Comment #5 from Michael Scherer --- Well, ruby is under the following license : License : (Ruby or BSD) and Public Domain So I do not see where does the GPL v2 come from, as http-access was first without license, then under ruby license ( ie, ruby or BSD ). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iLwusDBAq8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 Guillermo Gómez changed: What|Removed |Added CC||guillermo.go...@gmail.com --- Comment #4 from Guillermo Gómez --- ¿Progress? Im needing it for rubygem-rhc since it becames as dependency for latest version # gem dependency rhc -r Gem rhc-1.3.8 activesupport (~> 3.0, development) archive-tar-minitar (>= 0) commander (>= 4.0) cucumber (>= 0, development) dnsruby (>= 0, development) fakefs (>= 0.4, development) highline (>= 1.5.1) httpclient (>= 2.2)<< HERE net-ssh (>= 2.0.11) open4 (>= 0) rake (<= 0.9.2.2, >= 0.8.7, development) rspec (~> 1.3, development) test-unit (>= 0) thor (>= 0, development) webmock (>= 1.6, development) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AqitgDaUaA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 --- Comment #3 from Troy Dawson --- Spec URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-httpclient.spec SRPM URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-httpclient-2.3.2-3.fc18.src.rpm - %%doc -- typo - fixed - URL -- That's what spec originally had. fixed - License -- Set to dual license Ruby + GPLv2 --- There was some code mixing but they got permission to License it all under the standard Ruby dual license. "Some part of it is copyrighted by Maebashi-san who made and published http-access/0.0.4. http-access/0.0.4 did not include license notice but when I asked Maebashi-san he agreed that I can redistribute it under the same terms of Ruby. Many thanks to Maebashi-san." - Non-working find line -- Another throwback from the original spec. I'm glad it wasn't working because it was trying to change all the /usr/bin/env ruby to /usr/bin/ruby. Not something I think you should do. -- removed line - CA -- not sure what to do about it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uC0Pw5DsEi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=902503
--- Comment #2 from Michael Scherer ---
A few remark :
- %%doc %{gem_instdir}/README.txt
why a %% instead of % ?
- URL:http://devcentral.f5.com/
The url seems wrong
- there is no license shipped
- Licensing is wrong :
# This program is copyrighted free software by NAKAMURA, Hiroshi. You can
# redistribute it and/or modify it under the same terms of Ruby's license;
# either the dual license version in 2003, or any later version.
that's not GPLv2 ( and I think there is some license mixing )
- this is likely wrong
find %{buildroot}/%{gem_instdir} -type f -exec sed -r -e 's"^#!(.*)/usr/bin/env
ruby"#!/usr/bin/ruby"' {} \;
as it print on stdout the fixed file, you may miss a -i ( see the build.log
file )
- the gem ship its own CA store (
/usr/share/gems/gems/httpclient-2.3.2/lib/httpclient/cacert.p7s ). This may
include outdated certificates ( as it get them from jdk, I would not bet on
their security ), and i do not know how to check. And of course, it use it by
default :)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=3j1Ean9fWr&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 Michael Scherer changed: What|Removed |Added CC||m...@zarb.org Assignee|nob...@fedoraproject.org|m...@zarb.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jXNVRjEwaZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902503] Review Request: rubygem-httpclient - HTTP Client interface for ruby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902503 --- Comment #1 from Troy Dawson --- RPMLINT Output: rpmlint rubygem-httpclient-2.3.2-2.fc18.src.rpm rubygem-httpclient-2.3.2-2.fc18.noarch.rpm rubygem-httpclient-doc-2.3.2-2.fc18.noarch.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aaRaABg579&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
