[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- lfsc-0.20120321-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wOsshoOY7la=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-30 00:31:19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vu0iC23o4ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- lfsc-0.20120321-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JQE3qPJ6dqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bLGvjD6Cx6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FQG6Gdabtda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DxYuNlpuM8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- lfsc-0.20120321-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lfsc-0.20120321-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IbVTFgC3yEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- lfsc-0.20120321-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wImzly9Wika=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dxqhrxbd0Xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 --- Comment #6 from Pavol Babinčák pbabi...@redhat.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=shuFH4JRuIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 Pavol Babinčák pbabi...@redhat.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hquMKhhAZZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 Jerry James loganje...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #7 from Jerry James loganje...@gmail.com --- Package Change Request == Package Name: lfsc New Branches: f19 Owners: jjames InitialCC: Sigh. I shouldn't try to do anything when I'm sick. I now have an F-18 branch and an F-20 branch, but no F-19 branch. This change request fixes the problem. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mxXXjselafa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- The srpm url is wrong, but I guessed it right and run fedora-review on the srpm: s/fc19/fc20/. The package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=usfn9myQisa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 --- Comment #4 from Jerry James loganje...@gmail.com --- Oops. How did I do that??? Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EA7HbBTCFKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 Jerry James loganje...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Jerry James loganje...@gmail.com --- New Package SCM Request === Package Name: lfsc Short Description: SMT proof checker Owners: jjames Branches: f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ntSLTHQIMFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903428 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Jerry James loganje...@gmail.com --- I have added the source text file as a reminder to update the man page on updates. I have also added a simple %check script. The tool returns non-zero if a proof fails to check. New URLs: Spec URL: http://jjames.fedorapeople.org/lfsc/lfsc.spec SRPM URL: http://jjames.fedorapeople.org/lfsc/lfsc-0.20120321-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DjEuiDOvIpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903428] Review Request: lfsc - SMT proof checker
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903428
Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed:
What|Removed |Added
CC||paulo.cesar.pereira.de.andr
||a...@gmail.com
Assignee|nob...@fedoraproject.org|paulo.cesar.pereira.de.andr
||a...@gmail.com
Flags||fedora-review?
--- Comment #1 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com ---
The package is quite simple so I do not expect to
find any major issues, at first my considerations
are:
I see you made the manual page based on
http://clc.cs.uiowa.edu/lfsc/readme-lfsc.txt
I suggest adding it to sources, no need to install as
%doc, to work as a kind of reminder to validate the manual
page is up to dade when updating the package.
[!]: %check is present and all tests pass.
Please add a simple %check section with a basic validation
that the package works as expected.
Full fedora-review text follows:
---%---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in /home/pcpa/903428-lfsc/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint
