[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-10-04 05:22:28 --- Comment #10 from Mamoru TASAKA mtas...@fedoraproject.org --- Rebuilt for all branches, push requested for F-20 and below, closing. Thank you for reviewing and git procedure. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639
--- Comment #6 from Mamoru TASAKA mtas...@fedoraproject.org ---
Thank you for comments!
http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf-0.1.2-1.fc.src.rpm
http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf.spec
* Thu Oct 3 2013 Mamoru TASAKA mtas...@fedoraproject.org - 0.1.2-1
- 0.1.2
(In reply to Josef Stribny from comment #5)
1, There is a newer upstream version (0.1.2).
- Updated.
2, The %description section of -doc sub-package should end up with a dot(.).
- Fixed
3, You should use a macro %{gem_libdir} for lib dir instead of
%{gem_instdir}/lib/
- Well, I prefer to use %{gem_instdir}/lib/ because using %{gem_libdir}
makes it difficult to show that %{gem_libdir} is the subdirectory of
%{gem_instdir} (i.e. the parent directory of %{gem_libdir} is properly
owned), however modified.
4, And again license file is not separately listed. This requires more work
in the end (for me to check it, for you to check it with every update of the
gem) and it's prone to error.
- I always check this... (i.e. I always unpack both the previous version
and the new version of tarball / gem / etc, take diff to check what
actually changed, judge if it can safely be upgraded.)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=z1az8Zqo7Ta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 Josef Stribny jstri...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Josef Stribny jstri...@redhat.com --- I always check this... (i.e. I always unpack both the previous version and the new version of tarball / gem / etc, take diff to check what actually changed, judge if it can safely be upgraded.) I believe you and it's a right thing to do :). But someone working on the package in the future can overlook it, that's my point :). Thanks for the fixes == APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LuaLRbWinGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Mamoru TASAKA mtas...@fedoraproject.org --- Thank you! New Package SCM Request === Package Name: rubygem-unf Short Description: Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby Owners: mtasaka Branches: f18 f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zj7xtauhV0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wQtngflfBha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qk3iwL6p7Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639
--- Comment #5 from Josef Stribny jstri...@redhat.com ---
1, There is a newer upstream version (0.1.2).
2, The %description section of -doc sub-package should end up with a dot(.).
3, You should use a macro %{gem_libdir} for lib dir instead of
%{gem_instdir}/lib/
4, And again license file is not separately listed. This requires more work in
the end (for me to check it, for you to check it with every update of the gem)
and it's prone to error.
Otherwise rpmlint doesn't complain, package builds, installs and runs. Please
fix the issues above so I can approve.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=W1A6qFfnRda=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 Josef Stribny jstri...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jstri...@redhat.com Assignee|nob...@fedoraproject.org|jstri...@redhat.com Flags||fedora-review? --- Comment #4 from Josef Stribny jstri...@redhat.com --- I will take it for a review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MvZI4N3nmla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 Bug 904639 depends on bug 892314, which changed state. Bug 892314 Summary: Review Request: rubygem-unf_ext - Unicode Normalization Form support library for CRuby https://bugzilla.redhat.com/show_bug.cgi?id=892314 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LsmSMbTzW8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904639 --- Comment #3 from Mamoru TASAKA mtas...@fedoraproject.org --- http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf.spec http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf-0.1.1-1.fc.src.rpm * Mon Apr 29 2013 Mamoru TASAKA mtas...@fedoraproject.org - 0.1.1-1 - 0.1.1 Mock build for F-19: http://mtasaka.fedorapeople.org/Review_request/mechanize-related/MOCK-rubygem-unf.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zX84UkQlsba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904639 --- Comment #2 from Mamoru TASAKA mtas...@fedoraproject.org --- http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf.spec http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf-0.1.0-1.fc.src.rpm * Fri Mar 22 2013 Mamoru TASAKA mtas...@fedoraproject.org - 0.1.0-1 - 0.1.0 Mock build log on F-20: http://mtasaka.fedorapeople.org/Review_request/mechanize-related/MOCK-rubygem-unf.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LcAZPBXyOpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904639 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Depends On||892314 --- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org --- This packge depends on rubygem-unf_ext, review request bug 892314 . Local mock build log for F-19: http://mtasaka.fedorapeople.org/Review_request/mechanize-related/MOCK-rubygem-unf.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DvEK5j2W30a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904639 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Blocks||904640 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ckxXmdqnI3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
