[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- stbi-1.33-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gEPZtHK7mSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- stbi-1.33-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lq0Z1SOkvra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-27 23:50:33 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2U2zlx9lU9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- stbi-1.33-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TrBEctverua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TEqBdlFwPea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P3PlwYq8f3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Apuk2rtRya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- stbi-1.33-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mbxvEbtyhOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NGnfPIoAl9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- stbi-1.33-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/stbi-1.33-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ldbxJE3txRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- stbi-1.33-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/stbi-1.33-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pmfYmT664za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- stbi-1.33-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/stbi-1.33-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dFgjeuXshOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Miro Hrončok mhron...@redhat.com --- New Package SCM Request === Package Name: stbi Short Description: JPEG/PNG reader Owners: churchyard Branches: f17 f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F43gnDqMwYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 --- Comment #3 from Miro Hrončok mhron...@redhat.com --- URL seems OK to me, where's the problem, in the macro? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xUIFA73iJra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from T.C. Hollingsworth tchollingswo...@gmail.com --- Oh, sorry I guess rpm handles this just fine. Though I wonder if something in our toolchain greps specs instead of parsing them with rpm. Keep an eye out for breakage. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MYfyQrWaZHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tchollingswo...@gmail.com Assignee|nob...@fedoraproject.org|tchollingswo...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aZTXRCLEtoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=907018
--- Comment #2 from T.C. Hollingsworth tchollingswo...@gmail.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Status: NEEDS WORK
Issues
[!]: The URL is invalid.
You used an undefined macro (%{url}) in the URL field. Please provide a
valid URL.
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in
/home/fedora/patches/FedoraReview/907018-stbi/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Scriptlets must be sane, if used.
[Bug 907018] Review Request: stbi - JPEG/PNG reader
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907018 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Blocks||907032 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7b67ADaagqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
