[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #1 from Miro Hrončok --- Correct Spec URL: https://raw.github.com/hroncok/SPECS/master/lmfit.spec My fault. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4BA9K1Fttl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=907213
Ralf Corsepius changed:
What|Removed |Added
CC||rc040...@freenet.de
--- Comment #2 from Ralf Corsepius ---
Some comments:
1. You can't package the demo binaries into /usr/share/doc/*, because all files
below /usr/share must be arch-independent.
I'd recommend to do one of the following:
a) To only ship the sources (*.c) under /usr/share/doc/*
b) To install the demos somewhere below %{_libdir}/lmfit in a separate *-demos
package (One way to do so would be to use %configure
--bindir=%{_libdir}/lmfit.)
c) To apply --program-prefix
d) Not to ship the demos.
2. Consider appending --disable-static to %configure.
This would avoid much of the "rm"-sequence you are using to remove the static
libs and would avoid compiling the libraries twice.
3. The %check section is superflous.
%check is supposed to run a testsuite, but this package doesn't ship one.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=p0FvxhAlHJ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #3 from Miro Hrončok --- (In reply to comment #2) > 1. You can't package the demo binaries into /usr/share/doc/*, because all > files below /usr/share must be arch-independent. That was not my intention. They are present by mistake. > I'd recommend to do one of the following: > a) To only ship the sources (*.c) under /usr/share/doc/* This is what i wanted. I deleted the apps from /usr/bin, but I didn't noticed they are in demos too. > 2. Consider appending --disable-static to %configure. > This would avoid much of the "rm"-sequence you are using to remove the > static libs and would avoid compiling the libraries twice. Good point > 3. The %check section is superflous. > %check is supposed to run a testsuite, but this package doesn't ship one. OK. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZiR26BHPvE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #4 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/lmfit.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/lmfit-3.5-2.fc18.src.rpm - Do not package demo binaries to %%doc - Added --disable-static to configure -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YNKk4I8zI6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 Miro Hrončok changed: What|Removed |Added Blocks||907585 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LpN0gWidHm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 T.C. Hollingsworth changed: What|Removed |Added Status|NEW |ASSIGNED CC||tchollingswo...@gmail.com Assignee|nob...@fedoraproject.org|tchollingswo...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bzeadxv8Y0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=907213
T.C. Hollingsworth changed:
What|Removed |Added
Flags||needinfo?(mhroncok@redhat.c
||om)
--- Comment #5 from T.C. Hollingsworth ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Status: NEEDS WORK
= Issues
[!]: License is listed as "BSD and CC-BY", but licensecheck identifies some
GPLv2+ files.
See the attachment for details. Please correct the License tag or justify
the exclusion of the GPL in a comment.
[!]: License is listed as "BSD", but no copy of the license is included.
The BSD license states:
"Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution."
In order to comply with this clause of the license, a copy of the license
text MUST be included in %doc. You can either work with upstream to
include
one, or include one yourself.
For more information on handling this situation, see:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later)", "Unknown or generated". 2 files have unknown
license. Detailed output of licensecheck in
/home/fedora/patches/FedoraReview/907213-lmfit/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
[!]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and writ
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #6 from T.C. Hollingsworth --- Created attachment 737487 --> https://bugzilla.redhat.com/attachment.cgi?id=737487&action=edit licensecheck output Sorry, forgot the attachment. I don't think the file in question in packaged, so this is probably a non-issue. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DPdwgvXyIK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 Miro Hrončok changed: What|Removed |Added Flags|needinfo?(mhroncok@redhat.c | |om) | --- Comment #7 from Miro Hrončok --- No, ltmain.sh is not included and yes, COPYING with BSD license is included. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bQfUZKwaNB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 T.C. Hollingsworth changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from T.C. Hollingsworth --- Wow, I was full of fail last night, sorry. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Nr6hHAd5yh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 Miro Hrončok changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Miro Hrončok --- New Package SCM Request === Package Name: lmfit Short Description: Levenberg-Marquardt least-squares minimization and curve fitting Owners: churchyard Branches: f17 f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qqBKCWyFrR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YUqiqZhG0E&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vyQPz8me68&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jLZOgFqL8t&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #14 from Fedora Update System --- lmfit-3.5-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JYqRYcR2lq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SAGOjXyzr6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #11 from Fedora Update System --- lmfit-3.5-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lmfit-3.5-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zl0XiE6hHR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #12 from Fedora Update System --- lmfit-3.5-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lmfit-3.5-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=35H8fJM0ja&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #13 from Fedora Update System --- lmfit-3.5-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/lmfit-3.5-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zUINI9JUhB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-27 23:50:08 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZNO7eyhtZn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #15 from Fedora Update System --- lmfit-3.5-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iH8vvGhHoM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #16 from Fedora Update System --- lmfit-3.5-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RdLKw67B5m&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907213 --- Comment #17 from Fedora Update System --- lmfit-3.5-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uDeW8ydSMC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
