[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
https://bugzilla.redhat.com/show_bug.cgi?id=910119 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||nodejs-commander-1.1.1-1.el ||6 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- nodejs-commander-1.1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kvUki9ZA4Pa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
https://bugzilla.redhat.com/show_bug.cgi?id=910119 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- nodejs-commander-1.1.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-commander-1.1.1-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jDJ4Kun0c3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|RAWHIDE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c7ATP1QZ94a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-commander-1.1.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r4LKMQYGHwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Bug 910119 depends on bug 910567, which changed state. Bug 910567 Summary: Review Request: nodejs-keypress - Make any Node ReadableStream emit keypress events https://bugzilla.redhat.com/show_bug.cgi?id=910567 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z7v74yMWeua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2013-03-19 10:08:57 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TiUZLU031Oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x32IKE3MRka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-commander-1.1.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-commander-1.1.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9gc9wmTqWKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||912089 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fTmdgYap6Ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NhXGSShWd2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-commander-1.1.1-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JyjnqMueR5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: nodejs-commander Short Description: Node.js command-line interfaces made easy Owners: jamielinux Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rx5dg6ocFoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xuic5LVamNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910119
T.C. Hollingsworth tchollingswo...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #7 from T.C. Hollingsworth tchollingswo...@gmail.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Status: APPROVED
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[!]: SourceX / PatchY prefixed with %{name}.
Note: Source0 (commander-1.1.1.tgz) Source1 (tests-1.1.1.tar.bz2)
Source10 (dl-tests.sh)
[x]: SourceX is a working URL.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||911186 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e9ecXlp7tWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||911183 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wLUPMP4cjPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 --- Comment #6 from Jamie Nguyen jamieli...@fedoraproject.org --- Pull request sent: https://github.com/visionmedia/commander.js/pull/127 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PI2fmynxVNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||910150 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dC1E6P27Zpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tchollingswo...@gmail.com Assignee|nob...@fedoraproject.org|tchollingswo...@gmail.com Flags||fedora-review? --- Comment #1 from T.C. Hollingsworth tchollingswo...@gmail.com --- Now we'll have as many command line parsing Node.js libraries in the distro as there are in the Python standard library! :-p -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KYcChX7VzNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910119
--- Comment #2 from T.C. Hollingsworth tchollingswo...@gmail.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Status: NEEDS WORK
Issues:
===
[!]: The latest upstream version is 1.1.1.
Please package the latest version or provide a rationale for packaging an
older version.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
MIT license in Readme.md so OK.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
Node.js:
[x]: The package name is prefixed with nodejs- if it is a library
[x]: BuildRequires: nodejs-devel
[x]: Uses %{nodejs_sitelib} instead of hardcoding path
[x]: Uses tarball from the npm registry
[x]: If (and only if) this module is present in the npm registry, provides
npm(module_name)
[x]: Runs %nodejs_symlink_deps in %install
[-]: Bundled modules are removed in %prep
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[!]: SourceX / PatchY prefixed with %{name}.
Note: Source0
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 --- Comment #3 from T.C. Hollingsworth tchollingswo...@gmail.com --- Please also document how the Source1 (tests) tarball is generated, per http://fedoraproject.org/wiki/Packaging:SourceURL -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4XtzYA13oSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||910567 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GAlganxir2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910119
--- Comment #4 from Jamie Nguyen jamieli...@fedoraproject.org ---
Thanks for the review! :)
Now we'll have as many command line parsing Node.js libraries
in the distro as there are in the Python standard library! :-p
Heh :P
Please package the latest version or provide a rationale for
packaging an older version.
I have no rationale for packaging an older version other than oops. Updated!
(And now with an extra dep on nodejs-keypress:
https://bugzilla.redhat.com/show_bug.cgi?id=910567 .)
Good (will look at dep generator to figure out what's causing
that trailing dot but it doesn't hurt anything and it's not your
problem. ;-)
The package.json wants node = 0.6.x so that's where the problem lies. I've
added a patch for that in the spec but once the dep generator is fixed then
I'll remove it.
diff -Naur a/package.json b/package.json
--- a/package.json
+++ b/package.json
@@ -9,5 +9,5 @@
, devDependencies: { should: = 0.0.1 }
, scripts: { test: make test }
, main: index
- , engines: { node: = 0.6.x }
+ , engines: { node: = 0.6.0 }
}
Please also document how the Source1 (tests) tarball is generated
Done.
Spec URL:
http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-commander.spec
SRPM URL:
http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-commander-1.1.1-1.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=HXcvCLKquIa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910119 --- Comment #5 from T.C. Hollingsworth tchollingswo...@gmail.com --- Ah, 0.6.x is an invalid version specifier. `man npm-json` says You may not supply a comparator with a version containing an x. Please notify upstream about this. Though npm seems to be happy with it so I might fix the dep generator anyway. I'll re-review the updated package once the new dep is done. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8oOJNArZlva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
