[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Pv8YIEw9f4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 --- Comment #9 from Jon Ciesla --- Requested package name python-socksipychain doesn't match bug summary python-SocksipyChain, please correct. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GQhz7MbgJq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 Lukas Zapletal changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Lukas Zapletal --- New Package SCM Request === Package Name: python-socksipychain Short Description: Python SOCKS/HTTP Proxy module Owners: lzap Branches: f18 f19 el5 el6 Thank you Mirek! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NKPNW5HuHc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 Miroslav Suchý changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #7 from Miroslav Suchý --- I downloaded src.rpm from that koji task. But next time it is better to post link to new spec and new src.rpm in bugzilla comment. All issues resolved. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TvHrBtzAKH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 --- Comment #6 from Miroslav Suchý --- > Not sure what you mean, the lastest is still 2.0.12. Yes. Correct. Ignore my previous comment about this one issue. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sxiElEJxme&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 --- Comment #5 from Lukas Zapletal --- Hey Mirek, thanks. Issues: [!]: Package is named according to the Package Naming Guidelines. Right, fixed. [!]: Dist tag is present. OK [!]: Spec use %global instead of %define. OK [!]: Latest version is packaged. v2.0.4 has been released in mean time Not sure what you mean, the lastest is still 2.0.12. [lzap@lzapx SOURCES]$ rpmlint /home/lzap/rpmbuild/BUILDROOT/python-socksipychain-2.0.12-3.fc18.x86_64 /home/lzap/rpmbuild/SRPMS/python-socksipychain-2.0.12-3.fc18.src.rpm (none): E: no installed packages by name /home/lzap/rpmbuild/BUILDROOT/python-socksipychain-2.0.12-3.fc18.x86_64 python-socksipychain.src: W: file-size-mismatch python-SocksipyChain-2.0.12.tar.gz = 18086, http://pagekite.net/pk/src/python-SocksipyChain-2.0.12.tar.gz = 17978 1 packages and 0 specfiles checked; 0 errors, 1 warnings. (Perhaps some misconfiguration on the server, I just downloaded the file twice and it seems to be ok.) [lzap@lzapx SOURCES]$ koji build --scratch rawhide /home/lzap/rpmbuild/SRPMS/python-socksipychain-2.0.12-3.fc18.src.rpm Uploading srpm: /home/lzap/rpmbuild/SRPMS/python-socksipychain-2.0.12-3.fc18.src.rpm [] 100% 00:00:01 20.85 KiB 13.50 KiB/sec Created task: 5250289 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5250289 Watching tasks (this may be safely interrupted)... 5250289 build (rawhide, python-socksipychain-2.0.12-3.fc18.src.rpm): open (arm02-builder07.arm.fedoraproject.org) 5250291 buildArch (python-socksipychain-2.0.12-3.fc18.src.rpm, noarch): free 5250291 buildArch (python-socksipychain-2.0.12-3.fc18.src.rpm, noarch): free -> open (buildvm-11.phx2.fedoraproject.org) 5250291 buildArch (python-socksipychain-2.0.12-3.fc18.src.rpm, noarch): open (buildvm-11.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 5250289 build (rawhide, python-socksipychain-2.0.12-3.fc18.src.rpm): open (arm02-builder07.arm.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 5250289 build (rawhide, python-socksipychain-2.0.12-3.fc18.src.rpm) completed successfully -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WDKBTVblZV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910146
Miroslav Suchý changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|msu...@redhat.com
Flags||fedora-review?
--- Comment #4 from Miroslav Suchý ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[-]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Dist tag is present.
[!]: Spec use %global instead of %define.
Note: %define canonicalname SocksipyChain
[x]: Buildroot is not present
Note: Buildroot: present but used only for el5
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but used only for el5
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and a
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 --- Comment #3 from Lukas Zapletal --- Many thanks with PageKite review, this is the last piece of the puzzle I need to package PageKite for EPEL5/6 and Fedoras ;-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ha1wbij3A7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 --- Comment #2 from Lukas Zapletal --- Fixed! Spec URL: https://raw.github.com/lzap/spec_reviews/master/python-SocksipyChain.spec RPM URL: http://lzap.fedorapeople.org/fedora-packaging/python-SocksipyChain/2.0.12-2/python-SocksipyChain-2.0.12-2.noarch.rpm SRPM URL: http://lzap.fedorapeople.org/fedora-packaging/python-SocksipyChain/2.0.12-2/python-SocksipyChain-2.0.12-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=76g33DVx43&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 Miroslav Suchý changed: What|Removed |Added CC||msu...@redhat.com --- Comment #1 from Miroslav Suchý --- [!]: Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mtbomUOtue&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910146] Review Request: python-SocksipyChain - A Python SOCKS/HTTP Proxy module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910146 Miroslav Suchý changed: What|Removed |Added Blocks||910699 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OrR9HoPF4M&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
