[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-node-xmpp-0.3.2-5.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gyUTna0sWva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|RAWHIDE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oQgGv8keMta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2013-03-26 09:50:15 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8ZXn8k9PiOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 --- Comment #6 from Jamie Nguyen jamieli...@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-node-xmpp.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-node-xmpp-0.3.2-5.fc18.src.rpm * Sat Mar 23 2013 Jamie Nguyen jamieli...@fedoraproject.org - 0.3.2-5 - add comment about upstream patch - fix %%description -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tE0potYbe2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #7 from Tom Hughes t...@compton.nu --- Looks good now. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zIBoyX2Vu2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: nodejs-node-xmpp Short Description: Idiomatic XMPP client, component and server library for Node.js Owners: jamielinux Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r36AmEtJxza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fNbAoQnut1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1gRI6La2IYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-node-xmpp-0.3.2-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-node-xmpp-0.3.2-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YGUbRHPJiSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-node-xmpp-0.3.2-5.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RS5mrXv0KDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bsCd6drYzaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910147
Tom Hughes t...@compton.nu changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||t...@compton.nu
Assignee|nob...@fedoraproject.org|t...@compton.nu
Flags||fedora-review?
--- Comment #5 from Tom Hughes t...@compton.nu ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Patches link to upstream bugs/comments/lists or are otherwise justified.
The patch seems to have come from git - was it taken from upstream?
- Rpmlint is run on all installed packages.
nodejs-node-xmpp.noarch: E: description-line-too-long C - After
authentication, leave trivial protocol bits to the user, that is XML handling
according to any XEP
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 11 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 --- Comment #3 from Jamie Nguyen jamieli...@fedoraproject.org --- Apply nodejs-node-xmpp-0.3.2-check-socket-exists.patch. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-node-xmpp.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-node-xmpp-0.3.2-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V5BsEuN3sda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 --- Comment #4 from Jamie Nguyen jamieli...@fedoraproject.org --- Apply nodejs-node-xmpp-0.3.2-check-socket-exists.patch. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-node-xmpp.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-node-xmpp-0.3.2-4.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IuedogmRxsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Bug 910147 depends on bug 910136, which changed state. Bug 910136 Summary: Review Request: nodejs-node-expat - Fast libexpat XML SAX parser binding for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=910136 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5TYPnn20bda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Bug 910147 depends on bug 910137, which changed state. Bug 910137 Summary: Review Request: nodejs-node-stringprep - ICU StringPrep profiles for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=910137 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y8aw9yE00la=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Bug 910147 depends on bug 910145, which changed state. Bug 910145 Summary: Review Request: nodejs-ltx - A Node.js module for parsing, modifying and building XML https://bugzilla.redhat.com/show_bug.cgi?id=910145 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T8p7h7x8J3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||911022 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3CWOn4E0yja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On|910114, 910141 | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sxr8b56DNva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- Make use of %nodejs_fixdep. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-node-xmpp.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-node-xmpp-0.3.2-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RY38dzBFcca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 --- Comment #1 from Jamie Nguyen jamieli...@fedoraproject.org --- Be a bit more cautious with version requirements in the dependency patch. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-node-xmpp.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-node-xmpp-0.3.2-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2iSZ5gLebea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||910114, 910141, 910137, ||910136, 910145 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FDrGmCfSjNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910147] Review Request: nodejs-node-xmpp - Idiomatic XMPP client, component and server library for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910147 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||910154 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ShnD3WIpaLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
