[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=910148 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||nodejs-connect-2.7.10-1.el6 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- nodejs-connect-2.7.10-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vZ3cdMYBnUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- nodejs-connect-2.7.10-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-connect-2.7.10-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xzmvN76Z0Pa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- nodejs-connect-2.7.3-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Iv4InklCk1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|RAWHIDE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HqMeTysKGpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Bug 910148 depends on bug 910123, which changed state. Bug 910123 Summary: Review Request: nodejs-cookie-signature - Node.js module to sign and unsign cookies https://bugzilla.redhat.com/show_bug.cgi?id=910123 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=quOfGu8EXLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Bug 910148 depends on bug 910121, which changed state. Bug 910121 Summary: Review Request: nodejs-cookie - Cookie parsing and serialization for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=910121 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lTcgrLicVpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Bug 910148 depends on bug 910127, which changed state. Bug 910127 Summary: Review Request: nodejs-fresh - HTTP response freshness testing for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=910127 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zKD8YpYMc7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Bug 910148 depends on bug 910116, which changed state. Bug 910116 Summary: Review Request: nodejs-buffer-crc32 - A pure javascript CRC32 algorithm that plays nice with binary data https://bugzilla.redhat.com/show_bug.cgi?id=910116 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=j4y5BlQC3Va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Bug 910148 depends on bug 910124, which changed state. Bug 910124 Summary: Review Request: nodejs-debug - A small debugging utility for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=910124 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0TkEgpq6xQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Bug 910148 depends on bug 910118, which changed state. Bug 910118 Summary: Review Request: nodejs-bytes - Byte size string parser/serializer for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=910118 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cfra5F5QCJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Bug 910148 depends on bug 910138, which changed state. Bug 910138 Summary: Review Request: nodejs-pause - Node.js module to pause streams https://bugzilla.redhat.com/show_bug.cgi?id=910138 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nONkMpspgTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Bug 910148 depends on bug 910142, which changed state. Bug 910142 Summary: Review Request: nodejs-send - Better streaming static file server with Range and conditional-GET support https://bugzilla.redhat.com/show_bug.cgi?id=910142 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xzTwRFzcxua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Bug 910148 depends on bug 910125, which changed state. Bug 910125 Summary: Review Request: nodejs-formidable - A Node.js module for parsing form data, especially file uploads https://bugzilla.redhat.com/show_bug.cgi?id=910125 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BuVV91pvkNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2013-03-19 10:12:20 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SvWmdgKpSJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Bug 910148 depends on bug 910139, which changed state. Bug 910139 Summary: Review Request: nodejs-qs - Query string parser for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=910139 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NXCalqrWEka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- nodejs-connect-2.7.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-connect-2.7.3-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4dZyO4I4B2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q320XRsGs7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- nodejs-connect-2.7.3-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YeaMoQMsQKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qp2i2FDzq2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DFqSBlpoLia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-connect-2.7.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-connect-2.7.3-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lSUU09T7Jka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #6 from Jamie Nguyen jamieli...@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-connect.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-connect-2.7.3-2.fc18.src.rpm [!]: %check is present and all tests pass. I'm seeing 11 test failures when the tests are enabled. I fixed 2 of them. Most of the remaining errors are multipart/form-data related and seem to be the same upstream (who also have some other errors too): https://travis-ci.org/senchalabs/connect/jobs/4916390 Not sure if switching from formidable to parted will fix things, but progress on that seems to have stalled: https://github.com/senchalabs/connect/issues/673 Also, should lib-cov be installed? Removed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SjwLp14SKea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910148
--- Comment #7 from Tom Hughes t...@compton.nu ---
Great. The only thing I'm wondering about now is whether the symlinking to
%{_datadir} is acceptable - the guidelines say that the module should be
patched to cope with that.
It would certainly make life easier if it was allowed as it avoids the issue I
had with nodejs-mapnik-reference of needing to keep an unpatched copy for
running tests...
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=b8ZpL3xB86a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910148
--- Comment #8 from Jamie Nguyen jamieli...@fedoraproject.org ---
A while ago I asked T.C. Hollingsworth (who I assume has been involved in the
drafting of those guidelines) about this via private email:
T.C. Hollingsworth wrote:
Jamie Nguyen wrote:
Presumably then a line like:
fs.readFile(__dirname + '/../public/style.css', 'utf8', function(e, style)
Would have to be patched to:
fs.readFile('/usr/share/nodejs-connect/public/style.css', 'utf8',
function(e, style)
Or you could just symlink the public directory in
%{nodejs_sitelib}/connect to the proper location in %{_datadir}. That
way you don't have to carry and update a non-upstreamable patch
forever.
So I think it's fine.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=rC7jiwO6kca=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #9 from Tom Hughes t...@compton.nu --- Sounds good to me. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fejqhr3vTBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: nodejs-connect Short Description: High performance middleware framework for Node.js Owners: jamielinux Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hT9rYloO1Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910148
Tom Hughes t...@compton.nu changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|t...@compton.nu
Flags||fedora-review?
--- Comment #4 from Tom Hughes t...@compton.nu ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: %check is present and all tests pass.
I'm seeing 11 test failures when the tests are enabled.
[!]: Package complies to the Packaging Guidelines
Per https://fedoraproject.org/wiki/Packaging:Node.js#Installing_Modules
the images should I believe be installed in %{_datadir}?
Also, should lib-cov be installed? It's just a copy of lib annotated
for coverage testing isn't it?
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[!]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
Note: Package
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=910148
--- Comment #5 from Jamie Nguyen jamieli...@fedoraproject.org ---
[!]: %check is present and all tests pass.
I'm seeing 11 test failures when the tests are enabled.
Hmm, indeed my notes seem to say the same. Sorry, I must have forgotten about
this. Will try to fix.
[!]: Package complies to the Packaging Guidelines
Per https://fedoraproject.org/wiki/Packaging:Node.js#Installing_Modules
the images should I believe be installed in %{_datadir}?
Yes I believe you're right.
Also, should lib-cov be installed? It's just a copy of lib annotated
for coverage testing isn't it?
Correct. I thought I'd removed that from all of my review requests. A grep of
my specs seems to confirm this is the only case where I forgot!
New Spec/SRPM coming soon.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=PEIke9zs5Aa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #3 from Jamie Nguyen jamieli...@fedoraproject.org --- Update to upstream release 2.7.3. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-connect.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-connect-2.7.3-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d2clq3UkVqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On|910140 | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ECWfuKnQuYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- Make use of %%nodejs_fixdep. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-connect.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-connect-2.7.2-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kP6gJNUv6Za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||910140, 910138, 910142, ||910127, 910116, 910124, ||910125, 910139, 910121, ||910123, 910118 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aMnwjChfJga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||910150 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EtjzIdYf00a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||910154 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cAK30u7xVAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=910148 --- Comment #1 from Jamie Nguyen jamieli...@fedoraproject.org --- Added a comment about how to retrieve the test files. Spec URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/nodejs-connect.spec SRPM URL: http://jamielinux.fedorapeople.org/nodejs-buddycloud-http-api/SRPMS/nodejs-connect-2.7.2-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zYM6dFZqULa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
