[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|RAWHIDE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WLYZkZYynPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-cli-0.4.4.2-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qbODUeF2Lca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2013-03-26 09:50:22 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QF5mnQOkvSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-cli.spec SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-cli-0.4.4.2-1.fc18.src.rpm * Sat Mar 23 2013 Jamie Nguyen jamieli...@fedoraproject.org - 0.4.4.2-1 - fix file permissions in examples/ directory -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z6AHJtPJ9Ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 --- Comment #3 from Tom Hughes t...@compton.nu --- Just a couple of rpmlint warnings left: nodejs-cli.noarch: E: script-without-shebang /usr/lib/node_modules/cli/package.json nodejs-cli.noarch: W: doc-file-dependency /usr/share/doc/nodejs-cli-0.4.4.2/examples/static.coffee /usr/bin/env both are caused by spurious execute permissions. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mnvjKBe6YSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 --- Comment #4 from Jamie Nguyen jamieli...@fedoraproject.org --- Oops, sorry missed those. Fixed. Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-cli.spec SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-cli-0.4.4.2-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2e6NpXS5Tka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Tom Hughes t...@compton.nu --- Great. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tkBNS8s1j5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: nodejs-cli Short Description: Node.js module for rapidly building command line apps Owners: jamielinux Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zsfYu7VFxna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HwDrRji5qFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B2MJpPeUmCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-cli-0.4.4.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-cli-0.4.4.2-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MXvqUlxxJna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mYWTCWSasUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-cli-0.4.4.2-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MuSZ062X2La=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=911024
Tom Hughes t...@compton.nu changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||t...@compton.nu
Assignee|nob...@fedoraproject.org|t...@compton.nu
Flags||fedora-review?
--- Comment #1 from Tom Hughes t...@compton.nu ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package is named according to the Package Naming Guidelines.
I think the version should probably be 0.4.4.2 to take in the
sub-version that upstream has used.
- Requires correct, justified where necessary.
Bogus require on /usr/bin/env due to bogus execute permissions.
- Rpmlint is run on all installed packages.
All caused by bogus execute permissions:
nodejs-cli.noarch: E: script-without-shebang
/usr/lib/node_modules/cli/package.json
nodejs-cli.noarch: W: doc-file-dependency
/usr/share/doc/nodejs-cli-0.4.4/examples/echo.js /usr/bin/env
nodejs-cli.noarch: W: doc-file-dependency
/usr/share/doc/nodejs-cli-0.4.4/examples/progress.js /usr/bin/env
nodejs-cli.noarch: W: doc-file-dependency
/usr/share/doc/nodejs-cli-0.4.4/examples/static.js /usr/bin/env
nodejs-cli.noarch: W: doc-file-dependency
/usr/share/doc/nodejs-cli-0.4.4/examples/glob.js /usr/bin/env
nodejs-cli.noarch: W: doc-file-dependency
/usr/share/doc/nodejs-cli-0.4.4/examples/sort.js /usr/bin/env
nodejs-cli.noarch: W: doc-file-dependency
/usr/share/doc/nodejs-cli-0.4.4/examples/static.coffee /usr/bin/env
nodejs-cli.noarch: W: doc-file-dependency
/usr/share/doc/nodejs-cli-0.4.4/examples/command.js /usr/bin/env
nodejs-cli.noarch: W: doc-file-dependency
/usr/share/doc/nodejs-cli-0.4.4/examples/spinner.js /usr/bin/env
nodejs-cli.noarch: W: doc-file-dependency
/usr/share/doc/nodejs-cli-0.4.4/examples/long_desc.js /usr/bin/env
nodejs-cli.noarch: W: doc-file-dependency
/usr/share/doc/nodejs-cli-0.4.4/examples/cat.js /usr/bin/env
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 11 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package
[Bug 911024] Review Request: nodejs-cli - Node.js module for rapidly building command line apps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911024 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||911037 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RMulpWNxUZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
