[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-pkginfo-0.3.0-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CP0PyhKvsda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|RAWHIDE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2p0nHZcWXka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2013-03-19 10:09:45 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5csZzlxmZLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nodejs-pkginfo-0.3.0-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7qAawdLgeBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KvdVIDDXBxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=himqAUyzsRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nodejs-pkginfo-0.3.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-pkginfo-0.3.0-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DQNBZwFvs0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- Thanks for the review! Comment in spec file about license is redundant as you've updated to the new version with the license file. Fixed. Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-pkginfo.spec SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-pkginfo-0.3.0-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jS955HPrEoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Tom Hughes t...@compton.nu --- Looks good - package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=38mKc4hg9Ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: nodejs-pkginfo Short Description: An easy way to expose properties on a module from a package.json Owners: jamielinux Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BFyW42megOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7DkP667JFia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=911045
Tom Hughes t...@compton.nu changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|t...@compton.nu
Flags||fedora-review?
--- Comment #1 from Tom Hughes t...@compton.nu ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
Comment in spec file about license is redundant as you've updated
to the new version with the license file.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 12 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[-]: SourceX / PatchY prefixed with %{name}.
Note: Source0 (pkginfo-0.3.0.tgz)
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into
[Bug 911045] Review Request: nodejs-pkginfo - An easy way to expose properties on a module from a package.json
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911045 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||911060 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u9V1xvXjTJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
