[Bug 911111] Review Request: php-pecl-zendopcache - The Zend OPcache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=91 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-05-18 05:51:53 --- Comment #13 from Remi Collet fed...@famillecollet.com --- Avaiable in F17, F18 and EPEL-6 repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZZe6IzO4DJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911111] Review Request: php-pecl-zendopcache - The Zend OPcache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=91 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flags||fedora-cvs? Flags||rhel-rawhide- --- Comment #11 from Remi Collet fed...@famillecollet.com --- Great thanks for this review No F19 branch as this package is f18 and el6 only. New Package SCM Request === Package Name: php-pecl-zendopcache Short Description: The Zend OPcache Owners: remi Branches: f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gpBz0Fw2Yza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911111] Review Request: php-pecl-zendopcache - The Zend OPcache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=91 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CzkFbeJ1LHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911111] Review Request: php-pecl-zendopcache - The Zend OPcache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=91 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). Added f19 branch. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5VeBVc6FSya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911111] Review Request: php-pecl-zendopcache - The Zend OPcache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=91 Jared Smith jsmith.fed...@gmail.com changed: What|Removed |Added CC||jsmith.fed...@gmail.com Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vcSvhcV7XRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911111] Review Request: php-pecl-zendopcache - The Zend OPcache
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=91
Jared Smith jsmith.fed...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #10 from Jared Smith jsmith.fed...@gmail.com ---
[ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint spec srpm rpm
[jsmith@hockey PackageReview]$ rpmlint php-pecl-zendopcache.spec
php-pecl-zendopcache-7.0.1-2.remi.src.rpm
/home/jsmith/rpmbuild/RPMS/x86_64/php-pecl-zendopcache-7.0.1-2.fc18.x86_64.rpm
php-pecl-zendopcache.src: W: spelling-error %description -l en_US opcode - op
code, op-code, code
php-pecl-zendopcache.src: W: spelling-error %description -l en_US precompiled
- recompiled, p recompiled, recompile
php-pecl-zendopcache.src: W: spelling-error %description -l en_US bytecode -
byte code, byte-code, decorate
php-pecl-zendopcache.src: E: unknown-key GPG#00f97f56
php-pecl-zendopcache.x86_64: W: spelling-error %description -l en_US opcode -
op code, op-code, code
php-pecl-zendopcache.x86_64: W: spelling-error %description -l en_US
precompiled - recompiled, p recompiled, recompile
php-pecl-zendopcache.x86_64: W: spelling-error %description -l en_US bytecode
- byte code, byte-code, decorate
2 packages and 1 specfiles checked; 1 errors, 6 warnings.
Notice that the error is about an unknown signing key, and not relevant to the
package review.
[ O K ] MUST: The package must be named according to the Package Naming
Guidelines.
[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ O K ] MUST: The package must meet the Packaging Guidelines.
[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.
[ O K ] MUST: The License field in the package spec file must match the actual
license.
[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[ O K ] MUST: The spec file must be written in American English.
[ O K ] MUST: The spec file for the package MUST be legible.
[ O K ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[jsmith@hockey PackageReview]$ md5sum ~/rpmbuild/SOURCES/zendopcache-7.0.1.tgz
; curl -s -o - http://pecl.php.net/get/zendopcache-7.0.1.tgz | md5sum -
3a0a43a4819c72763bc35ecf5689221e
/home/jsmith/rpmbuild/SOURCES/zendopcache-7.0.1.tgz
3a0a43a4819c72763bc35ecf5689221e -
[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[ N/A ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ N/A ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ N/A ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[ O K ] MUST: Packages must NOT bundle copies of system libraries.
[ N/A ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory.
[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[ O K ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.
[ O K ] MUST: Each package must consistently use macros.
[ O K ] MUST: The
[Bug 911111] Review Request: php-pecl-zendopcache - The Zend OPcache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=91 --- Comment #9 from Remi Collet fed...@famillecollet.com --- Apply 2 upstream patch to allow comments in blacklist content and wildcard in blacklist filename (to keep conf in sync with 5.5.0beta3 in F19). https://github.com/remicollet/remirepo/commit/a5af16cb74375955d440b3435805fe08735dbaaa Spec: https://raw.github.com/remicollet/remirepo/a5af16cb74375955d440b3435805fe08735dbaaa/php/pecl/php-pecl-zendopcache/php-pecl-zendopcache.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-zendopcache-7.0.1-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1Vo4x8L8vWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911111] Review Request: php-pecl-zendopcache - The Zend OPcache
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=91 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Summary|Review Request: |Review Request: |php-pecl-zendoptimizerplus |php-pecl-zendopcache - The |- The Zend Optimizer+ |Zend OPcache --- Comment #8 from Remi Collet fed...@famillecollet.com --- Upstream project have been renamed to ZendOpcache, so : https://github.com/remicollet/remirepo/commit/a30c5d2d6c7a82ce852245ab2772b31a8b6050da Spec: https://raw.github.com/remicollet/remirepo/a30c5d2d6c7a82ce852245ab2772b31a8b6050da/php/pecl/php-pecl-zendopcache/php-pecl-zendopcache.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-zendopcache-7.0.1-1.remi.src.rpm As PHP 5.5.0 is already imported in Fedora 19, and already provides this extension (php-opcache package), this new package only target F17, F18 and EPEL-6. I think we have now the final name ;) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OWVXQkHIpja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
