[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 Giuseppe Marco Randazzo changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2020-04-28 15:57:07 --- Comment #13 from Giuseppe Marco Randazzo --- Dear all, thank you for your support and interest. I found a workaround package, tcpreply. With this message I would like to close this package request. Best regards, GMR -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|NEW CC||ppi...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 Fabian Affolter changed: What|Removed |Added CC|m...@fabian-affolter.ch | Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 --- Comment #12 from Eduardo Echeverria --- I'm still interested in know what is the fas of Giuseppe and if still he hasn't been sponsored. Like says Fabian, Giuseppe, please append the links of the spec and SRPM, usually reviewers use a tool named fedora-review, that expects those links be available at the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 --- Comment #11 from Fabian Affolter --- Can you please provide updated files (spec and SRPM)? Not as attachment to the report but rather as links. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 --- Comment #10 from Giuseppe Marco Randazzo --- Created attachment 918156 --> https://bugzilla.redhat.com/attachment.cgi?id=918156&action=edit bittwist Make file patch 2014-07-15 bittwist 2.0-2 Make file patch 2014-07-15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 --- Comment #9 from Giuseppe Marco Randazzo --- Created attachment 918155 --> https://bugzilla.redhat.com/attachment.cgi?id=918155&action=edit bittwist spec file 2014-07-15 bittwist spec file 2014-07-15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 Giuseppe Marco Randazzo changed: What|Removed |Added Attachment #911551|0 |1 is obsolete|| Attachment #911552|0 |1 is obsolete|| --- Comment #8 from Giuseppe Marco Randazzo --- Created attachment 918154 --> https://bugzilla.redhat.com/attachment.cgi?id=918154&action=edit bittwist-2.0-2 SRC RPM 2014-07-15 SRC RPM bittwist 2.0-2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? --- Comment #7 from Fabian Affolter --- Can you please provide updated files (spec and SRPM)? Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 --- Comment #6 from Giuseppe Marco Randazzo --- Created attachment 911552 --> https://bugzilla.redhat.com/attachment.cgi?id=911552&action=edit bittwist-Makefile patch The bittwist-Makefile patch. ~ Added the DESTDIR support ~ Fixed the make procedure to use the optflags -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 --- Comment #5 from Giuseppe Marco Randazzo --- Created attachment 911551 --> https://bugzilla.redhat.com/attachment.cgi?id=911551&action=edit bittwist new spec file New Bitwist spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 Giuseppe Marco Randazzo changed: What|Removed |Added Flags|needinfo?(gmrandazzo@gmail. | |com)| --- Comment #4 from Giuseppe Marco Randazzo --- Hello, yes i am still interested sorry for the delay!! :-) Here all the modifications!! I hope now the spec file and the patch are fine! Thanks!! Giuseppe Marco Randazzo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 --- Comment #3 from Fabian Affolter --- Giuseppe? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 Fabian Affolter changed: What|Removed |Added CC||gmranda...@gmail.com Flags||needinfo?(gmrandazzo@gmail. ||com) --- Comment #2 from Fabian Affolter --- Giuseppe, are you still interested to go on with this package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch Blocks||563471 (FE-SECLAB) Alias||bittwist Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911781 Eduardo Echeverria changed: What|Removed |Added CC||echevemas...@gmail.com --- Comment #1 from Eduardo Echeverria --- Hi Giuseppe About review process Perhaps you have tried to register at any time when the platform was not available, however, and the expectation that you are searching a different url, you retry with this. https://admin.fedoraproject.org/accounts/ These links may be useful: - https://fedoraproject.org/wiki/Package_Review_Process#Contributor - https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Use_rpmlint Is good practice paste the rpmlint output in the review, and at least make a build scratch on koji and paste the link in the review https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds Please tag the field "Blocks" with the word FE-NEEDSPONSOR. So, will let you know the sponsors you need sponsorship About the package I have not thoroughly checked the package, but at first glance, I give some recommendations You have a typo in this line URL:http://http://bittwist.sourceforge.net/ in %install make install prefix=${RPM_BUILD_ROOT}/usr should be make install DESTDIR=%{buildroot} PREFIX=%{_prefix} (if $DESTDIR supports) Check it $ rpm --eval %{_prefix} /usr the description should not be more than 80 characters per line, rpmlit complains with description-line-too-long - Please do honors applicable compiler flags, Use %{optflags} Check it $ rpm --eval %{optflags} -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic Check the makefile and do the patch, (do not forget to send the patch to upstream) bittwist: $(CC) $(CFLAGS) $(SRC)/bittwist.c -o $(SRC)/bittwist -I/usr/local/include -L/usr/local/lib -lpcap bittwiste: $(CC) $(CFLAGS) $(SRC)/bittwiste.c -o $(SRC)/bittwiste -I/usr/local/include -L/usr/local/lib -lpcap - the tag license is wrong License:GPL2 should be License:GPLv2 the changelog is wrong %changelog * Fri Feb 15 2013 Giuseppe Marco Randazzo - first build for bittwist should be %changelog * Fri Feb 15 2013 Giuseppe Marco Randazzo - 2.0-1 - first build for bittwist https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs - Don't needed %defattr(-,root,root) Kind Regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8VFX8a51Nx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review