[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-02-28 01:58:30 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gzKtIVI1Hja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- perl-Filesys-SmbClient-3.2-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QyIQlxJ9oFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- perl-Filesys-SmbClient-3.2-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YSG7m1qRjWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- perl-Filesys-SmbClient-3.2-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IAkKkSa1OTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TTY77ZW9Xsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #4 from Normunds fedora...@rule.lv --- Thanks :) * Removed BuildRequires except MakeMaker and samba dependency. * Added OPTIMIZE to Makefile.PL * Re-tested with Mock, currently re-testing with koji. Will post a note here if something fails (max 2 hours from now). Best regards. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UbaKpJhIKBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Petr Šabata psab...@redhat.com --- The current state is good enough for the review now. Approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pce3TwXEiBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 Normunds fedora...@rule.lv changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Normunds fedora...@rule.lv --- Thanks :) New Package SCM Request === Package Name: perl-Filesys-SmbClient Short Description: Samba client Perl module Owners: normunds psabata Branches: f17 f18 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uSoZjX5Vkta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0s3Kpoqfopa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mk9Ex23tO2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- perl-Filesys-SmbClient-3.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Filesys-SmbClient-3.2-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HBiVJWlCm8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- perl-Filesys-SmbClient-3.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Filesys-SmbClient-3.2-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S9ALR4TZu9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lKPXvmxcuHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=912477
--- Comment #3 from Petr Šabata psab...@redhat.com ---
The license address is not a blocker.
Since your package doesn't run the tests (for stated reasons), you can remove
most of your BRs, keeping just perl(ExtUtils::MakeMaker) and
perl(ExtUtils::MakeMaker).
54 perl Makefile.PL INSTALLDIRS=vendor CCFLAGS='-DHAVE_CLOSEFN'
This is an arch-dependent module, add OPTIMIZE=%{optflags} here.
The rest of the package looks good.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=i7e3TjwEF8a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #1 from Normunds fedora...@rule.lv --- Builds were tested with koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5023207 http://koji.fedoraproject.org/koji/taskinfo?taskID=5023350 http://koji.fedoraproject.org/koji/taskinfo?taskID=5023450 http://koji.fedoraproject.org/koji/taskinfo?taskID=5023612 Installed package was tested with upstream package tests: [fedora18] Filesys-SmbClient-3.2 $ perl t/* 1..19 ok 1 - Load module ok 2 - Create directory ok 3 - Create existent directory ok 4 - Create file ok 5 - Rename file ok 6 - Stat file ok 7 - Stat non-existent file ok 8 - Read file ok 9 - Read short directory ok 10 - Read long directory ok 11 - Unlink file ok 12 - Unlink non-existent file ok 13 - Create directory ok 14 - Create directory ok 15 - Rmdir entire directory ok 16 - Rm directory ok 17 - Rm non-existent directory ok 18 - Rename non-existent file There is a .c file in this directory with info about your params for you SMB server test. Think to remove it if you have finish with test. ok 19 - shutdown [fedora18] Filesys-SmbClient-3.2 $ perl t/02tie.t 1..25 ok 1 - Create directory ok 2 - tie open ok 3 - TIE: return of syswrite ok 4 - TIE: return of syswrite on a closed filehandle ok 5 - TIE: tie open a file stat() on unopened filehandle FD at /usr/share/perl5/File/Copy.pm line 138, F line 1. ok 6 - copy a filehandle with File::Copy ok 7 - TIE: Read one ligne of a file ok 8 - TIE: Read another ligne of a file ok 9 - TIE: getc of a file ok 10 - TIE: getc of a file ok 11 - TIE: getc of a file ok 12 - TIE: getc of a file ok 13 - TIE: seek SEEK_SET a file ok 14 - TIE: Return of read ok 15 - TIE: buffer read ok 16 - TIE: Seek SEEK_CUR a file open ok 17 - TIE: Seek SEEK_END a file open ok 18 - TIE: sysread return 0 at end of file ok 19 - TIE: seek return undef on closed file ok 20 - TIE: read return undef on closed file ok 21 - TIE: sysread return undef on closed file ok 22 - TIE: Read a file in list context ok 23 - Unlink file ok 24 - TIE: open a non-existent file ok 25 - Rm directory [fedora18] Filesys-SmbClient-3.2 $ perl t/03tie_perl56.t 1..20 ok 1 - Create directory ok 2 - TIE: open to create a file ok 3 - TIE: return of syswrite ok 4 - TIE: return of syswrite on a closed filehandle ok 5 - TIE: read a file ok 6 - TIE: Read one ligne of a file ok 7 - TIE: Read another ligne of a file ok 8 - TIE: getc of a file ok 9 - TIE: getc of a file ok 10 - TIE: getc of a file ok 11 - TIE: getc of a file ok 12 - TIE: seek SEEK_SET a file ok 13 - TIE: Return of read ok 14 - TIE: buffer read ok 15 - TIE: seek closed file ok 16 - TIE: read closed file ok 17 - TIE: Read a file in list context ok 18 - Unlink file ok 19 - TIE: open a non-existent file ok 20 - Rm directory [fedora18] Filesys-SmbClient-3.2 $ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VuGEkYj93Qa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912477] Review Request: perl-Filesys-SmbClient - Samba client Perl module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912477 --- Comment #2 from Normunds fedora...@rule.lv --- Upstream is notified about rpmlint license issue here: https://rt.cpan.org/Public/Bug/Display.html?id=83366 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LjUgbYp36la=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
