[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-12-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||kyua-testers-0.2-1.fc20
 Resolution|--- |ERRATA
Last Closed||2013-12-28 18:37:44



--- Comment #24 from Fedora Update System  ---
kyua-testers-0.2-1.fc20 has been pushed to the Fedora 20 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-12-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #23 from Fedora Update System  ---
kyua-testers-0.2-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/kyua-testers-0.2-1.fc20

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #22 from Fedora Update System  ---
kyua-testers-0.1-1.fc20 has been pushed to the Fedora 20 testing repository.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #21 from Julio Merino  ---
Package committed, new builds pushed to rawhide and f20 and update to f20
requested.  Will leave it up to bodhi to close this bug when the latter
happens.

Thanks all!

Now, to fix the build of kyua-cli...

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #20 from Fedora Update System  ---
kyua-testers-0.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/kyua-testers-0.1-1.fc20

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #19 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Julio Merino  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #18 from Julio Merino  ---
Thank you Mario, and apologies for the long delays in the process.

New Package SCM Request
===
Package Name: kyua-testers
Short Description: Automated testing framework (Scriptable tester interfaces)
Owners: jmmv
Branches: f20
InitialCC:

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Mario Blättermann  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #17 from Mario Blättermann  ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6224362

$ rpmlint -i -v *
kyua-testers.src: I: checking
kyua-testers.src: W: spelling-error %description -l en_US scriptable -> scrip
table, scrip-table, script able
The value of this tag appears to be misspelled. Please double-check.

kyua-testers.src: I: checking-url http://code.google.com/p/kyua/ (timeout 10
seconds)
kyua-testers.src: I: checking-url
http://kyua.googlecode.com/files/kyua-testers-0.1.tar.gz (timeout 10 seconds)
kyua-testers.src: W: invalid-url Source0:
http://kyua.googlecode.com/files/kyua-testers-0.1.tar.gz HTTP Error 404: Not
Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

kyua-testers.armv7hl: I: checking
kyua-testers.armv7hl: W: spelling-error %description -l en_US scriptable ->
scrip table, scrip-table, script able
The value of this tag appears to be misspelled. Please double-check.

kyua-testers.armv7hl: I: checking-url http://code.google.com/p/kyua/ (timeout
10 seconds)
kyua-testers.armv7hl: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/cli_test
kyua-testers.armv7hl: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/run_test
kyua-testers.armv7hl: E: missing-call-to-setgroups /usr/libexec/kyua-atf-tester
kyua-testers.armv7hl: E: missing-call-to-setgroups
/usr/libexec/kyua-plain-tester
kyua-testers.armv7hl: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/stacktrace_test
kyua-testers.i686: I: checking
kyua-testers.i686: W: spelling-error %description -l en_US scriptable -> scrip
table, scrip-table, script able
The value of this tag appears to be misspelled. Please double-check.

kyua-testers.i686: I: checking-url http://code.google.com/p/kyua/ (timeout 10
seconds)
kyua-testers.i686: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/cli_test
kyua-testers.i686: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/run_test
kyua-testers.i686: E: missing-call-to-setgroups /usr/libexec/kyua-atf-tester
kyua-testers.i686: E: missing-call-to-setgroups /usr/libexec/kyua-plain-tester
kyua-testers.i686: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/stacktrace_test
kyua-testers.x86_64: I: checking
kyua-testers.x86_64: W: spelling-error %description -l en_US scriptable ->
scrip table, scrip-table, script able
The value of this tag appears to be misspelled. Please double-check.

kyua-testers.x86_64: I: checking-url http://code.google.com/p/kyua/ (timeout 10
seconds)
kyua-testers.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/cli_test
kyua-testers.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/run_test
kyua-testers.x86_64: E: missing-call-to-setgroups /usr/libexec/kyua-atf-tester
kyua-testers.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-plain-tester
kyua-testers.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/stacktrace_test
kyua-testers-debuginfo.armv7hl: I: checking
kyua-testers-debuginfo.armv7hl: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-debuginfo.i686: I: checking
kyua-testers-debuginfo.i686: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-debuginfo.x86_64: I: checking
kyua-testers-debuginfo.x86_64: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-devel.armv7hl: I: checking
kyua-testers-devel.armv7hl: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-devel.armv7hl: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

kyua-testers-devel.i686: I: checking
kyua-testers-devel.i686: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

kyua-testers-devel.x86_64: I: checking
kyua-testers-devel.x86_64: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

kyua-testers.spec: I: checking-url
http://kyua.googlecode.com/files/kyua-testers-0.1.tar.gz (timeout 10 seconds)
kyua-testers.spec: W: invalid-url Source0:
http://kyua.googlecode.com/files/kyua-testers-0.1.tar.gz HTTP Error 404: Not
Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

kyua-testers-tests.armv7hl: I: checking
kyua-testers-tests.armv7hl: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-tests.armv7hl: E: missing-call-to-setgroups
/u

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #16 from Julio Merino  ---
Oops, my fault... I confused the servers in which these live due to copy/paste
and did not validate the links after hand-editing them:

Spec URL: ftp://ftp.NetBSD.org/pub/NetBSD/misc/jmmv/fedora/kyua-testers.spec
SRPM URL:
ftp://ftp.NetBSD.org/pub/NetBSD/misc/jmmv/fedora/kyua-testers-0.1-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #15 from Mario Blättermann  ---
(In reply to Julio Merino from comment #14)
> SRPM URL: http://www.NetBSD.org/~jmmv/kyua-testers-0.1-1.fc20.src.rpm

"Not Found

The requested URL /~jmmv/kyua-testers-0.1-1.fc20.src.rpm was not found on this
server."

And as far as I can see, the spec file is the previous one.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #14 from Julio Merino  ---
Alright, so:

- Changed %define with %global.
- Added a %_with_checks global, defaulting to 0 for now.
- Updated the changelog entry, which apparently also fixes the date.

Because of the new %_with_checks, it is not worth attempting to fix the current
kyua-cli package.  It's just easier and better to finish this package and
properly update kyua-cli to 0.7 which should "just work".

New URLs (because of the SRPM name change):

Spec URL: http://www.NetBSD.org/~jmmv/kyua-testers.spec
SRPM URL: http://www.NetBSD.org/~jmmv/kyua-testers-0.1-1.fc20.src.rpm

Thanks!

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #13 from Mario Blättermann  ---
I suggest to disable the %check section for the time being so that I can do a
proper scratch build and approve your package, unless some other blocker issues
come up. This way we get the package at least into Rawhide and you might
re-enable the tests once kyua-cli has the right version. Well, we would have a
ping-pong-scenario similar to that one I already mentioned, but it would work
as long as both packages are available from the repos. Currently, with one repo
package and one which has to be scratch-built it wouldn't work. Is this
imagineable for you to do so?

BTW, instead of disabling the checks you could add a condition which makes it
more simple to switch them on and off:

%global with_checks 1

Then, in the %check section itself, you use the if/then constructs to
enable/disable it.

Moreover, you are using the %define macro. In most cases, %global is the better
choice. See
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #12 from Julio Merino  ---
kyua-testers _only_ needs kyua-cli because of the %check target in the spec
file.  Getting rid of that would also let us kill the BuildRequires stanza on
kyua-cli and not introduce any cycles.  But doing so means we lose the
execution of the tests for kyua-testers during the build of a package; not a
huge deal given that these can be run later via the -tests subpackage.

The reason I sent it this way is because I thought that this could be OK as
long as at least one build for kyua-cli existed in the tree.  (This build could
exist with kyua-cli-0.5 if fixed.) 

What do you suggest?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #11 from Mario Blättermann  ---
Don't understand completely. The kyua-testers package is needed for updating
kyua to 0.6, but we require kyua-cli. This is an unresolvable ping-pong
dependency, as far as I can evaluate. As you see in the scratch builds, they
fail already with kyua-cli-0.5. I'm a bit confused about this situation.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #10 from Julio Merino  ---
So the issue with kyua-cli is that somebody attempted to upgrade it to 0.6,
committed the results, but I guess didn't even try to build the package. 
kyua-cli-0.6 requires kyua-testers, so no new versions can be built against the
right version of liblutok at the moment.

Question: Is it an OK procedure if I revert the bogus update of kyua-cli to 0.5
and rebuild a working version?  Because no binaries have been built for 0.6
yet, I suppose this is fine.  Alternatively I'd tweak the initial addition of
kyua-testers to not require kyua-cli.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #9 from Mario Blättermann  ---
Scratch build fails:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6219513

It is due to an unresolvable dependency in Rawhide:
DEBUG util.py:266:  Error: Package: kyua-cli-0.5-3.fc19.i686 (build)
DEBUG util.py:266: Requires: liblutok.so.0

New attempt for f20:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6219521

Same dependency problem there. The current lutok-0.3 package has liblutok.so.2,
the mentioned liblutok.so.0 is in the f19 package only. Seems to be a problem
in kyua-cli, which pulls lutok. It has to be resolved before we can continue on
this review. There are still f19 packages for kyua-cli in Rawhide, so I assume
it has build problems.

And last but not least an issue from build.log:
»warning: bogus date in %changelog: Mon Feb 19 2013 Julio Merino
 0.1-1«

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Christopher Meng  changed:

   What|Removed |Added

 CC|cicku...@gmail.com  |



--- Comment #8 from Christopher Meng  ---
(In reply to Julio Merino from comment #7)

Yes, it's more like a warning now for packagers.

Hope will Mario will do the review soon.

Thanks.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-11-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Julio Merino  changed:

   What|Removed |Added

  Flags|needinfo?(julio+redhat@mero |
   |h.net)  |



--- Comment #7 from Julio Merino  ---
Wow, sorry for the long delay in replying.  I haven't been paying attention
to neither Kyua nor Fedora for a long time for various personal reasons... and
recently just got back to them.

Regarding the missing-call-to-setgroups-before-setuid warning: it's true that
the code does not call setgroups, but this is not a real "problem".  The code
in the "tester" binaries implements logic to drop privileges for test cases
that request it, but this is _NOT_ intended to be a security feature and is
documented as such.  (Mind you, it's the test that chooses to request lower
privileges, not the user, so this really is not about security.)  Adding a call
to setgroups() would only silence this specific warning but would do nothing to
improve security.  I think this warning just needs to be ignored here.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-10-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Mario Blättermann  changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |



--- Comment #6 from Mario Blättermann  ---
No response from the package submitter for more than three months. If nothing
happens next two weeks, I consider to close this ticket.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Christopher Meng  changed:

   What|Removed |Added

 CC||julio+red...@meroh.net
  Flags||needinfo?(julio+redhat@mero
   ||h.net)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=g4ISujLE0C&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #5 from Mario Blättermann  ---
Any progress here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=0661xhtMnQ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Christopher Meng  changed:

   What|Removed |Added

 CC||cicku...@gmail.com

--- Comment #4 from Christopher Meng  ---
missing-call-to-setgroups has been renamed to
missing-call-to-setgroups-before-setuid.

This will be available in the next version.

And the explanation is:

This executable is calling setuid and setgid without setgroups or initgroups.
There is a high probability this mean it didn't relinquish all groups, and this
would be a potential security issue to be fixed. Seek POS36-C on the web for
details about the problem.

Ref POS36-C:

https://www.securecoding.cert.org/confluence/display/seccode/POS36-C.+Observe+correct+revocation+order+while+relinquishing+privileges

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ajPhPMs3pA&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-06-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Mario Blättermann  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review?

--- Comment #3 from Mario Blättermann  ---
(In reply to Julio Merino from comment #2)
> - I don't know what to do about missing-call-to-setgroups.  I cannot find
> any documentation on this check.  FWIW, rebuilding other packages that are
> already checked in results in this same warning even when such warning did
> not show up months ago.  It seems a new rule.
> 
You should ask in the packagers list  what
this means and how to handle it. It's an error, not a warning, so it should be
considered as serious for the time being.

I take this for a full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HZLGzjYJ6O&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-06-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

--- Comment #2 from Julio Merino  ---
Mario, thanks for taking a look.

The changes I have done:

- Removed the README.Fedora file from the main package as its contents are
specific to the -tests subpackage.
- Added the %{?_isa} chunk to all dependency specifications on libraries.  Not
sure if that's what you meant, but that's what I seem to understand from the
packaging guidelines.

However:

- I don't know what to do about missing-call-to-setgroups.  I cannot find any
documentation on this check.  FWIW, rebuilding other packages that are already
checked in results in this same warning even when such warning did not show up
months ago.  It seems a new rule.

I've had to move the new files here:

ftp://ftp.NetBSD.org/pub/NetBSD/misc/jmmv/fedora/kyua-testers.spec
ftp://ftp.NetBSD.org/pub/NetBSD/misc/jmmv/fedora/kyua-testers-0.1-1.fc18.src.rpm

Can you please take another look?  Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DjvIYWdUqZ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

2013-06-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=912816

Mario Blättermann  changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m

--- Comment #1 from Mario Blättermann  ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5476746

$ rpmlint -i -v *
kyua-testers.src: I: checking
kyua-testers.src: W: spelling-error %description -l en_US scriptable -> scrip
table, scrip-table, script able
The value of this tag appears to be misspelled. Please double-check.

kyua-testers.src: I: checking-url http://code.google.com/p/kyua/ (timeout 10
seconds)
kyua-testers.src: I: checking-url
http://kyua.googlecode.com/files/kyua-testers-0.1.tar.gz (timeout 10 seconds)
kyua-testers.src: W: invalid-url Source0:
http://kyua.googlecode.com/files/kyua-testers-0.1.tar.gz HTTP Error 404: Not
Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

kyua-testers.i686: I: checking
kyua-testers.i686: W: spelling-error %description -l en_US scriptable -> scrip
table, scrip-table, script able
The value of this tag appears to be misspelled. Please double-check.

kyua-testers.i686: I: checking-url http://code.google.com/p/kyua/ (timeout 10
seconds)
kyua-testers.i686: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/cli_test
kyua-testers.i686: E: missing-call-to-setgroups /usr/libexec/kyua-atf-tester
kyua-testers.i686: E: missing-call-to-setgroups /usr/libexec/kyua-plain-tester
kyua-testers.i686: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/run_test
kyua-testers.i686: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/stacktrace_test
kyua-testers.x86_64: I: checking
kyua-testers.x86_64: W: spelling-error %description -l en_US scriptable ->
scrip table, scrip-table, script able
The value of this tag appears to be misspelled. Please double-check.

kyua-testers.x86_64: I: checking-url http://code.google.com/p/kyua/ (timeout 10
seconds)
kyua-testers.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/cli_test
kyua-testers.x86_64: E: missing-call-to-setgroups /usr/libexec/kyua-atf-tester
kyua-testers.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-plain-tester
kyua-testers.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/run_test
kyua-testers.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/stacktrace_test
kyua-testers-debuginfo.i686: I: checking
kyua-testers-debuginfo.i686: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-debuginfo.x86_64: I: checking
kyua-testers-debuginfo.x86_64: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-devel.i686: I: checking
kyua-testers-devel.i686: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

kyua-testers-devel.x86_64: I: checking
kyua-testers-devel.x86_64: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

kyua-testers.spec: I: checking-url
http://kyua.googlecode.com/files/kyua-testers-0.1.tar.gz (timeout 10 seconds)
kyua-testers.spec: W: invalid-url Source0:
http://kyua.googlecode.com/files/kyua-testers-0.1.tar.gz HTTP Error 404: Not
Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

kyua-testers-tests.i686: I: checking
kyua-testers-tests.i686: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-tests.i686: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/cli_test
kyua-testers-tests.i686: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/run_test
kyua-testers-tests.i686: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/stacktrace_test
kyua-testers-tests.x86_64: I: checking
kyua-testers-tests.x86_64: I: checking-url http://code.google.com/p/kyua/
(timeout 10 seconds)
kyua-testers-tests.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/cli_test
kyua-testers-tests.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/run_test
kyua-testers-tests.x86_64: E: missing-call-to-setgroups
/usr/libexec/kyua-testers/tests/stacktrace_test
9 packages and 1 specfiles checked; 16 errors, 7 warnings.


Unavailable Googlecode URLs are a common problem. Don't bother with it, the
tarball is downloadable using wget.

Spelling errors are ignorable.

"missing-call-to-setgroups"
Don't know what this means, it is not mentioned in the wiki. Needs to be
investigated.

README.fedora is superfluous in the -tests package. The main package is present
when installing the tests, so the file is available anyway.