[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0.1-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OIcTWFqB30a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0.1-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8SkQMzo18ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0.1-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k029s1TGLma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/icaro-1.0.1-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6baIg09y7qa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/icaro-1.0.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iaIZJTox2Ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/icaro-1.0.1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g1EmLWzj5La=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-03-22 17:11:48 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p1IliptUBka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9rsYnMzgupa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h4KZtnMPNIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LSw2EyOrLwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0-3.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QJXaFibE9ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Matthias Runge mru...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HdiVrmuYrxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Matthias Runge mru...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Matthias Runge mru...@redhat.com --- Package Review == Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: === - Header files in -devel subpackage, if present. Note: icaro : /usr/share/icaro/pic16/np05/source/common_types2.h icaro : /usr/share/icaro/pic16/np05/source/define2.h icaro : /usr/share/icaro/pic16/np05/tmp/boot_iface.h icaro : /usr/share/icaro/pic16/np05/tmp/common_types.h icaro : /usr/share/icaro/pic16/np05/tmp/define.h icaro : /usr/share/icaro/pic16/np05/tmp/macro.h icaro : /usr/share/icaro/pic16/np05/tmp/usb/picUSB.h icaro : /usr/share/icaro/pic16/np05/tmp/usb/usb_bulk.h icaro : /usr/share/icaro/pic16/np05/tmp/usb/usb_cdc.h icaro : /usr/share/icaro/pic16/np05/tmp/usb/usb_config.h icaro : /usr/share/icaro/pic16/np05/tmp/usb/usb_uart.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages This is ok, since this is a package to provide a development environment. And also: bundling exception for the included library. https://fedorahosted.org/fpc/ticket/253 - update-desktop-database is invoked when required Note: desktop file(s) in icaro See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Must be a false positive. The required scriptlets are included. = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: LGPL (v2.1 or later), *No copyright* GPL (v3 or later), GPL (v2 or later), GPL (v3 or later), Unknown or generated. 5 files have unknown license. Detailed output of licensecheck in /home/mrunge/review/912930-icaro/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked when required Note: icons in icaro [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 51200 bytes in 3 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Eduardo Echeverria echevemas...@gmail.com --- Thanks for the review Matthias New Package SCM Request === Package Name: icaro Short Description: Robotic Educational Project Owners: echevemaster yaderv Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bGU0ssaVxYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v6aYvLgDMya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #9 from Eduardo Echeverria echevemas...@gmail.com --- Package Change Request == Package Name: icaro New Branches: f19 Owners: echevemaster yaderv -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6gJVzYYl2Ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tXDg0QblmTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/icaro-1.0-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qT8f5MD6Jma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- icaro-1.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/icaro-1.0-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F7tDHA1rFJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #5 from Eduardo Echeverria echevemas...@gmail.com --- Hi Matthias, here are the new files, I solved all the issues: Spec URL: http://echevemaster.fedorapeople.org/icaro_final/3/icaro.spec SRPMS URL: http://echevemaster.fedorapeople.org/icaro_final/3/icaro-1.0-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PyzlWQQFRoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #3 from Matthias Runge mru...@redhat.com --- Ooops, sorry, this took so long. Eduardo, please move header files to a sub package: - Header files in -devel subpackage, if present. Note: icaro : /usr/share/icaro/pic16/np05/source/boot_iface.h icaro : /usr/share/icaro/pic16/np05/source/common_types.h icaro : /usr/share/icaro/pic16/np05/source/define.h icaro : /usr/share/icaro/pic16/np05/source/macro.h icaro : /usr/share/icaro/pic16/np05/source/usb/picUSB.h icaro : /usr/share/icaro/pic16/np05/source/usb/usb_bulk.h icaro : /usr/share/icaro/pic16/np05/source/usb/usb_cdc.h icaro : /usr/share/icaro/pic16/np05/source/usb/usb_config.h icaro : /usr/share/icaro/pic16/np05/source/usb/usb_uart.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - update-desktop-database is invoked when required Note: desktop file(s) in icaro See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - is there any particular reason not to use the %find_lang macro? - since you're using /usr/share/icons/hicolor/48x48, you need to require something providing that path, e.g. hicolor-icon-theme (please check status of that, I think it was recently orphaned) and we have a mixture of licenses here: LGPL (v2.1 or later) /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro-55e2c11a61810477a60f4a162072db92dcfd13d8/pic16/np05/source/servos.c *No copyright* GPL (v3 or later) /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro-55e2c11a61810477a60f4a162072db92dcfd13d8/componente.py GPL (v2 or later) - /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro-55e2c11a61810477a60f4a162072db92dcfd13d8/docker.py GPL (v3 or later) - /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro-55e2c11a61810477a60f4a162072db92dcfd13d8/creditos.py -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6PREpmTCdBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 --- Comment #4 from Eduardo Echeverria echevemas...@gmail.com --- (In reply to comment #3) Ooops, sorry, this took so long. Eduardo, please move header files to a sub package: - Header files in -devel subpackage, if present. Note: icaro : /usr/share/icaro/pic16/np05/source/boot_iface.h icaro : /usr/share/icaro/pic16/np05/source/common_types.h icaro : /usr/share/icaro/pic16/np05/source/define.h icaro : /usr/share/icaro/pic16/np05/source/macro.h icaro : /usr/share/icaro/pic16/np05/source/usb/picUSB.h icaro : /usr/share/icaro/pic16/np05/source/usb/usb_bulk.h icaro : /usr/share/icaro/pic16/np05/source/usb/usb_cdc.h icaro : /usr/share/icaro/pic16/np05/source/usb/usb_config.h icaro : /usr/share/icaro/pic16/np05/source/usb/usb_uart.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages This files aren't for development, these are used by the application to dynamically incorporate routines to PIC - update-desktop-database is invoked when required Note: desktop file(s) in icaro See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache I don't understand this point, I don't use the command update-desktop-database (besides that not there any entry mimetype key in the desktop file) for nothing in this spec - is there any particular reason not to use the %find_lang macro? No, in fact I changed the spec. thanks for the catch - since you're using /usr/share/icons/hicolor/48x48, you need to require something providing that path, e.g. hicolor-icon-theme (please check status of that, I think it was recently orphaned) is assigned to Vicodan (Dan Marshall) AFAIK, I've incorporated to the spec. and we have a mixture of licenses here: LGPL (v2.1 or later) /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro- 55e2c11a61810477a60f4a162072db92dcfd13d8/pic16/np05/source/servos.c *No copyright* GPL (v3 or later) /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro- 55e2c11a61810477a60f4a162072db92dcfd13d8/componente.py GPL (v2 or later) - /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro- 55e2c11a61810477a60f4a162072db92dcfd13d8/docker.py GPL (v3 or later) - /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/icaro- 55e2c11a61810477a60f4a162072db92dcfd13d8/creditos.py l'll ask upstream about this. soon I upload the updated files. thanks matthias. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lcm8cSgs7Ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Matthias Runge mru...@redhat.com changed: What|Removed |Added CC||mru...@redhat.com Assignee|nob...@fedoraproject.org|mru...@redhat.com --- Comment #2 from Matthias Runge mru...@redhat.com --- will do the review. If anybody else is faster, please go ahead! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jvlEmf8dyca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) CC||g...@xofica.cl --- Comment #1 from Eduardo Echeverria echevemas...@gmail.com --- *** Bug 750898 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ObGMGlRFHfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912930] Review Request : icaro - Robotic Educational Project
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912930 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CUUhkLr6VRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review