[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- gitstats-0-0.4.20130224git0843039.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PkaXK72T79a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-03-12 04:33:13 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rlw0pBwoUPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- gitstats-0-0.4.20130224git0843039.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OkVs5ko9Q1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- gitstats-0-0.4.20130224git0843039.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=miZuMgT5hba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1pFyY0dYCna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- gitstats-0-0.4.20130224git0843039.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IPPaylqlr9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 Stephen Gordon sgor...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Stephen Gordon sgor...@redhat.com --- New Package SCM Request === Package Name: gitstats Short Description: Generates statistics based on GIT repository activity Owners: sgordon Branches: f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4VwrMFiiXha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sNTVo8OVE8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eQYfr66kTja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- gitstats-0-0.4.20130224git0843039.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/gitstats-0-0.4.20130224git0843039.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B4WpfwbDena=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- gitstats-0-0.4.20130224git0843039.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gitstats-0-0.4.20130224git0843039.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vVAe7VFKpGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- gitstats-0-0.4.20130224git0843039.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/gitstats-0-0.4.20130224git0843039.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2rBGQidLfEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=914996
Pavel Raiskup prais...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #10 from Pavel Raiskup prais...@redhat.com ---
Hi Stephen, one simple fix in changelog should be done:
-* Mon Feb 25 2013 Stephen Gordon sgor...@redhat.com 0-0.4-20130224git0843039
+* Mon Feb 25 2013 Stephen Gordon sgor...@redhat.com 0-0.4.20130224git0843039
HERE ^
Sorry I didn't mention it before, I thought it was a bug in rpmlint but I was
just blind. Please fix it before pushing to git.
APPROVED
===
===
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[!]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 61440 bytes in 5 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=914996
Pavel Raiskup prais...@redhat.com changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #6 from Pavel Raiskup prais...@redhat.com ---
Hi Stephenm, here is my first comment iteration :)
===
1. bad spec naming?
Upstream have already updated to resolve this so I've updated the SPEC and
SRPM to pick this up. I also realized that there is .pod file provided which
can be used to generate the man page so that is now also included.
Spec URL: http://fedorapeople.org/~sgordon/gitstats-0.2.spec
SRPM URL:
http://fedorapeople.org/~sgordon/gitstats-0.2-20130224git0843039.fc18.src.rpm
Why do you now call the spec file gitstats-0.2.spec and not gitstats.spec?
Your
first specfile was called gitstats.spec..
2. unnecessary %attr() macros
$ cat *.spec
[...]
%files
%attr(755, root, root) %{_bindir}/%{name}
^^ none of these should be needed
3. Missing release number
Release:%{checkout}%{?dist}
I think that even the first release number should be specified. Partly because
I (as a reviewer) can see, where it will be finally placed and because of this
also:
$ rpmdev-vercmp gitstats-0.2-20130224git0843039
gitstats-0.2-1.20130224git0843039
gitstats-0.2-20130224git0843039 gitstats-0.2-1.20130224git0843039
4. (nit: I would create one-newline separator between changelog entries)
5. Gzip inside BuildRequires is redundant .. it must be installed on minimum
build system.
Pavel
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=L8GL0SGVx7a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=914996
--- Comment #7 from Stephen Gordon sgor...@redhat.com ---
(In reply to comment #6)
Hi Stephenm, here is my first comment iteration :)
===
1. bad spec naming?
Upstream have already updated to resolve this so I've updated the SPEC and
SRPM to pick this up. I also realized that there is .pod file provided which
can be used to generate the man page so that is now also included.
Spec URL: http://fedorapeople.org/~sgordon/gitstats-0.2.spec
SRPM URL:
http://fedorapeople.org/~sgordon/gitstats-0.2-20130224git0843039.fc18.src.rpm
Why do you now call the spec file gitstats-0.2.spec and not gitstats.spec?
Your
first specfile was called gitstats.spec..
I've actually had reviewers request that I do that in the past so they can see
the differences between the submitted files (rather than overwriting each
time).
2. unnecessary %attr() macros
$ cat *.spec
[...]
%files
%attr(755, root, root) %{_bindir}/%{name}
^^ none of these should be needed
Removed.
3. Missing release number
Release:%{checkout}%{?dist}
I think that even the first release number should be specified. Partly
because
I (as a reviewer) can see, where it will be finally placed and because of
this
also:
$ rpmdev-vercmp gitstats-0.2-20130224git0843039
gitstats-0.2-1.20130224git0843039
gitstats-0.2-20130224git0843039 gitstats-0.2-1.20130224git0843039
I went back and reviewed the naming/versioning guidelines and have ended up
with names of the form gitstats-0-0.3.20130224git0843039. I reset the version
to 0 as this is effectively pre-release software (no formal releases) and use
the revision number to maintain the ordering as shown in the example:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
4. (nit: I would create one-newline separator between changelog entries)
Done
5. Gzip inside BuildRequires is redundant .. it must be installed on minimum
build system.
Removed
Pavel
Thanks Pavel, updated files are here:
Spec URL: http://fedorapeople.org/~sgordon/gitstats.spec
SRPM URL:
http://fedorapeople.org/~sgordon/gitstats-0-0.3.20130224git0843039.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=rOwuBPrChya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=914996
--- Comment #8 from Pavel Raiskup prais...@redhat.com ---
Why do you now call the spec file gitstats-0.2.spec and not gitstats.spec?
Your
first specfile was called gitstats.spec..
I've actually had reviewers request that I do that in the past so they can
see the differences between the submitted files (rather than overwriting
each time).
This is off-topic, but the git (cgit) is able to do this for you - you are able
to post everytime the same link to spec file and the history is not lost.
3. Missing release number
[..]
I went back and reviewed the naming/versioning guidelines and have ended up
with names of the form gitstats-0-0.3.20130224git0843039. I reset the
version to 0 as this is effectively pre-release software (no formal
releases) and use the revision number to maintain the ordering as shown in
the example:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
Nice! Thanks for this fix. I missed that the 0.2 was not upstream version.
The N-V-R as you are using now is OK.
===
Another problems:
1. package should own all directories it creates
$ rpm -qf /usr/share/gitstats
file /usr/share/gitstats is not owned by any package
+ %dir {_datarootdir}/%{name} probably should be added
2. Packages should try to preserve timestamps of original installed files
s/install/install -p/
Otherwise it seems to be ok to me. I'll re-run the fedora-review script and
post deep info when these are fixed.
Thanks for your work!
Pavel
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=YNvDZPL6Tsa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #9 from Stephen Gordon sgor...@redhat.com --- Spec URL: http://fedorapeople.org/~sgordon/gitstats.spec SRPM URL: http://fedorapeople.org/~sgordon/gitstats-0-0.4.20130224git0843039.fc18.src.rpm * Mon Feb 25 2013 Stephen Gordon sgor...@redhat.com 0-0.4-20130224git0843039 - Added /usr/share/gitstats to files list. - Added -p argument to install invocation to preserve timestamps. - Use release macro in pod2man arguments instead of rebuilding the equivalent again using the other macros. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E8bFrhugOaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #4 from Stephen Gordon sgor...@redhat.com --- (In reply to comment #2) https://github.com/hoxu/gitstats/issues/13 Upstream have already updated to resolve this so I've updated the SPEC and SRPM to pick this up. I also realized that there is .pod file provided which can be used to generate the man page so that is now also included. Spec URL: http://fedorapeople.org/~sgordon/gitstats-0.2.spec SRPM URL: http://fedorapeople.org/~sgordon/gitstats-0.2-20130224git0843039.fc18.src.rpm $ rpmlint gitstats.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint gitstats-0.2-20130224git0843039.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint gitstats-0.2-20130224git0843039.fc18.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5051056 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mSISPWomnma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 Pavel Raiskup prais...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||prais...@redhat.com Assignee|nob...@fedoraproject.org|prais...@redhat.com --- Comment #5 from Pavel Raiskup prais...@redhat.com --- Thanks for packaging, I'll look at this review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YRSWyZf1Jca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #1 from Stephen Gordon sgor...@redhat.com --- $ rpmlint gitstats.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint gitstats-0.1-20130223gitaa77a89.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint gitstats-0.1-20130223gitaa77a89.fc18.noarch.rpm gitstats.noarch: W: no-manual-page-for-binary gitstats 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9JzKy8JgLNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #2 from Stephen Gordon sgor...@redhat.com --- NB: When reviewing the sources to determine the license I found that while the documentation files shipped by upstream list GPLv2 and GPLv3 one of the files is licensed under the MIT license. I have raised a ticket with upstream to address this omission in the licenses file and noted all three licenses in the spec file: https://github.com/hoxu/gitstats/issues/13 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gC7HPvLZ0Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 914996] Review Request: gitstats - Generates statistics based on GIT repository activity
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=914996 --- Comment #3 from Stephen Gordon sgor...@redhat.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5048859 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mQhoLC4txKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
