[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
https://bugzilla.redhat.com/show_bug.cgi?id=916432 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #18 from Ralph Bean rb...@redhat.com --- Package Change Request == Package Name: python-geojson New Branches: epel7 Owners: ralph -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
https://bugzilla.redhat.com/show_bug.cgi?id=916432 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #19 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
https://bugzilla.redhat.com/show_bug.cgi?id=916432 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2013-05-27 17:52:22 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g71B4wFfSta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- python-geojson-1.0.1-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vj9chTeJADa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- python-geojson-1.0.1-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sKJpapz4Tba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- python-geojson-1.0.1-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3SedNezmf9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #13 from Volker Fröhlich volke...@gmx.at --- Please push the updates to stable! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7n3oODRTBHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-geojson-1.0.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jthHGWAwVka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Ralph Bean rb...@redhat.com --- New Package SCM Request === Package Name: python-geojson Short Description: Encoder/decoder for simple GIS features Owners: ralph Branches: f19 f18 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SSvaYctZP1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tu6L9XvM44a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gsSVGoq2MHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mg2xPhT77pa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-geojson-1.0.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-geojson-1.0.1-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eh5DenhaJKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-geojson-1.0.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-geojson-1.0.1-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zON3q8Zxv1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-geojson-1.0.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-geojson-1.0.1-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wgYPlaUXJLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-geojson-1.0.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-geojson-1.0.1-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=C0TpRIQuWWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Yohan Graterol yohangratero...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QQ1D5rkGxra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=916432
--- Comment #6 from Yohan Graterol yohangratero...@gmail.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 5 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Yohan Graterol yohangratero...@gmail.com changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D1WYT3qnN9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Yohan Graterol yohangratero...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|yohangratero...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gouWhIpNnYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=916432
--- Comment #5 from Ralph Bean rb...@redhat.com ---
Stuff like this:
File objects.txt, line 60, in objects.txt
Failed example:
feature_dict # doctest: +ELLIPSIS
Expected:
{u'geometry': {u'type': u'Point', u'coordinates': [4..., -54...]}, u'type':
u'Feature', u'properties': {}, u'id': None}
Got:
{'geometry': {'type': 'Point', 'coordinates': [4.53242, -54.1231]}, 'type':
'Feature', 'properties': {}, 'id': None}
The testing framework seems to be failing, but not the code under test.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=02fo0XgCVFa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Yohan Graterol yohangratero...@gmail.com changed: What|Removed |Added CC||yohangratero...@gmail.com --- Comment #4 from Yohan Graterol yohangratero...@gmail.com --- Hello Ralph, What's the error that showed in test? Really your package pass successfully fedora-review , but I want know about the test! Regards! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VjjXLfbJ5Ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #3 from Ralph Bean rb...@redhat.com --- Hi, I removed the example and patched out the setuptools requirement. I couldn't find anywhere it was actually used at runtime (sometimes it is required for entry-points iteration at runtime). I couldn't get the tests to pass. It has to do with their use of doctests' ELLIPSIS.. with which I'm unfamiliar. I gave it a good try, though. Spec URL: http://threebean.org/rpm/python-geojson.spec SRPM URL: http://threebean.org/rpm/python-geojson-1.0.1-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EL4ejsylOTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #2 from Volker Fröhlich volke...@gmx.at --- I'd suggest to remove everything from Here's an example on from the description. I notice that the setuptools are listed under install_requires in setup.py. To my knowledge, install_requires is supposed to list runtime requirements. Does it really need the setuptools at runtime? Can something be done to run the tests successfully? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4OEkviwtBya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 --- Comment #1 from Ralph Bean rb...@redhat.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5063079 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5PVRJaumsda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916432] Review Request: python-geojson - Encoder/decoder for simple GIS features
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916432 Ralph Bean rb...@redhat.com changed: What|Removed |Added Blocks||916433 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VMRmCFSNERa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
