[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-06 20:38:17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5fb0kJphuTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-xml2js-0.2.6-2.fc18, nodejs-oauth-0.9.10-1.fc18, carto-0.9.4-1.fc18, nodejs-passport-oauth-0.1.14-3.fc18, nodejs-millstone-0.5.15-2.fc18, nodejs-srs-0.2.20-2.fc18, nodejs-sqlite3-2.1.5-4.fc18, nodejs-zipfile-0.3.4-3.fc18, nodejs-chrono-1.0.4-1.fc18, nodejs-sphericalmercator-1.0.2-1.fc18, nodejs-mapnik-reference-5.0.4-2.fc18, nodejs-passport-0.1.16-1.fc18, nodejs-step-0.0.5-1.fc18, nodejs-zap-0.2.5-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u8Fhb24wy9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Bug 917412 depends on bug 915484, which changed state. Bug 915484 Summary: Review Request: nodejs-zipfile - C++ library for handling zipfiles in node https://bugzilla.redhat.com/show_bug.cgi?id=915484 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gJCp4Nrjtia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Bug 917412 depends on bug 917312, which changed state. Bug 917312 Summary: Review Request: nodejs-srs - Spatial reference library for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=917312 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EEVjwLP6s8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Bug 917412 depends on bug 915488, which changed state. Bug 915488 Summary: Review Request: nodejs-sqlite3 - Asynchronous, non-blocking SQLite3 bindings for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=915488 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=44llO7PwLla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Bug 917412 depends on bug 917308, which changed state. Bug 917308 Summary: Review Request: nodejs-step - A simple control-flow library for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=917308 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RCIPr0Gaiba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=waT21oW58ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hqs9Y7lP43a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-xml2js-0.2.6-2.fc18, nodejs-oauth-0.9.10-1.fc18, carto-0.9.4-1.fc18, nodejs-passport-oauth-0.1.14-3.fc18, nodejs-millstone-0.5.15-2.fc18, nodejs-srs-0.2.20-2.fc18, nodejs-sqlite3-2.1.5-4.fc18, nodejs-zipfile-0.3.4-3.fc18, nodejs-chrono-1.0.4-1.fc18, nodejs-sphericalmercator-1.0.2-1.fc18, nodejs-mapnik-reference-5.0.4-2.fc18, nodejs-passport-0.1.16-1.fc18, nodejs-step-0.0.5-1.fc18, nodejs-zap-0.2.5-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1QbvsFGVjfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nodejs-xml2js-0.2.6-2.fc18, nodejs-srs-0.2.20-1.fc18, nodejs-sqlite3-2.1.5-3.fc18, nodejs-zipfile-0.3.4-2.fc18, nodejs-millstone-0.5.15-1.fc18, nodejs-oauth-0.9.10-1.fc18, nodejs-chrono-1.0.4-1.fc18, nodejs-sphericalmercator-1.0.2-1.fc18, nodejs-mapnik-reference-5.0.4-2.fc18, nodejs-passport-0.1.16-1.fc18, nodejs-step-0.0.5-1.fc18, nodejs-zap-0.2.5-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JzN9vkFliQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8Sd1NuUHz9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MPAgi1TDmma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VEOYuG4Ooza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nodejs-xml2js-0.2.6-2.fc18, nodejs-srs-0.2.20-1.fc18, nodejs-sqlite3-2.1.5-3.fc18, nodejs-zipfile-0.3.4-2.fc18, nodejs-millstone-0.5.15-1.fc18, nodejs-oauth-0.9.10-1.fc18, carto-0.9.4-1.fc18, nodejs-passport-oauth-0.1.14-3.fc18, nodejs-chrono-1.0.4-1.fc18, nodejs-sphericalmercator-1.0.2-1.fc18, nodejs-mapnik-reference-5.0.4-2.fc18, nodejs-passport-0.1.16-1.fc18, nodejs-step-0.0.5-1.fc18, nodejs-zap-0.2.5-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uCftqJ1YOVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yGVAnnSkOua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fJM9mm2LgBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- nodejs-xml2js-0.2.6-2.fc18, nodejs-srs-0.2.20-1.fc18, nodejs-sqlite3-2.1.5-3.fc18, nodejs-zipfile-0.3.4-2.fc18, nodejs-millstone-0.5.15-1.fc18, nodejs-oauth-0.9.10-1.fc18, nodejs-chrono-1.0.4-1.fc18, nodejs-sphericalmercator-1.0.2-1.fc18, nodejs-mapnik-reference-5.0.4-2.fc18, nodejs-passport-0.1.16-1.fc18, nodejs-step-0.0.5-1.fc18, nodejs-zap-0.2.5-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/FEDORA-2013-3075/nodejs-millstone-0.5.15-1.fc18,nodejs-oauth-0.9.10-1.fc18,nodejs-srs-0.2.20-1.fc18,nodejs-sqlite3-2.1.5-3.fc18,nodejs-zipfile-0.3.4-2.fc18,nodejs-xml2js-0.2.6-2.fc18,nodejs-zap-0.2.5-2.fc18,nodejs-step-0.0.5-1.fc18,nodejs-passport-0.1.16-1.fc18,nodejs-sphericalmercator-1.0.2-1.fc18,nodejs-mapnik-reference-5.0.4-2.fc18,nodejs-chrono-1.0.4-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hDtksSiFaNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added CC||jamieli...@fedoraproject.or ||g Assignee|nob...@fedoraproject.org|jamieli...@fedoraproject.or ||g Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WFTxPad4QUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=917412
--- Comment #1 from Jamie Nguyen jamieli...@fedoraproject.org ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses found.
Please check the source files for licenses manually.
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 4 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
= EXTRA items =
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Rpmlint is run on all installed
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- Oops. Ignore the issues section above. License is fine. Package approved! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hKX2e5OgaQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Tom Hughes t...@compton.nu --- New Package SCM Request === Package Name: nodejs-millstone Short Description: Prepares data sources in an MML file for consumption in Mapnik Owners: tomh Branches: f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1YRt0rvPwea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Tom Hughes t...@compton.nu changed: What|Removed |Added Depends On||915488, 917312, 917308, ||915484 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=21zYJAH2Doa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917412] Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917412 Tom Hughes t...@compton.nu changed: What|Removed |Added Blocks||917413 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DZZ0yfciUla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
