[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Bug 917413 depends on bug 915095, which changed state. Bug 915095 Summary: Review Request: nodejs-mapnik-reference - Reference for Mapnik Styling Options https://bugzilla.redhat.com/show_bug.cgi?id=915095 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F3FWTbwDYX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Bug 917413 depends on bug 917419, which changed state. Bug 917419 Summary: Review Request: nodejs-xml2js - Simple XML to JavaScript object converter https://bugzilla.redhat.com/show_bug.cgi?id=917419 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sGVFdBbGrz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Bug 917413 depends on bug 917412, which changed state. Bug 917412 Summary: Review Request: nodejs-millstone - Prepares data sources in an MML file for consumption in Mapnik https://bugzilla.redhat.com/show_bug.cgi?id=917412 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o0vAR3REWh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 --- Comment #8 from Fedora Update System --- nodejs-xml2js-0.2.6-2.fc18, nodejs-oauth-0.9.10-1.fc18, carto-0.9.4-1.fc18, nodejs-passport-oauth-0.1.14-3.fc18, nodejs-millstone-0.5.15-2.fc18, nodejs-srs-0.2.20-2.fc18, nodejs-sqlite3-2.1.5-4.fc18, nodejs-zipfile-0.3.4-3.fc18, nodejs-chrono-1.0.4-1.fc18, nodejs-sphericalmercator-1.0.2-1.fc18, nodejs-mapnik-reference-5.0.4-2.fc18, nodejs-passport-0.1.16-1.fc18, nodejs-step-0.0.5-1.fc18, nodejs-zap-0.2.5-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2yXWNGDrKh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-06 20:38:00 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2m2Tss2LIw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 --- Comment #7 from Fedora Update System --- nodejs-xml2js-0.2.6-2.fc18, nodejs-oauth-0.9.10-1.fc18, carto-0.9.4-1.fc18, nodejs-passport-oauth-0.1.14-3.fc18, nodejs-millstone-0.5.15-2.fc18, nodejs-srs-0.2.20-2.fc18, nodejs-sqlite3-2.1.5-4.fc18, nodejs-zipfile-0.3.4-3.fc18, nodejs-chrono-1.0.4-1.fc18, nodejs-sphericalmercator-1.0.2-1.fc18, nodejs-mapnik-reference-5.0.4-2.fc18, nodejs-passport-0.1.16-1.fc18, nodejs-step-0.0.5-1.fc18, nodejs-zap-0.2.5-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1F6LzHIGfu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bqVFo9e0W7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DpgobjuTJj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 --- Comment #6 from Fedora Update System --- nodejs-xml2js-0.2.6-2.fc18, nodejs-srs-0.2.20-1.fc18, nodejs-sqlite3-2.1.5-3.fc18, nodejs-zipfile-0.3.4-2.fc18, nodejs-millstone-0.5.15-1.fc18, nodejs-oauth-0.9.10-1.fc18, carto-0.9.4-1.fc18, nodejs-passport-oauth-0.1.14-3.fc18, nodejs-chrono-1.0.4-1.fc18, nodejs-sphericalmercator-1.0.2-1.fc18, nodejs-mapnik-reference-5.0.4-2.fc18, nodejs-passport-0.1.16-1.fc18, nodejs-step-0.0.5-1.fc18, nodejs-zap-0.2.5-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2GzMpUfqke&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z6os3IbOS5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 --- Comment #5 from Fedora Update System --- nodejs-xml2js-0.2.6-2.fc18, nodejs-srs-0.2.20-1.fc18, nodejs-sqlite3-2.1.5-3.fc18, nodejs-zipfile-0.3.4-2.fc18, nodejs-millstone-0.5.15-1.fc18, nodejs-oauth-0.9.10-1.fc18, carto-0.9.4-1.fc18, nodejs-passport-oauth-0.1.14-3.fc18, nodejs-chrono-1.0.4-1.fc18, nodejs-sphericalmercator-1.0.2-1.fc18, nodejs-mapnik-reference-5.0.4-2.fc18, nodejs-passport-0.1.16-1.fc18, nodejs-step-0.0.5-1.fc18, nodejs-zap-0.2.5-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/FEDORA-2013-3075/carto-0.9.4-1.fc18,nodejs-passport-oauth-0.1.14-3.fc18,nodejs-millstone-0.5.15-1.fc18,nodejs-oauth-0.9.10-1.fc18,nodejs-srs-0.2.20-1.fc18,nodejs-sqlite3-2.1.5-3.fc18,nodejs-zipfile-0.3.4-2.fc18,nodejs-xml2js-0.2.6-2.fc18,nodejs-zap-0.2.5-2.fc18,nodejs-step-0.0.5-1.fc18,nodejs-passport-0.1.16-1.fc18,nodejs-sphericalmercator-1.0.2-1.fc18,nodejs-mapnik-reference-5.0.4-2.fc18,nodejs-chrono-1.0.4-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v0EIkKJxjZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xoYkoxK7Yu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Uh9Q2lPYr1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Tom Hughes changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Tom Hughes --- New Package SCM Request === Package Name: carto Short Description: Mapnik style sheet compiler Owners: tomh Branches: f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Aqe2iJdC8f&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 --- Comment #2 from Jamie Nguyen --- Oops, typo. The %nodejs-fixdep should actually be %nodejs_fixdep, though I assume you already know about that. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yk7pYKGP4i&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=917413
Jamie Nguyen changed:
What|Removed |Added
Flags|fedora-cvs? |
Flags||fedora-review+
--- Comment #1 from Jamie Nguyen ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
Instead of patching, you can do this in %prep:
%nodejs_fixdep underscore '~1.4.3'
%nodejs-fixdep xml2js '~0.2.4'
The man page has this line:
\fI\fR
I'd prefer if it was changed to:
\fI\fR
Otherwise the underlining has gaps and users might misinterpret as 3 arguments
rather than 1. Pretty unlikely, but still.
Well, the fixdep issue has no functional consequence and the man page issue is
subject to personal preference, so package approved!
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Build
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Jamie Nguyen changed: What|Removed |Added CC||jamieli...@fedoraproject.or ||g Assignee|nob...@fedoraproject.org|jamieli...@fedoraproject.or ||g Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r3EY8ibAYg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Tom Hughes changed: What|Removed |Added Depends On||917419 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hd30hDwREY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917413] Review Request: carto - Mapnik style sheet compiler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917413 Tom Hughes changed: What|Removed |Added Depends On||915095, 917412 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bzTHCAmT1i&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
