[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||python-py2neo-1.5-2.fc19 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-py2neo-1.5-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cWvgVhyAl3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-py2neo-1.5-2.fc19|python-py2neo-1.5-2.fc18 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-py2neo-1.5-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=quzOMvuDhVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5524777
$ rpmlint -i -v *python3-py2neo.noarch: I: checking
python3-py2neo.noarch: I: checking-url http://py2neo.org/ (timeout 10 seconds)
python-py2neo.noarch: I: checking
python-py2neo.noarch: I: checking-url http://py2neo.org/ (timeout 10 seconds)
python-py2neo.src: I: checking
python-py2neo.src: I: checking-url http://py2neo.org/ (timeout 10 seconds)
python-py2neo.src: I: checking-url
https://pypi.python.org/packages/source/p/py2neo/py2neo-1.5.tar.gz (timeout 10
seconds)
python-py2neo.spec: I: checking-url
https://pypi.python.org/packages/source/p/py2neo/py2neo-1.5.tar.gz (timeout 10
seconds)
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
No issues.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
ASL 2.0
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
a1cdde32cb1d614262b70ef0dbb1aba168beb9d2bcb7132d936919089c4986f6
py2neo-1.5.tar.gz
a1cdde32cb1d614262b70ef0dbb1aba168beb9d2bcb7132d936919089c4986f6
py2neo-1.5.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: python-py2neo Short Description: A simple Python library that provides access to Neo4j Owners: jamielinux Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZBxRbgTK7Fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fidBVv2x8Ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=19NT4Y3xtza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-py2neo-1.5-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-py2neo-1.5-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qJsmtP61lKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O9wARj62Ywa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-py2neo-1.5-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-py2neo-1.5-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=icYwamwo1Ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2013-06-20 14:47:41 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pefyurywhYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5521020
$ rpmlint -i -v *
python3-py2neo.noarch: I: checking
python3-py2neo.noarch: I: checking-url http://py2neo.org/ (timeout 10 seconds)
python3-py2neo.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
python-py2neo.noarch: I: checking
python-py2neo.noarch: I: checking-url http://py2neo.org/ (timeout 10 seconds)
python-py2neo.src: I: checking
python-py2neo.src: I: checking-url http://py2neo.org/ (timeout 10 seconds)
python-py2neo.src: I: checking-url
https://pypi.python.org/packages/source/p/py2neo/py2neo-1.5.tar.gz (timeout 10
seconds)
python-py2neo.spec: I: checking-url
https://pypi.python.org/packages/source/p/py2neo/py2neo-1.5.tar.gz (timeout 10
seconds)
3 packages and 1 specfiles checked; 0 errors, 1 warnings.
Some objections from my side:
A py3 version of a package should be standalone and shouldn't depend on the py2
version. You have to do the following:
* Don't remove the py3 scripts in /usr/bin. Rename and install them in the py
package.
* Rename the manpages for the py3 package to avoid package conflicts.
* The doc files may be present in both py2 and py3 packages.
Moreover, remove the executable bit again from the scripts in
%{python_sitelib}. Usually, no script there needs to be executable. Probably
you was a bit mislead by the shebangs, which you also have to remove from the
file headers. In doubt, ask the upstream developer.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=jF04zdRxWsa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 --- Comment #4 from Jamie Nguyen jamieli...@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/python/python-py2neo.spec SRPM URL: http://jamielinux.fedorapeople.org/python/SRPMS/python-py2neo-1.5-2.fc19.src.rpm * Thu Jun 20 2013 Jamie Nguyen jamieli...@fedoraproject.org - 1.5-2 - make python3 subpackage standalone, renaming scripts to foo-python3 - remove executable bits and extraneous shebangs -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r3FDf4rIJ9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/python/python-py2neo.spec SRPM URL: http://jamielinux.fedorapeople.org/python/SRPMS/python-py2neo-1.5-1.fc19.src.rpm * Wed Jun 19 2013 Jamie Nguyen jamieli...@fedoraproject.org - 1.5-1 - update to upstream release 1.5 - add missing BR - remove redundant build variables - add custom man pages (generated with help2man) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rFrGKMHpcwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fUd5GQmUU4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
https://bugzilla.redhat.com/show_bug.cgi?id=919933 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com --- python3-devel is required for the python3 version, shouldn't be python2-devel also be needed for the python2 one? A noarch package doesn't need a CFLAGS statement. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6XMyAD2laoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919933 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Summary|Review Request: |Review Request: |python-py2neo - short |python-py2neo - A simple |summary here |Python library that ||provides access to Neo4j -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZMXuea6WLfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
