[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Shakthi Kannan changed: What|Removed |Added Status|NEW |ASSIGNED CC||shakthim...@gmail.com Assignee|nob...@fedoraproject.org|shakthim...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P1aNzGKzib&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174
Shakthi Kannan changed:
What|Removed |Added
Status|ASSIGNED|ON_DEV
--- Comment #3 from Shakthi Kannan ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 256000 bytes in 18 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define.
= EXTRA items =
Generic:
[x]: Large data in /usr/share should live in a noarch subpack
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 --- Comment #4 from Jens Petersen --- Thank you for reviewing. I will ask upstream about the missing license file. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DuO7tpO2n9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Jens Petersen changed: What|Removed |Added Status|ON_DEV |ASSIGNED --- Comment #5 from Jens Petersen --- Note it is "should" not "must" for the license file. I have contact Lennart but I am not expecting any quick response or change immediately. This should not block the review anyway. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VJ08RaOjMc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Shakthi Kannan changed: What|Removed |Added Status|ASSIGNED|ON_DEV Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Shakthi Kannan --- Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tPAD5xfZap&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Jens Petersen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Jens Petersen --- Thanks New Package SCM Request === Package Name: ghc-geniplate Short Description: Template Haskell for Uniplate-like functions Owners: petersen Branches: f17 f18 f19 el6 InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pwdLXM9TD9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7dXh785L8X&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q1gaIKSbO4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Fedora Update System changed: What|Removed |Added Status|ON_DEV |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7BO0ijupWH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 --- Comment #9 from Fedora Update System --- ghc-geniplate-0.6.0.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ghc-geniplate-0.6.0.3-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0nqPLw8ZBm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 --- Comment #11 from Fedora Update System --- ghc-geniplate-0.6.0.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ghc-geniplate-0.6.0.3-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=chPvxF53iB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 --- Comment #10 from Fedora Update System --- ghc-geniplate-0.6.0.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ghc-geniplate-0.6.0.3-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=afJ20AwdGD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 --- Comment #12 from Fedora Update System --- ghc-geniplate-0.6.0.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ghc-geniplate-0.6.0.3-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7rZSVyAqzd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Jens Petersen changed: What|Removed |Added Whiteboard|Ready | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=izBuJyDO8m&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- ghc-geniplate-0.6.0.3-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t9uePslak4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ghc-geniplate-0.6.0.3-1.fc1 ||9 Resolution|--- |ERRATA Last Closed||2013-06-18 02:09:01 --- Comment #14 from Fedora Update System --- ghc-geniplate-0.6.0.3-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bgT4XLJvds&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Fedora Update System changed: What|Removed |Added Fixed In Version|ghc-geniplate-0.6.0.3-1.fc1 |ghc-geniplate-0.6.0.3-1.fc1 |9 |7 --- Comment #15 from Fedora Update System --- ghc-geniplate-0.6.0.3-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ohBC24l7RG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Fedora Update System changed: What|Removed |Added Fixed In Version|ghc-geniplate-0.6.0.3-1.fc1 |ghc-geniplate-0.6.0.3-1.fc1 |7 |8 --- Comment #16 from Fedora Update System --- ghc-geniplate-0.6.0.3-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NRxRcfKAAL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
https://bugzilla.redhat.com/show_bug.cgi?id=920174 Fedora Update System changed: What|Removed |Added Fixed In Version|ghc-geniplate-0.6.0.3-1.fc1 |ghc-geniplate-0.6.0.3-1.el6 |8 | --- Comment #17 from Fedora Update System --- ghc-geniplate-0.6.0.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mfgf7dQSEM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920174 --- Comment #1 from Jens Petersen --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5106753 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ds0HDJ6sJx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920174 Jens Petersen changed: What|Removed |Added Blocks||892566 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qwsp03vQIj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920174 --- Comment #2 from Jens Petersen --- Needed for Agda -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Pg9tFFgAla&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920174] Review Request: ghc-geniplate - Use template Haskell to generate Uniplate-like functions
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920174 Jens Petersen changed: What|Removed |Added Whiteboard||Ready -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iqHnCeVlFD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
