[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #36 from Fedora Update System upda...@fedoraproject.org --- boost148-1.48.0-7.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #35 from Fedora Update System upda...@fedoraproject.org --- boost148-1.48.0-7.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||boost148-1.48.0-7.el7 Resolution|--- |ERRATA Last Closed||2015-05-08 12:40:03 --- Comment #34 from Fedora Update System upda...@fedoraproject.org --- boost148-1.48.0-7.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #33 from Fedora Update System upda...@fedoraproject.org --- Package boost148-1.48.0-7.el7: * should fix your issue, * was pushed to the Fedora EPEL 7 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing boost148-1.48.0-7.el7' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-5890/boost148-1.48.0-7.el7 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- boost148-1.48.0-7.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/boost148-1.48.0-7.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #31 from Fedora Update System upda...@fedoraproject.org --- boost148-1.48.0-7.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/boost148-1.48.0-7.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #32 from Fedora Update System upda...@fedoraproject.org --- boost148-1.48.0-7.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/boost148-1.48.0-7.el5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #25 from Denis Arnaud denis.arnaud_fed...@m4x.org --- Successful builds on EPEL 6 for all the architectures: http://koji.fedoraproject.org/koji/taskinfo?taskID=9463313 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #26 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- boost148-1.48.0-5.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/boost148-1.48.0-5.el5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- boost148-1.48.0-6.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/boost148-1.48.0-6.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- boost148-1.48.0-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/boost148-1.48.0-6.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #19 from Denis Arnaud denis.arnaud_fed...@m4x.org --- EPEL 7: http://koji.fedoraproject.org/koji/taskinfo?taskID=9463024 The builds were successful for both x86-64 and ppc64 (there is an error at the end in Koji, but it seems to be a Koji issue, as all the RPMs have successfully been built) - So, ready for approval? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134
--- Comment #18 from Denis Arnaud denis.arnaud_fed...@m4x.org ---
Spec URL: http://denisarnaud.fedorapeople.org/boost/boost148/boost148.spec
SRPM URL:
http://denisarnaud.fedorapeople.org/boost/boost148/boost148-1.48.0-5.fc20.src.rpm
EPEL 7: http://koji.fedoraproject.org/koji/taskinfo?taskID=9462960
EPEL 6: http://koji.fedoraproject.org/koji/taskinfo?taskID=9462986 (the build
is fine, but the Koji build process fails at the end because of a lack of
resource)
===
(In reply to Rex Dieter from comment #16)
May be worth reviewing later commits/fixes to base boost-1.48.0 pkg up to:
http://pkgs.fedoraproject.org/cgit/boost.git/commit/
?id=dcde8a75575cb4c256ea982593c9710ac16b022c
Done. Integrated all the missing patches.
1 MUST fix missing -math dep in main metapackage and missing scriptlets
fixed in:
http://pkgs.fedoraproject.org/cgit/boost.git/commit/
?id=8aad81e67cbfd196e040449b0bf2cd854642c447
Done
2. SHOULD consider using %{name} and %{?_isa} macros in place of
hard-coding boost148 in dependencies. imo, that simplifies things keeps
things consistent. for example, replace
Requires: boost148-chrono = %{version}-%{release}
with
Requires: %{name}-chrono%{?_isa} = %{version}-%{release}
Done
Did not check yet whether the fix for ppc64 works.
===
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134
--- Comment #23 from Denis Arnaud denis.arnaud_fed...@m4x.org ---
(In reply to Denis Arnaud from comment #21)
(In reply to Rex Dieter from comment #20)
The el6 failure is an undefined macro:
+ '%{_mpich2_load}'
/var/tmp/rpm-tmp.pLSGl7: line 97: fg: no job control
The only thing I do not understand, then, is why it used to work before. For
instance,
http://denisarnaud.fedorapeople.org/boost/boost148/boost148-1.48.0-4.spec
contains the exact same macro (%{_mpich2_load})...
As a matter of fact, MPICH2 has been upgraded into MPICH v3. So, the macro is
now simply named _mpich_load (the '2' suffix has been dropped).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #24 from Denis Arnaud denis.arnaud_fed...@m4x.org --- Successful build on EPEL 6: http://koji.fedoraproject.org/koji/taskinfo?taskID=9463281 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #20 from Rex Dieter rdie...@math.unl.edu ---
The el6 failure is an undefined macro:
+ '%{_mpich2_load}'
/var/tmp/rpm-tmp.pLSGl7: line 97: fg: no job control
I won't treat it as a review blocker here, since the epel-7 build succeeds, but
obviously this needs to be fixed if you want to support epel-6
Thanks.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134
--- Comment #21 from Denis Arnaud denis.arnaud_fed...@m4x.org ---
(In reply to Rex Dieter from comment #20)
The el6 failure is an undefined macro:
+ '%{_mpich2_load}'
/var/tmp/rpm-tmp.pLSGl7: line 97: fg: no job control
Thanks!
The only thing I do not understand, then, is why it used to work before. For
instance,
http://denisarnaud.fedorapeople.org/boost/boost148/boost148-1.48.0-4.spec
contains the exact same macro (%{_mpich2_load})...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 Denis Arnaud denis.arnaud_fed...@m4x.org changed: What|Removed |Added Flags||fedora-cvs+ --- Comment #22 from Denis Arnaud denis.arnaud_fed...@m4x.org --- New Package SCM Request === Package Name: boost148 Short Description: The free peer-reviewed portable C++ source libraries Upstream URL: http://www.boost.org/users/history/version_1_48_0.html Owners: denisarnaud Branches: f20 f21 f22 el5 el6 epel7 InitialCC: rdieter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 Denis Arnaud denis.arnaud_fed...@m4x.org changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 --- Comment #17 from Denis Arnaud denis.arnaud_fed...@m4x.org --- Boost148 as SCL (Software Collection): http://www.softwarecollections.org/en/scls/denisarnaud/boost148/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|denis.arnaud_fed...@m4x.org |rdie...@math.unl.edu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134
--- Comment #16 from Rex Dieter rdie...@math.unl.edu ---
May be worth reviewing later commits/fixes to base boost-1.48.0 pkg up to:
http://pkgs.fedoraproject.org/cgit/boost.git/commit/?id=dcde8a75575cb4c256ea982593c9710ac16b022c
In particular,
1 MUST fix missing -math dep in main metapackage and missing scriptlets fixed
in:
http://pkgs.fedoraproject.org/cgit/boost.git/commit/?id=8aad81e67cbfd196e040449b0bf2cd854642c447
most of the other commits to 1.48.0 don't look like review blockers to me, but
please look it over sooner or later.
naming: ok
license: ok
sources: ok
d1e9a7a7f532bb031a3c175d86688d95 boost_1_48_0.tar.bz2
macros: mostly ok (see item 2)
2. SHOULD consider using %{name} and %{?_isa} macros in place of hard-coding
boost148 in dependencies. imo, that simplifies things keeps things consistent.
for example, replace
Requires: boost148-chrono = %{version}-%{release}
with
Requires: %{name}-chrono%{?_isa} = %{version}-%{release}
Fresh scratch epel-6 build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6053896
which fails on ppc64 due to:
Error: No Package found for mpich2-devel
3. MUST fix build failure on ppc64 somehow, preferably by avoiding
ExcludeArch. Possibly omitting mpich bits on ppc64 , something like updating:
%ifarch %{arm}
%bcond_with mpich2
to
%ifarch %{arm} ppc64
%bcond_with mpich2
I think the rest looks pretty good (so far).
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries
https://bugzilla.redhat.com/show_bug.cgi?id=921134 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||package-review@lists.fedora ||project.org, ||rdie...@math.unl.edu Component|boost141|Package Review --- Comment #15 from Rex Dieter rdie...@math.unl.edu --- reassiging to Package Review component. I may have need of this so will likely be able to help review this soon. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
