[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 Josef Stribny changed: What|Removed |Added Status|NEW |ASSIGNED CC||jstri...@redhat.com Assignee|nob...@fedoraproject.org|jstri...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qwsLdXskwr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 --- Comment #1 from Josef Stribny --- Hi, above SRPM URL does not work so I took the one from your koji scratch build. Rpmlint: $ rpmlint rubygem-foreman_api.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint rubygem-foreman_api-0.1.1-5.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rubygem-foreman_api-0.1.1-5.fc19.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint rubygem-foreman_api-doc-0.1.1-5.fc19.noarch.rpm rubygem-foreman_api-doc.noarch: W: spelling-error Summary(en_US) api -> pi, ape, apt rubygem-foreman_api-doc.noarch: W: spelling-error %description -l en_US api -> pi, ape, apt rubygem-foreman_api-doc.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Mock: - builds for f17-f19 - works for Ruby < 2 Koji: - builds in rawhide [1] SPEC file: - Looks good. Issues: - I cannot test it against Ruby 2.0 since rubygem-oauth is still not rebuilt. Since rubygem-foreman_api doesn't come up with the test suite I think it's important to wait for all the deps to be rebuilt and present in rawhide to test it more properly. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=5137620 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YPdyrzuAxo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 --- Comment #2 from Miroslav Suchý --- This is the same as you took from koji, but for sake of correctness: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-foreman_api/rubygem-foreman_api.spec SRC.RPM http://miroslav.suchy.cz/fedora/rubygem-foreman_api/rubygem-foreman_api-0.1.1-5.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=96iRUCJfxL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=921985
--- Comment #3 from Josef Stribny ---
Thanks Miroslav,
before the rubygem-oauth is rebuilt I have two recommendations for the spec
file:
1, %{gem_docdir} could be marked as %doc
Since %{gem_docdir} contains only doc files and no executable files, it
should be marked as %doc. From the guidelines [1]: "Any relevant documentation
included in the source distribution should be included in the package as %doc"
2, %{gem_cache} should be excluded
%{gem_cache} has no purpose in this RPM and should be excluded.
[1] http://fedoraproject.org/wiki/Packaging:Guidelines
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=aewkhxjUMA&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 --- Comment #4 from Miroslav Suchý --- Oauth is already rebuilt. Updated according #3: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-foreman_api/rubygem-foreman_api.spec SRC.RPM http://miroslav.suchy.cz/fedora/rubygem-foreman_api/rubygem-foreman_api-0.1.1-6.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=j1UrjuG3XS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 Josef Stribny changed: What|Removed |Added Flags||fedora-review+ --- Comment #5 from Josef Stribny --- Hi, I built it [1] with koji and installed locally using mock. I haven't found any issue so I am APPROVING the package. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=5224610 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xBt3a2xIEb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 Miroslav Suchý changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Miroslav Suchý --- New Package SCM Request === Package Name: rubygem-foreman_api Short Description: Ruby bindings for Forman's rest API Owners: msuchy Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XF9vIN0j8A&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1eywrA8FZu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Jx5Q9IicsP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JK8ZCiopW8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 --- Comment #8 from Fedora Update System --- rubygem-foreman_api-0.1.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-foreman_api-0.1.3-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BAMcGWEsli&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 --- Comment #9 from Fedora Update System --- rubygem-foreman_api-0.1.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-foreman_api-0.1.3-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0yd484NicU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 Miroslav Suchý changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-04-08 10:06:36 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=reI1L8Y7lC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 Fedora Update System changed: What|Removed |Added Resolution|NEXTRELEASE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wdj5HRp1Vi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921985 --- Comment #10 from Fedora Update System --- rubygem-foreman_api-0.1.3-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r1PBml8NTD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
