[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
https://bugzilla.redhat.com/show_bug.cgi?id=924350 Wolfgang Ulbrich changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed|2013-05-15 13:29:05 |2014-08-21 15:45:01 --- Comment #18 from Wolfgang Ulbrich --- http://koji.fedoraproject.org/koji/buildinfo?buildID=569606 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #17 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
https://bugzilla.redhat.com/show_bug.cgi?id=924350 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
https://bugzilla.redhat.com/show_bug.cgi?id=924350 Wolfgang Ulbrich changed: What|Removed |Added Flags|fedora-cvs- |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
https://bugzilla.redhat.com/show_bug.cgi?id=924350 Wolfgang Ulbrich changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs- Keywords||Reopened --- Comment #16 from Wolfgang Ulbrich --- Package Change Request == Package Name: mate-applet-lockkeys New Branches: epel7 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 Fedora Update System changed: What|Removed |Added Fixed In Version|mate-applet-lockkeys-0.2.0- |mate-applet-lockkeys-0.2.0- |2.fc17 |2.fc18 --- Comment #15 from Fedora Update System --- mate-applet-lockkeys-0.2.0-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DQVLigDtvD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 Fedora Update System changed: What|Removed |Added Fixed In Version|mate-applet-lockkeys-0.2.0- |mate-applet-lockkeys-0.2.0- |2.fc18 |2.fc17 --- Comment #14 from Fedora Update System --- mate-applet-lockkeys-0.2.0-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nDZEvLkXY5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mate-applet-lockkeys-0.2.0- ||2.fc18 Resolution|--- |ERRATA Last Closed||2013-05-15 13:29:05 --- Comment #13 from Fedora Update System --- mate-applet-lockkeys-0.2.0-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8DpDwsbsXW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #12 from Fedora Update System --- mate-applet-lockkeys-0.2.0-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JGn5g8zDg3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HLV1E2MJCa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #11 from Patrick Monnerat --- About comment 7: Yes, you finally got it :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SQkliz3K9Q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #10 from Fedora Update System --- mate-applet-lockkeys-0.2.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-applet-lockkeys-0.2.0-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GpRcckAUtE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #9 from Fedora Update System --- mate-applet-lockkeys-0.2.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mate-applet-lockkeys-0.2.0-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZxaylH6his&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #8 from Fedora Update System --- mate-applet-lockkeys-0.2.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-applet-lockkeys-0.2.0-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0LVug7sBz6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y8SL4f0LHs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #7 from Wolfgang Ulbrich --- Opps, i got it, you meant the url. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pGvUDNhf61&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #6 from Wolfgang Ulbrich --- Patrick, i'm still wondering about your hint with the download link If i use http://www.zavedil.com/wp-content/uploads/2013/02/mate-applet-lockkeys-0.2.0.tar.gz ,than the download works. http://www.zavedil.com/mate-lock-keys-applet/mate-applet-lockkeys-0.2.0.tar.gz gives me an error. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kLIfYRCA5J&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zBg5tYeNYJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3RcSbYsOZs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 Wolfgang Ulbrich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Wolfgang Ulbrich --- New Package SCM Request === Package Name: mate-applet-lockkeys Short Description: MATE Keyboard LED indicator Owners: raveit65 Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3ev5NLIaPh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #3 from Wolfgang Ulbrich --- Thank you Patrick for review. I will include your hints before uploading to git. @ ScrollLock This is a known issue, scrollock doesn't work in general for this package. Assen knows about this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dcdSKQzAMq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=924350
Patrick Monnerat changed:
What|Removed |Added
CC||p...@datasphere.ch
Assignee|dan.mas...@gmail.com|p...@datasphere.ch
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Patrick Monnerat ---
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5335821
Minor TODOs:
Please change the URL to http://www.zavedil.com/mate-lock-keys-applet/
Also remove NEWS from docs since this file is empty.
Please note I only have a virtual console for testing the functionality: using
it, I've been able to succeed with CapsLock and NumLock, but ScrollLock fails.
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: glib-compile-schemas is run if required
Note: gschema file(s) in mate-applet-lockkeys
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked when required
Note: icons in mate-applet-lockkeys
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 7 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separat
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 --- Comment #1 from Wolfgang Ulbrich --- Dan, after 40 days of no action from you, i quess you're revised and have no time to review the request. Please do an action over the weekend. I think you agree that i reset 'assigned to' to nobody after the weekend, because of non blocking other potential reviewers. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MCgZ4EWFVM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924350] Review Request: mate-applet-lockkeys - MATE Keyboard LED indicator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924350 Dan Mashal changed: What|Removed |Added Status|NEW |ASSIGNED CC||dan.mas...@gmail.com Assignee|nob...@fedoraproject.org|dan.mas...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZB75ckqMh2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
