[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #31 from Fedora Update System upda...@fedoraproject.org --- owfs-2.9p1-4.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S4QfVIIna5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||owfs-2.9p1-4.fc19 Resolution|--- |ERRATA Last Closed||2013-07-20 05:46:05 --- Comment #32 from Fedora Update System upda...@fedoraproject.org --- owfs-2.9p1-4.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=szrJxtbpkTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- owfs-2.9p1-4.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9WBwRcrHjXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #21 from Tomasz Torcz zdzi...@irc.pl --- I can only reproduce this error on Fedora 17, where those macros weren't defined/pulled in int buildroot. The package builds fine in F18, F19 and rawhide mocks for me. Are you using F17? It's going out of support in 3 weeks, it's not worth to get owfs building on it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WKAzTHC1KRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #22 from Lorenzo Dalrio lorenzo.dal...@gmail.com --- I am using Fedora 19 with fedora-review-0.4.1-2.fc19.noarch -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=C5b05JsUOVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #23 from Lorenzo Dalrio lorenzo.dal...@gmail.com --- Koji scratch build fails with same error: http://koji.fedoraproject.org/koji/taskinfo?taskID=5587023 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ktHlptji6va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added Attachment #768204|0 |1 is obsolete|| --- Comment #24 from Tomasz Torcz zdzi...@irc.pl --- Created attachment 771011 -- https://bugzilla.redhat.com/attachment.cgi?id=771011action=edit owfs.spec changes SPEC: http://ttorcz.fedorapeople.org/owfs.spec SRPM: http://ttorcz.fedorapeople.org/owfs-2.9p1-4.fc18.src.rpm Scrt: http://koji.fedoraproject.org/koji/taskinfo?taskID=5587592 Found the problem, required RPM macros are in systemd, so added BR. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vOoPessMDna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237
Lorenzo Dalrio lorenzo.dal...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #25 from Lorenzo Dalrio lorenzo.dal...@gmail.com ---
Ok Tomasz, well done! For me now package is OK, full review follows:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in owfs-libs ,
owfs-capi , owfs-devel , owfs-ownet , owfs-fs , owfs-httpd , owfs-ftpd ,
owfs-server , owfs-tap , owfs-mon , owfs-python , owfs-php , owfs-tcl ,
owfs-shell
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated, BSD (4 clause), *No
copyright* GPL, *No copyright* Public domain, MIT/X11 (BSD like) GPL
(v2 or later), BSD (3 clause), LGPL (v2.1 or later), *No copyright*
GPL (v2 or later), GPL (v2), *No copyright* LGPL (v2.1 or later).
336 files have unknown license. Detailed output of licensecheck in
/home/lorenzodalrio/workspace/reviews/owfs/927237-owfs/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 92160 bytes in 7 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added Flags||fedora-cvs? --- Comment #26 from Tomasz Torcz zdzi...@irc.pl --- Great! Thank you for your patience, Lorenzo. New Package SCM Request === Package Name: owfs Short Description: 1-Wire Virtual File System suite Owners: ttorcz Branches: f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EevAYm7brya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UXTjxtnieSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #27 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=C4u2wiKeqea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EQy29w42nJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- owfs-2.9p1-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/owfs-2.9p1-4.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W0oZatCU5Oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- owfs-2.9p1-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/owfs-2.9p1-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tdGG9KNMC9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237
--- Comment #20 from Lorenzo Dalrio lorenzo.dal...@gmail.com ---
Tomasz,
i'm sorry to bother, but my build attempt fails with error
RPM build errors:
error: File must begin with /: %{_unitdir}/owfs.service
error: File must begin with /: %{_tmpfilesdir}/owfs.conf
File must begin with /: %{_unitdir}/owfs.service
File must begin with /: %{_tmpfilesdir}/owfs.conf
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=5FXpbTWmnGa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added Attachment #767410|0 |1 is obsolete|| --- Comment #19 from Tomasz Torcz zdzi...@irc.pl --- Created attachment 768204 -- https://bugzilla.redhat.com/attachment.cgi?id=768204action=edit changes in owfs.spec Hi, Spec: http://ttorcz.fedorapeople.org/owfs.spec SRPM: http://ttorcz.fedorapeople.org/owfs-2.9p1-3.fc18.src.rpm Changes: - include main copying in -tap and -mon - upstream contacted about issues: http://article.gmane.org/gmane.comp.file-systems.owfs.devel/10623 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4WUeP4Ndhka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #18 from Lorenzo Dalrio lorenzo.dal...@gmail.com --- (In reply to Tomasz Torcz from comment #17) But the problem is: there is not file to duplicate. Information about licensing is here: http://owfs.org/index.php?page=license -shell is MIT licensed, but there is no file with MIT license nowhere in distribution tarball. For -tap and -mon I suppose GPL license is inherited and I can duplicate COPYING file. Ok Tomasz, we can duplicate license text where applicable, for -shell subpackage please inform upstream that MIT license requires distributing license text with source code, this way licensing guidelines will be satisfied [1] and we can proceed over. :) [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3maMcnZA7Ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added Attachment #763488|0 |1 is obsolete|| --- Comment #15 from Tomasz Torcz zdzi...@irc.pl --- Created attachment 767410 -- https://bugzilla.redhat.com/attachment.cgi?id=767410action=edit changes in owfs.spec Spec URL: http://ttorcz.fedorapeople.org/owfs.spec SRPM URL: http://ttorcz.fedorapeople.org/owfs-2.9p1-2.fc18.src.rpm 1) fixed 2) license file is a bit problematic. Most subpackages depend on -libs, and -libs carry COPYING, so this is fine. -fs, -http and -ftpd depend on -server, -server depends on -libs, so fine again. We are left with -tap, -mon and -shell. Neither of those carry separate License file (licensing details are described on a webpage, URL is in spec). I don't believe we should invent license files, I can contact upstream to resolve this issue. This shouldn't block the review, IMO. 3) contacted upstream before: http://owfs-developers.1086194.n5.nabble.com/PATCH-1-2-update-FSF-address-td9457.html 4) fixed -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OnhP7GNdnga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #16 from Lorenzo Dalrio lorenzo.dal...@gmail.com --- (In reply to Tomasz Torcz from comment #15) 2) license file is a bit problematic. Most subpackages depend on -libs, and -libs carry COPYING, so this is fine. -fs, -http and -ftpd depend on -server, -server depends on -libs, so fine again. We are left with -tap, -mon and -shell. Neither of those carry separate License file (licensing details are described on a webpage, URL is in spec). I don't believe we should invent license files, I can contact upstream to resolve this issue. This shouldn't block the review, IMO. Unfortunately this one is blocking because we do not honor licensing guidelines. [1] However in this case we are permitted to duplicate license file for -tap -mon and -shell subpackages [2] [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Subpackage_Licensing [2] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Duplicate_Files -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vQ5kHmvuhYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #17 from Tomasz Torcz zdzi...@irc.pl --- But the problem is: there is not file to duplicate. Information about licensing is here: http://owfs.org/index.php?page=license -shell is MIT licensed, but there is no file with MIT license nowhere in distribution tarball. For -tap and -mon I suppose GPL license is inherited and I can duplicate COPYING file. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t6cLuSXqEea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #14 from Lorenzo Dalrio lorenzo.dal...@gmail.com --- We have a couple of issues left: 1) rpmlint reports some unused direct shlib dependencies, please try to fix this if it is possible [1]: owfs-capi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libowcapi-2.9.so.0.0.0 /lib64/libusb-0.1.so.4 owfs-capi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libowcapi-2.9.so.0.0.0 /lib64/libm.so.6 owfs-capi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libowcapi-2.9.so.0.0.0 /lib64/libdl.so.2 owfs-ownet.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libownet-2.9.so.0.0.0 /lib64/libm.so.6 2) we need to ship license file with every combination of subpackages installation. Subpackages that depend on a package that already installs license file are ok, standalone subpackages should install license file. [2] [3] 3) license file contains an incorrect fsf address [4], please ask upstream to update license file by picking a new copy from FSF. 4) Please fix permissions for this file, change it to 0755: owfs-python.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/ow/_OW.so 0775L [1] http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency [2] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing [3] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Duplicate_Files [4] http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nDo3jEgkQKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237
--- Comment #12 from Lorenzo Dalrio lorenzo.dal...@gmail.com ---
Hi Tomasz,
my build attempt failed with error:
error: Missing '(' in %attr {0755,-,-,-)
/usr/lib64/python2.7/site-packages/ow/_OW.so
Please can you fix this? :)
Thank you
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=LbVQLk0eCHa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #13 from Tomasz Torcz zdzi...@irc.pl --- What a dumb mistake of mine! Corrected. It is so trivial that I've remade SRPM without bumping release. Please redownload from ttorcz.fedorapeople.org -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gkbDARRiAta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added Attachment #760665|0 |1 is obsolete|| --- Comment #11 from Tomasz Torcz zdzi...@irc.pl --- Created attachment 763488 -- https://bugzilla.redhat.com/attachment.cgi?id=763488action=edit changes in owfs.spec SPEC: http://ttorcz.fedorapeople.org/owfs.spec SRPM: http://ttorcz.fedorapeople.org/owfs-2.9p1-1.fc18.src.rpm Upstream released new version in the meantime. I've updated spec. New version contains patches I was adding in .spec. Additionaly, I've corrected python module permissions and removed commented-out bits of perl module. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s0RciPu2pva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added Attachment #746373|0 |1 is obsolete|| Attachment #746375|0 |1 is obsolete|| --- Comment #10 from Tomasz Torcz zdzi...@irc.pl --- Created attachment 760665 -- https://bugzilla.redhat.com/attachment.cgi?id=760665action=edit changes in owfs.spec Spec: http://ttorcz.fedorapeople.org/owfs.spec SRPM: http://ttorcz.fedorapeople.org/owfs-2.9p0-4.fc18.src.rpm - corrected python requires - shell utilities do not link with libs, the use owserver for accessing 1wire; they can be used standalone - for accessing server on other machine - thus they do not depend on neither -libs nor -owserver - -mon and -tap do not link to -libs, also; but after closer looking, those two are TCL programs requiring owfs-tcl - I've added -tcl dependency to them Thanks for your patience, Lorenzo1 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xTgeNNLy6Ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #9 from Lorenzo Dalrio lorenzo.dal...@gmail.com --- Tomasz, the python sub-package need to BuildRequires: python2-devel and not Requires: python-devel [1]. This is my fault, i led you to mistake, sorry. shell, mon and tap sub-packages do not have a dependency on libs sub-package. If i have correctly understand, owfs-libs in this case is our base package and has to be required by sub-packages. [2] [1] http://fedoraproject.org/wiki/Packaging:Python#BuildRequires [2] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Requiring_Base_Package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=w8uPF3tOdla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #8 from Tomasz Torcz zdzi...@irc.pl --- Oh yeah, I've forgot that. Spec URL: http://ttorcz.fedorapeople.org/owfs.spec SRPM URL: http://ttorcz.fedorapeople.org/owfs-2.9p0-3.fc18.src.rpm Scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=5383887 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yyi2F2n4Pxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #7 from Lorenzo Dalrio lorenzo.dal...@gmail.com --- Tomasz, please can you also refresh srpm? Thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ULwNg4a6dGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927237 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added Attachment #744244|0 |1 is obsolete|| --- Comment #5 from Tomasz Torcz zdzi...@irc.pl --- Created attachment 746373 -- https://bugzilla.redhat.com/attachment.cgi?id=746373action=edit owfs.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dcOHsAsmqya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927237 Tomasz Torcz zdzi...@irc.pl changed: What|Removed |Added Attachment #744245|0 |1 is obsolete|| --- Comment #6 from Tomasz Torcz zdzi...@irc.pl --- Created attachment 746375 -- https://bugzilla.redhat.com/attachment.cgi?id=746375action=edit changes in owfs.spec Replaced /mnt/1wire with /run/owfs -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CbKb2zijmVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927237 Andrew Elwell andrew.elw...@gmail.com changed: What|Removed |Added CC||andrew.elw...@gmail.com --- Comment #4 from Andrew Elwell andrew.elw...@gmail.com --- Hi Tomasz, Saw your comments on the mailing list - use of /run/1wire would probably be the simplest as it's closest to what people expect (/mnt is a FHS no-go IMHO). Any more changes planned as I'm just trying to work out some json patches for owhttpd (doesn't provide valid json output) and I can build with your spec Andrew -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ohbf7tJFZoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #2 from Tomasz Torcz zdzi...@irc.pl --- Created attachment 744244 -- https://bugzilla.redhat.com/attachment.cgi?id=744244action=edit owfs.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YT5Fnhthb8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #3 from Tomasz Torcz zdzi...@irc.pl --- Created attachment 744245 -- https://bugzilla.redhat.com/attachment.cgi?id=744245action=edit changes in owfs.spec Lorenzo, I made first change you suggested to owfs.spec file. The /mnt/1wire directory is harder. This dir is widely used in the real world, and in order to have just-working configuration it should be available. But I see that FHS make it prohibited territory for packages. I think I will take this issue to fedora-devel for hints. Thanks for looking into this review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ooyq1PMqwVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927237 --- Comment #1 from Lorenzo Dalrio lorenzo.dal...@gmail.com --- Hi Tomasz, this one is quite tough to review, i am working on it and time is never enough, please be patient. :) Some initial considerations: - you have to Require: python-devel in python subpackage [1] - fs subpackage installs a dir in /mnt, this is not permitted because of FHS. [1] http://fedoraproject.org/wiki/Packaging:Python#BuildRequires -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6rFe8kEWRva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927237] Review Request: owfs - 1-Wire Virtual File System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927237 Lorenzo Dalrio lorenzo.dal...@gmail.com changed: What|Removed |Added CC||lorenzo.dal...@gmail.com Assignee|nob...@fedoraproject.org|lorenzo.dal...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eLAi4pCmGAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
