[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Alias||rospack -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X7KsmqZttAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458 --- Comment #8 from Mario Blättermann mario.blaetterm...@gmail.com --- What about the packages? Nothing has been built yet. Any problems...? However, I don't need rospack for me, but it would be nice if we could close this review request soon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xlKzKagoaCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added CC||sanjay.an...@gmail.com --- Comment #5 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Rich, please do the SCM stuff so this can be pushed to testing. (Looks like there are other packages that depend on this one) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QToGsRxhTRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Rich Mattes richmat...@gmail.com --- Thanks for the review! New Package SCM Request === Package Name: rospack Short Description: ROS package and stack tools Owners: rmattes Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XZBi894bPOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uxEcrFXyPfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sWa6LYv0Ewa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5646812
$ rpmlint -i -v *
rospack.src: I: checking
rospack.src: I: checking-url http://www.ros.org/wiki/rospack (timeout 10
seconds)
rospack.src: I: checking-url
https://github.com/ros/rospack/archive/671c3cb620147308df42a025cab082669efc96ff/rospack-2.0.13-671c3cb.tar.gz
(timeout 10 seconds)
rospack.i686: I: checking
rospack.i686: I: checking-url http://www.ros.org/wiki/rospack (timeout 10
seconds)
rospack.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
rospack.i686: W: no-manual-page-for-binary rosstack
Each executable in standard binary directories should have a man page.
rospack.i686: W: no-manual-page-for-binary rospack
Each executable in standard binary directories should have a man page.
rospack.x86_64: I: checking
rospack.x86_64: I: checking-url http://www.ros.org/wiki/rospack (timeout 10
seconds)
rospack.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
rospack.x86_64: W: no-manual-page-for-binary rosstack
Each executable in standard binary directories should have a man page.
rospack.x86_64: W: no-manual-page-for-binary rospack
Each executable in standard binary directories should have a man page.
rospack-debuginfo.i686: I: checking
rospack-debuginfo.i686: I: checking-url http://www.ros.org/wiki/rospack
(timeout 10 seconds)
rospack-debuginfo.x86_64: I: checking
rospack-debuginfo.x86_64: I: checking-url http://www.ros.org/wiki/rospack
(timeout 10 seconds)
rospack-devel.i686: I: checking
rospack-devel.i686: I: checking-url http://www.ros.org/wiki/rospack (timeout 10
seconds)
rospack-devel.x86_64: I: checking
rospack-devel.x86_64: I: checking-url http://www.ros.org/wiki/rospack (timeout
10 seconds)
rospack.spec: I: checking-url
https://github.com/ros/rospack/archive/671c3cb620147308df42a025cab082669efc96ff/rospack-2.0.13-671c3cb.tar.gz
(timeout 10 seconds)
7 packages and 1 specfiles checked; 0 errors, 6 warnings.
Nothing worth to be addressed.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
BSD
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
93339bec42ef08bfd01fcbf9e1293eae11f8350c859e38e96e03ee4ae786264b
rospack-2.0.13-671c3cb.tar.gz
93339bec42ef08bfd01fcbf9e1293eae11f8350c859e38e96e03ee4ae786264b
rospack-2.0.13-671c3cb.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM
[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458 --- Comment #3 from Rich Mattes richmat...@gmail.com --- Thanks Mario. The library is a public library, so I went ahead and set the library's soversion to 0 for now. The ROS libraries tend to not set sonames for their libraries, but if/when they do what they set should be greater than 0. The new spec and srpm are here: Spec URL: http://rmattes.fedorapeople.org/rospackages/rospack/rospack.spec SRPM URL: http://rmattes.fedorapeople.org/rospackages/rospack/rospack-2.0.13-4.20130605git671c3cb.fc19.src.rpm $ rpmlint rospack.spec ../../RPMS/x86_64/rospack*2.0.13-4* rospack.x86_64: W: no-documentation rospack.x86_64: W: no-manual-page-for-binary rosstack rospack.x86_64: W: no-manual-page-for-binary rospack 3 packages and 1 specfiles checked; 0 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hRcxRTI49Ia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5579716 $ rpmlint -i -v * rospack.src: I: checking rospack.src: I: checking-url http://www.ros.org/wiki/rospack (timeout 10 seconds) rospack.src: I: checking-url https://github.com/ros/rospack/archive/671c3cb620147308df42a025cab082669efc96ff/rospack-2.0.13-671c3cb.tar.gz (timeout 10 seconds) rospack.i686: I: checking rospack.i686: I: checking-url http://www.ros.org/wiki/rospack (timeout 10 seconds) rospack.i686: E: invalid-soname /usr/lib/librospack.so librospack.so The soname of the library is neither of the form liblibname.so.major or liblibname-major.so. rospack.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. rospack.i686: W: no-manual-page-for-binary rosstack Each executable in standard binary directories should have a man page. rospack.i686: W: no-manual-page-for-binary rospack Each executable in standard binary directories should have a man page. rospack.x86_64: I: checking rospack.x86_64: I: checking-url http://www.ros.org/wiki/rospack (timeout 10 seconds) rospack.x86_64: E: invalid-soname /usr/lib64/librospack.so librospack.so The soname of the library is neither of the form liblibname.so.major or liblibname-major.so. rospack.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. rospack.x86_64: W: no-manual-page-for-binary rosstack Each executable in standard binary directories should have a man page. rospack.x86_64: W: no-manual-page-for-binary rospack Each executable in standard binary directories should have a man page. rospack-debuginfo.i686: I: checking rospack-debuginfo.i686: I: checking-url http://www.ros.org/wiki/rospack (timeout 10 seconds) rospack-debuginfo.x86_64: I: checking rospack-debuginfo.x86_64: I: checking-url http://www.ros.org/wiki/rospack (timeout 10 seconds) rospack-devel.i686: I: checking rospack-devel.i686: I: checking-url http://www.ros.org/wiki/rospack (timeout 10 seconds) rospack-devel.x86_64: I: checking rospack-devel.x86_64: I: checking-url http://www.ros.org/wiki/rospack (timeout 10 seconds) rospack.spec: I: checking-url https://github.com/ros/rospack/archive/671c3cb620147308df42a025cab082669efc96ff/rospack-2.0.13-671c3cb.tar.gz (timeout 10 seconds) 7 packages and 1 specfiles checked; 2 errors, 6 warnings. No man pages, no problem. But this has to be addressed: rospack.x86_64: E: invalid-soname /usr/lib64/librospack.so librospack.so The soname of the library is neither of the form liblibname.so.major or liblibname-major.so. If this is no public library, you have to filter it from the Provides list. See also https://fedoraproject.org/wiki/Common_Rpmlint_issues#invalid-soname. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R1zI1wLtcRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
https://bugzilla.redhat.com/show_bug.cgi?id=927458 --- Comment #1 from Rich Mattes richmat...@gmail.com --- Update: Spec URL: http://rmattes.fedorapeople.org/rospackages/rospack/rospack.spec SRPM URL: http://rmattes.fedorapeople.org/rospackages/rospack/rospack-2.0.13-3.20130605git671c3cb.fc19.src.rpm rpmlint is clean: $ rpmlint rospack.spec ../../RPMS/x86_64/rospack-*-3* rospack.x86_64: E: invalid-soname /usr/lib64/librospack.so librospack.so rospack.x86_64: W: no-documentation rospack.x86_64: W: no-manual-page-for-binary rosstack rospack.x86_64: W: no-manual-page-for-binary rospack 3 packages and 1 specfiles checked; 1 errors, 3 warnings. This version of rospack depends on catkin-0.4.5-7, which contains a fix to the pkg-config generation scripts. I'm submitting the new catkin builds today, so mock and koji builds will fail until catkin gets out of updates-testing. Otherwise, I think this package is ready for review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bzAfdF02gma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927458 Bug 927458 depends on bug 871197, which changed state. Bug 871197 Summary: Review Request: catkin - Collection of CMake macros for ROS https://bugzilla.redhat.com/show_bug.cgi?id=871197 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jfOYh2pTJUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927458 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Depends On||871197 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=C1lKX4yMC7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927458] Review Request: rospack - ROS package and stack tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927458 Rich Mattes richmat...@gmail.com changed: What|Removed |Added Blocks||927461 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LU71QROQyxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
