[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462

Rich Mattes  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-02-07 19:46:29



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462

Jonathan Wakely jwak...@redhat.com changed:

   What|Removed |Added

 CC||jwak...@redhat.com



--- Comment #11 from Jonathan Wakely jwak...@redhat.com ---
Would it make sense for the %description to explain what ROS stands for, or is
everyone looking at Fedora packages assumed to know that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462



--- Comment #10 from Christopher Meng i...@cicku.me ---
Is the patch merged upstream?

And, I'd like to know when will Fedora users get the latest ROS? I checked the
release page on github, it seems that 0.2.6 is pretty old.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462

Rich Mattes richmat...@gmail.com changed:

   What|Removed |Added

  Flags|needinfo?(richmattes@gmail. |
   |com)|



--- Comment #9 from Rich Mattes richmat...@gmail.com ---
Not for ros-fuerte.  0.2.6 is the latest.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 CC||richmat...@gmail.com
  Flags||needinfo?(richmattes@gmail.
   ||com)



--- Comment #8 from Christopher Meng i...@cicku.me ---
Is there any new snapshot or version after a year before my review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

   Assignee|sanjay.an...@gmail.com  |i...@cicku.me
  Flags|fedora-review?  |



--- Comment #7 from Christopher Meng i...@cicku.me ---
(In reply to Rich Mattes from comment #6)
 Ankur, are you still able to do this review?

I will take this, I spoke with Ankur on FUDCon and he agreed to change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462



--- Comment #6 from Rich Mattes richmat...@gmail.com ---
Ankur, are you still able to do this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||cicku...@gmail.com



--- Comment #5 from Christopher Meng cicku...@gmail.com ---
ping *2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Blocks||928584 (ros-std_msgs)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928584
[Bug 928584] Review Request: ros-std_msgs - Standard ROS Messages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462



--- Comment #4 from Christopher Meng cicku...@gmail.com ---
ping Ankur.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462

Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sanjay.an...@gmail.com
   Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com
  Alias||roscpp_core
  Flags||fedora-review?

--- Comment #2 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com ---
[+] OK
[-] NA
[?] Issue

** Mandatory review guidelines: **
 [?] rpmlint output:
[asinha@localhost  SRPMS]$ rpmlint ../SPECS/roscpp_core.spec
./roscpp_core-0.2.6-1.20130605gitd0b5ce1.fc19.src.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
roscpp_core.src: W: spelling-error %description -l en_US roscpp - Roscoe
roscpp_core.src: W: spelling-error %description -l en_US roscpp - Roscoe
roscpp_core.x86_64: W: spelling-error %description -l en_US roscpp - Roscoe
roscpp_core.x86_64: E: invalid-soname /usr/lib64/libroscpp_serialization.so
libroscpp_serialization.so
roscpp_core.x86_64: E: invalid-soname /usr/lib64/libcpp_common.so
libcpp_common.so
roscpp_core.x86_64: E: invalid-soname /usr/lib64/librostime.so librostime.so
roscpp_core.x86_64: W: no-documentation
roscpp_core-debuginfo.x86_64: W: spelling-error Summary(en_US) roscpp - Roscoe
roscpp_core-debuginfo.x86_64: W: spelling-error %description -l en_US roscpp -
Roscoe
roscpp_core-devel.x86_64: W: spelling-error Summary(en_US) roscpp - Roscoe
roscpp_core-devel.x86_64: W: spelling-error %description -l en_US roscpp -
Roscoe
5 packages and 1 specfiles checked; 3 errors, 8 warnings.
[asinha@localhost  SRPMS]$

^^ The invalid soname errors need to be corrected. Generally, the versioned
soname should be present in the package, and the unversioned soname in the
devel package as a symlink of the versioned soname. At the present time, the
devel package here doesn't even have a shared object in it to link against.


 [+] License is acceptable (...)
 [+] License field in spec is correct
 [+] License files included in package %docs if included in source package
 [+] License files installed when any subpackage combination is installed
 [+] Spec written in American English
 [+] Spec is legible
 [+] Sources match upstream unless altered to fix permissibility issues
[asinha@localhost  SPECS]$ review-md5check.sh roscpp_core.spec
mkdir: cannot create directory ‘/tmp/review’: File exists
Getting
https://github.com/ros/roscpp_core/archive/d0b5ce1d8f42050a5674875b866a7dda6383a75b/roscpp_core-0.2.6-d0b5ce1.tar.gz
to /tmp/review/roscpp_core-0.2.6-d0b5ce1.tar.gz % Total% Received % Xferd 
Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100   157  100   1570 0119  0  0:00:01  0:00:01 --:--:--   119
  0 00 468450 0  14953  0 --:--:--  0:00:03 --:--:-- 4
58af78843ead517ef8be46df06f90c0b  /tmp/review/roscpp_core-0.2.6-d0b5ce1.tar.gz
58af78843ead517ef8be46df06f90c0b
/home/asinha/rpmbuild/SOURCES/roscpp_core-0.2.6-d0b5ce1.tar.gz
removed ‘/tmp/review/roscpp_core-0.2.6-d0b5ce1.tar.gz’
removed directory: ‘/tmp/review’
[asinha@localhost  SPECS]$
 [+] Build succeeds on at least one primary arch
 [+] Build succeeds on all primary arches or has ExcludeArch + bugs filed
 [+] BuildRequires correct, justified where necessary
 [-] Locales handled with %find_lang, not %_datadir/locale/*
 [?] %post, %postun call ldconfig if package contains shared .so files
^ 
Please use the correct scriptlets

 [+] No bundled libs
 [-] Relocatability is justified
 [+] Package owns all directories it creates
 [-] Package requires others for directories it uses but does not own
 [+] No duplication in %files unless necessary for license files
 [+] File permissions are sane
 [+] Package contains permissible code or content
 [-] Large docs go in -doc subpackage
 [+] %doc files not required at runtime
 [-] Static libs go in -static package/virtual Provides
 [+] Development files go in -devel package
 [+] -devel packages Require base with fully-versioned dependency, %_isa
 [+] No .la files
 [-] GUI app uses .desktop file, installs it with desktop-file-install
 [-] File list does not conflict with other packages' without justification
 [+] File names are valid UTF-8

** Optional review guidelines: **
 [-] Query upstream about including license files
 [-] Translations of description, summary
 [+] Builds in mock
 [+] Builds on all arches
 [-] Functions as described (e.g. no crashes)
 [?] Scriptlets are sane
^
Missing ldconfig scriptlets

 [+] Subpackages require base with fully-versioned dependency if sensible
 [+] .pc file subpackage placement is sensible
 [+] No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin
 [-] Include man pages if available

Naming 

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462

--- Comment #3 from Rich Mattes richmat...@gmail.com ---
Update:

Spec URL:
http://rmattes.fedorapeople.org/rospackages/roscpp-core/roscpp_core.spec
SRPM URL:
http://rmattes.fedorapeople.org/rospackages/roscpp-core/roscpp_core-0.2.6-2.20130605gitd0b5ce1.fc19.src.rpm

$ rpmlint roscpp_core.spec ../../RPMS/x86_64/roscpp_core*
roscpp_core.x86_64: W: spelling-error %description -l en_US roscpp - Roscoe
roscpp_core.x86_64: W: no-documentation
roscpp_core-debuginfo.x86_64: W: spelling-error Summary(en_US) roscpp - Roscoe
roscpp_core-debuginfo.x86_64: W: spelling-error %description -l en_US roscpp -
Roscoe
roscpp_core-devel.x86_64: W: spelling-error Summary(en_US) roscpp - Roscoe
roscpp_core-devel.x86_64: W: spelling-error %description -l en_US roscpp -
Roscoe


The docs are pretty small, I don't think it's worth it to separate them into a
separate subpackage.

roslib-devel from the ros and roscpp-devel from the ros_comm package also
put headers in this folder, so I'll make sure that roslib-devel and
roscpp-devel depend on roscpp-core_devel, and I'll make sure this package owns
includedir/ros.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=4zGnTjdsB9a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=927462

--- Comment #1 from Rich Mattes richmat...@gmail.com ---
Update:
Spec URL:
http://rmattes.fedorapeople.org/rospackages/roscpp-core/roscpp_core.spec
SRPM URL:
http://rmattes.fedorapeople.org/rospackages/roscpp-core/roscpp_core-0.2.6-1.20130605gitd0b5ce1.fc19.src.rpm

$ rpmlint roscpp_core.spec ../../RPMS/x86_64/roscpp_core-*0.2.6*
roscpp_core.x86_64: W: spelling-error %description -l en_US roscpp - Roscoe
roscpp_core.x86_64: E: invalid-soname /usr/lib64/libroscpp_serialization.so
libroscpp_serialization.so
roscpp_core.x86_64: E: invalid-soname /usr/lib64/libcpp_common.so
libcpp_common.so
roscpp_core.x86_64: E: invalid-soname /usr/lib64/librostime.so librostime.so
roscpp_core.x86_64: W: no-documentation
roscpp_core-debuginfo.x86_64: W: spelling-error Summary(en_US) roscpp - Roscoe
roscpp_core-debuginfo.x86_64: W: spelling-error %description -l en_US roscpp -
Roscoe
roscpp_core-devel.x86_64: W: spelling-error Summary(en_US) roscpp - Roscoe
roscpp_core-devel.x86_64: W: spelling-error %description -l en_US roscpp -
Roscoe
3 packages and 1 specfiles checked; 3 errors, 6 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=CFIBkd2LNLa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927462

Bug 927462 depends on bug 871197, which changed state.

Bug 871197 Summary: Review Request: catkin - Collection of CMake macros for ROS
https://bugzilla.redhat.com/show_bug.cgi?id=871197

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LhHI4nE1Ura=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927462] Review Request: roscpp_core - The ROS C++ API

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927462

Rich Mattes richmat...@gmail.com changed:

   What|Removed |Added

 Depends On||871197

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DqmO1UjmhTa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review