[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- remake-0.4-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tymv5h9Ouqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- remake-0.4-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jEP0ox3Wcva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-26 23:06:04 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uSYM4OaDjRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TdoTcaxEena=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vfcr3LTAW7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VgxXFN6fjxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- remake-0.4-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/remake-0.4-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Xo1QlaDm3Ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- remake-0.4-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/remake-0.4-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xu8uafIA6qa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- remake-0.4-3.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ofp0Hg6IOYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aaD1ivP1a6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- I do not see any remaining issues. The package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jQzcITLRUva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 Jerry James loganje...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Jerry James loganje...@gmail.com --- New Package SCM Request === Package Name: remake Short Description: Build system that bridges the gap between make and redo Owners: jjames Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P8TdywYmsLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927477
--- Comment #4 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com ---
(In reply to comment #3)
(In reply to comment #2)
Any reason to not buildrequires doxygen and generate doc,
maybe a better option than making README.md %doc?
I thought the documentation appeared more useful to a remake developer than
to an end user, but there is no harm in including it. I will make that
I understand. The main page is actually small and gives a good
looking formatted output of the same contents of README.md, but
the full doxygen comes with a lot of extra stuff only useful
for remake developers.
change.
You should install README.md in the main package, and the
doxygen output in a -doc subpackage. I suggest something like:
cp -a doxydoc/html %{buildroot}%{_docdir}/%{name}-%{version}
in %install to avoid yet another %_docdir directory.
Otherwise, now there is 88K binary and 2.1M doc in the main
package.
If you prefer changing back to not generating any doxygen
documentation I am fine with it. I leave it for you to choose.
Is there any prevision of an official release? I see only
\section sec-licensing Licensing in remake.cpp with version
information. Is this correct?
Yes, and you can also see them by navigating to the project home page and
pressing the Tags button, or looking directly at this URL:
https://github.com/silene/remake/tags
Ok. Good enough :-)
Spec URL: http://jjames.fedorapeople.org/remake/remake.spec
SRPM URL: http://jjames.fedorapeople.org/remake/remake-0.4-2.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=P5Vx56Fg1Ia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 --- Comment #5 from Jerry James loganje...@gmail.com --- Now that I've had a closer look at that tags page, I realize I can get tarballs from there, instead of needing to know a git commit hash. I've made that change, and split the documentation out into a separate package. New URLs: Spec URL: http://jjames.fedorapeople.org/remake/remake.spec SRPM URL: http://jjames.fedorapeople.org/remake/remake-0.4-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aRV3oXIrqRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Jerry James loganje...@gmail.com --- (In reply to comment #2) Any reason to not buildrequires doxygen and generate doc, maybe a better option than making README.md %doc? I thought the documentation appeared more useful to a remake developer than to an end user, but there is no harm in including it. I will make that change. Is there any prevision of an official release? I see only \section sec-licensing Licensing in remake.cpp with version information. Is this correct? Yes, and you can also see them by navigating to the project home page and pressing the Tags button, or looking directly at this URL: https://github.com/silene/remake/tags Spec URL: http://jjames.fedorapeople.org/remake/remake.spec SRPM URL: http://jjames.fedorapeople.org/remake/remake-0.4-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WxjBLMAqgBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927477
Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed:
What|Removed |Added
CC||paulo.cesar.pereira.de.andr
||a...@gmail.com
Assignee|nob...@fedoraproject.org|paulo.cesar.pereira.de.andr
||a...@gmail.com
Flags||fedora-review?
--- Comment #2 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com ---
Any reason to not buildrequires doxygen and generate doc,
maybe a better option than making README.md %doc?
By just running doxygen in the topdir, ignoring the latex subdir:
$ find BUILD/remake-f38cbaa074e87bd2d278624c53dcd3148b4f5b03/doxydoc/html/ | wc
-l
242
$ du -sh BUILD/remake-f38cbaa074e87bd2d278624c53dcd3148b4f5b03/doxydoc/html/
2.1MBUILD/remake-f38cbaa074e87bd2d278624c53dcd3148b4f5b03/doxydoc/html/
and loading
file:///home/pcpa/rpmbuild/BUILD/remake-f38cbaa074e87bd2d278624c53dcd3148b4f5b03/doxydoc/html/index.html
in firefox, it looks like to be desirable to have a -doc subpackage.
Is there any prevision of an official release? I see only
\section sec-licensing Licensing in remake.cpp with version
information. Is this correct?
--- Full fedora-review text follows ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in /home/pcpa/927477-remake/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported
[Bug 927477] Review Request: remake - Build system that bridges the gap between make and redo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927477 --- Comment #1 from Jerry James loganje...@gmail.com --- Updated to version 0.4. New URLs: Spec URL: http://jjames.fedorapeople.org/remake/remake.spec SRPM URL: http://jjames.fedorapeople.org/remake/remake-0.4-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2aDpkOHJXRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
