[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=946968

Jon Ciesla  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(limburgher@gmail. |
   |com)|
Last Closed|2013-04-10 23:53:25 |2016-06-03 12:42:42



--- Comment #25 from Jon Ciesla  ---
See new process:

https://fedoraproject.org/wiki/PackageDB_admin_requests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=946968

Ngo Than  changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 CC||limburg...@gmail.com,
   ||t...@redhat.com
 Resolution|NEXTRELEASE |---
  Flags||needinfo?(limburgher@gmail.
   ||com)
   Keywords||Reopened



--- Comment #24 from Ngo Than  ---
we need this packagw in epel7

New Package SCM Request
===
Package Name: pcmanfm-qt
Short Description: Qt port of the LXDE file manager PCManFM
Branches: epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #23 from Jon Ciesla limburg...@gmail.com ---
Unsetting flag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=pbdVEz4E2aa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=NuNQjSRlRua=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #19 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #17)
 So as I see that fedora-review flag was set to + by the reviewer, I will
 arrange the left properly...

Don't forget that pcmanfm-qt is still too buggy (working with gvfs).
And has no feedback (issue/bug tracker).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=iCh0n0wMHya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #20 from Mamoru TASAKA mtas...@fedoraproject.org ---
Yes, pcmanfm-qt is still under development and I will keep an eye on the
upstream development.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ZbAqTBbSoHa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |
  Flags||fedora-cvs+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=G05ssTG8xka=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #21 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=jAkHOgBlAga=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Mamoru TASAKA mtas...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
  Flags|fedora-cvs+ |
  Flags||fedora-cvs?
Last Closed||2013-04-10 23:53:25

--- Comment #22 from Mamoru TASAKA mtas...@fedoraproject.org ---
Successfully built, push requested on bodhi for F-19/18/17.

Closing. Thank you for review and git procedure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ozEgJMr0Kra=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #14 from Kevin Kofler ke...@tigcc.ticalc.org ---
I have to disagree, passing -D flags to CMake is much cleaner than
postprocessing CMake output (yuck!).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=3Q5ycfpk2za=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #15 from Mamoru TASAKA mtas...@fedoraproject.org ---
(In reply to comment #14)
 I have to disagree, passing -D flags to CMake is much cleaner than
 postprocessing CMake output (yuck!).

I want to change -O3 to -O2 only, not anything else on
CMAKE_CXX_FLAGS_RELEASE. Specifying CMAKE_CXX_FLAGS_RELEASE as a whole means
that we may blindly change other flags than -O3 in CMAKE_CXX_FLAGS_RELEASE,
which is not desirable.
Anyway I think this is left to package, just making -O3 unused is enough and
which way to use is not a blocker.

Eugene, if this is okay, would you change this bug appropriately?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=aCDvlUy5eHa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #16 from Mamoru TASAKA mtas...@fedoraproject.org ---
Kevin, if you have some way like -DCMAKE_CXX_FLAGS_RELEASE:STRING=default
value | sed -e 's|-O3||', I may consider to use it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=R1ASkDSQRqa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Mamoru TASAKA mtas...@fedoraproject.org changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |
 CC||package-review@lists.fedora
   ||project.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=GXHQeSWoBFa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Mamoru TASAKA mtas...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ti.eug...@gmail.com

--- Comment #17 from Mamoru TASAKA mtas...@fedoraproject.org ---
So as I see that fedora-review flag was set to + by the reviewer, I will
arrange the left properly...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bR6BNPZxc5a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Mamoru TASAKA mtas...@fedoraproject.org changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #18 from Mamoru TASAKA mtas...@fedoraproject.org ---
As this package was approved by comment 8 and fedora-review flag:

New Package SCM Request
===
Package Name: pcmanfm-qt
Short Description: Qt port of the LXDE file manager PCManFM
Owners: mtasaka
Branches: f17 f18 f19
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=wo1vWiPEwKa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #9 from Mamoru TASAKA mtas...@fedoraproject.org ---
Okay, thank you.
I will upload new srpm anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HaH7xuCJyHa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #10 from Mamoru TASAKA mtas...@fedoraproject.org ---
http://mtasaka.fedorapeople.org/Review_request/pcmanfm-qt/pcmanfm-qt.spec
http://mtasaka.fedorapeople.org/Review_request/pcmanfm-qt/pcmanfm-qt-0.1.0-3.fc.src.rpm

* Mon Apr  8 2013 Mamoru TASAKA mtas...@fedoraproject.org - 0.1.0-3
- Use -DCMAKE_BUILD_TYPE=Release option for cmake

non-break-space rpmlint issue also fixed.

By the way, would you
- change the status to ASSIGNED
- change the assignee to yourself
- and change fedora-review flag ?
Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=NaJdlfKx8Ka=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #11 from Kevin Kofler ke...@tigcc.ticalc.org ---
Have you checked that this doesn't end up adding -O3 to the build flags? And if
not, does it even have any effect at all? (By default, it defines NDEBUG, some
projects also add QT_NO_DEBUG.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=PSzaZWbylga=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #12 from Mamoru TASAKA mtas...@fedoraproject.org ---
(In reply to comment #11)
 Have you checked that this doesn't end up adding -O3 to the build flags? And
 if not, does it even have any effect at all? (By default, it defines NDEBUG,
 some projects also add QT_NO_DEBUG.)

See some dirty hack after %cmake macro (well, perhaps adding extra -Dfoo=bar to
%cmake would perhaps be enough, however for me this way is more explicit and
easy to understand)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=4EBzkAUTv8a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #13 from Mamoru TASAKA mtas...@fedoraproject.org ---
By the way -O3 issue seems to be already in discussion on bug 875954 .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=04WXKzaiSZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Eugene A. Pivnev ti.eug...@gmail.com changed:

   What|Removed |Added

 CC||ti.eug...@gmail.com

--- Comment #2 from Eugene A. Pivnev ti.eug...@gmail.com ---
1. Please - separate spec sections other then expressions inside them - e.g.
with double CR. It's too hard to read spec now.
2. maybe to add -DCMAKE_BUILD_TYPE=Release to %cmake will be better
(https://bugzilla.redhat.com/show_bug.cgi?id=919044#c22)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=0oCHcPjI9Ma=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #3 from Mamoru TASAKA mtas...@fedoraproject.org ---
(In reply to comment #2)
 1. Please - separate spec sections other then expressions inside them - e.g.
 with double CR. It's too hard to read spec now.

Well, even if I add one more new line between section, after
review passed I again cut such extra line...
(I agree that at least one line is needed between sections, but
 two lines are just redundant)

 2. maybe to add -DCMAKE_BUILD_TYPE=Release to %cmake will be better
 (https://bugzilla.redhat.com/show_bug.cgi?id=919044#c22)
May consider afterwards.

I will wait for full reviews to see what are real blockers, thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=wdLgRped2Na=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Eugene A. Pivnev ti.eug...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-review?

--- Comment #4 from Eugene A. Pivnev ti.eug...@gmail.com ---
Despite pcmanfm-qt is stil buggy now (working with remote FS like ssh/webdav) -
_formally_ it can be packaged.
I get it on review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=NQHhNLPXbYa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #5 from Kevin Kofler ke...@tigcc.ticalc.org ---
IMHO, the spacing between sections is fine as is, it's definitely not a review
criterion. I'd remove the blank lines INSIDE the %prep, %install and %files
sections though, then the blank lines between the sections become better
demarcators. IMHO, the sections are not so large that they need cutting into
chunks with blank lines. But again, the specfile is legible as is, so this is
mostly a matter of personal taste.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=CQRQzNS1Mca=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #6 from Eugene A. Pivnev ti.eug...@gmail.com ---
(In reply to comment #5)
 IMHO, the spacing between sections is fine as is, it's definitely not a
 review criterion. I'd remove the blank lines INSIDE the %prep, %install and
 %files sections though, then the blank lines between the sections become
 better demarcators. IMHO, the sections are not so large that they need
 cutting into chunks with blank lines. But again, the specfile is legible as
 is, so this is mostly a matter of personal taste.

I agree that spec format is not blocker for review.
But some kind of readability must be.
As for me - I separate sections with one CR and no one blank CR inside
sections.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=FNmEFzE7iWa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #7 from Eugene A. Pivnev ti.eug...@gmail.com ---
Package Review
==

= MUST items =
[+]: Package does not contain kernel modules.
[+]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[+]: Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[+]: %build honors applicable compiler flags or justifies otherwise.
[+]: Package contains no bundled libraries without FPC exception.
[+]: Changelog in prescribed format.
[+]: Sources contain only permissible code or content.
[+]: Development files must be in a -devel package
[+]: Package requires other packages for directories it uses.
[+]: Package uses nothing in %doc for runtime.
[+]: Package is not known to require ExcludeArch.
[+]: Fully versioned dependency in subpackages, if present.
[+]: Package complies to the Packaging Guidelines
[+]: License field in the package spec file matches the actual license.
[+]: License file installed when any subpackage combination is installed.
[+]: Package consistently uses macro is (instead of hard-coded directory
names).
[+]: Package is named according to the Package Naming Guidelines.
[+]: Package does not generate any conflict.
[+]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[+]: Package must own all directories that it creates.
[+]: Package does not own files or directories owned by other packages.
[+]: Requires correct, justified where necessary.
[+]: Spec file is legible and written in American English.
[+]: Package contains systemd file(s) if in need.
[+]: update-desktop-database is invoked when required
[+]: Useful -debuginfo package or justification otherwise.
[+]: Large documentation must go in a -doc subpackage.
[x]: All build dependencies are listed in BuildRequires, except for any that
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm  4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format 
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
= SHOULD items =
[+]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[+]: Final provides and requires are sane (see attachments).
[+]: Package functions as described.
[+]: Latest version is packaged.
[+]: Package does not include license text files separate from upstream.
[+]: Scriptlets must be sane, if used.
[+]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[+]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[+]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
= EXTRA items =
[x]: Large data in /usr/share should live in a noarch subpackage if package is

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Eugene A. Pivnev ti.eug...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #8 from Eugene A. Pivnev ti.eug...@gmail.com ---
Silence...

Ok - Approved.

But - tune spec before bodhi:
* resolve -DCMAKE_BUILD_TYPE=release question
* non-break-space line 72, char 39, non-break-space line 75, char 39

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TKq7Rgcijna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu
  Alias||pcmanfm-qt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kLcGaVbhWPa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

--- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org ---
http://mtasaka.fedorapeople.org/Review_request/pcmanfm-qt/pcmanfm-qt.spec
http://mtasaka.fedorapeople.org/Review_request/pcmanfm-qt/pcmanfm-qt-0.1.0-2.fc.src.rpm

* Mon Apr  1 2013 Mamoru TASAKA mtas...@fedoraproject.org - 0.1.0-2
- Call update-desktop-database
- Use make soversion specific in %%files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rnttxCgTFja=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968

Mamoru TASAKA mtas...@fedoraproject.org changed:

   What|Removed |Added

 Blocks||928937 (qt-reviews)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7X7WZToGIna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review