[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640



--- Comment #16 from Jon Ciesla limburg...@gmail.com ---
Requested package name snappy-player doesn't match bug summary snappy,
please correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640



--- Comment #13 from Antonio Trande anto.tra...@gmail.com ---
 Spec URL: http://sagitter.fedorapeople.org/snappy/snappy.spec

This link is wrong, sorry.

Spec URL: http://sagitter.fedorapeople.org/snappy/snappy-player.spec
SRPM URL:
http://sagitter.fedorapeople.org/snappy/snappy-player-0.3.7-1.20131121git0bd0c0c3.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640

Antonio Trande anto.tra...@gmail.com changed:

   What|Removed |Added

External Bug ID||GNOME Desktop 712769



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #14 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6210127

$ rpmlint -i -v *
snappy-player.src: I: checking
snappy-player.src: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.src: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.src: I: checking-url http://projects.gnome.org/snappy/ (timeout
10 seconds)
snappy-player.src: I: checking-url
https://git.gnome.org/browse/snappy/snapshot/snappy-0bd0c0c39128ce490d06b41c1a1c8f4852d527b3.tar.gz
(timeout 10 seconds)
snappy-player.armv7hl: I: checking
snappy-player.armv7hl: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.armv7hl: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.armv7hl: I: checking-url http://projects.gnome.org/snappy/
(timeout 10 seconds)
snappy-player.armv7hl: W: no-manual-page-for-binary snappy
Each executable in standard binary directories should have a man page.

snappy-player.i686: I: checking
snappy-player.i686: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.i686: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.i686: I: checking-url http://projects.gnome.org/snappy/ (timeout
10 seconds)
snappy-player.i686: W: no-manual-page-for-binary snappy
Each executable in standard binary directories should have a man page.

snappy-player.x86_64: I: checking
snappy-player.x86_64: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.x86_64: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.x86_64: I: checking-url http://projects.gnome.org/snappy/
(timeout 10 seconds)
snappy-player.x86_64: W: no-manual-page-for-binary snappy
Each executable in standard binary directories should have a man page.

snappy-player-debuginfo.armv7hl: I: checking
snappy-player-debuginfo.armv7hl: I: checking-url
http://projects.gnome.org/snappy/ (timeout 10 seconds)
snappy-player-debuginfo.i686: I: checking
snappy-player-debuginfo.i686: I: checking-url http://projects.gnome.org/snappy/
(timeout 10 seconds)
snappy-player-debuginfo.x86_64: I: checking
snappy-player-debuginfo.x86_64: I: checking-url
http://projects.gnome.org/snappy/ (timeout 10 seconds)
snappy-player.spec: I: checking-url
https://git.gnome.org/browse/snappy/snapshot/snappy-0bd0c0c39128ce490d06b41c1a1c8f4852d527b3.tar.gz
(timeout 10 seconds)
7 packages and 1 specfiles checked; 0 errors, 11 warnings.


The same warnings as in comment #10. The libltdl folder is vanished from the
source tarball, and the gstreamer conflict seems also to be solved. OK, here we
go:

-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If 

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640

Antonio Trande anto.tra...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #15 from Antonio Trande anto.tra...@gmail.com ---
Thanks!

New Package SCM Request
===
Package Name: snappy-player
Short Description: An open-source Gnome media player
Owners: sagitter
Branches: f19 f20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640



--- Comment #12 from Antonio Trande anto.tra...@gmail.com ---
snappy now requires clutter-gst2 (see
https://bugzilla.gnome.org/show_bug.cgi?id=712769).

Spec URL: http://sagitter.fedorapeople.org/snappy/snappy.spec
SRPM URL:
http://sagitter.fedorapeople.org/snappy/snappy-player-0.3.7-1.20131121git0bd0c0c3.fc19.src.rpm

 But we have a bundled library. The folder ./ltdl contains that what Fedora 
 ships  as libtool-ltdl-devel. Please remove the folder in %prep and make sure 
 that the Fedora package will be used during the build process.

./ltdl was included by me wrongly. It's been removed in this commit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640



--- Comment #9 from Antonio Trande anto.tra...@gmail.com ---
Spec URL: http://sagitter.fedorapeople.org/snappy/snappy-player.spec
SRPM URL:
http://sagitter.fedorapeople.org/snappy/snappy-player-0.3.7-1.20131119git8ece98e0.fc19.src.rpm

Koji build in rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6206040

- Update to upstream git commit of the 2013-11-19
- Set CFLAGS (C compiler flags)
- Changed Name/Icon entries and added a category in the .desktop file

Autotools files are now provided in the source archive by upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review?



--- Comment #10 from Mario Blättermann mario.blaetterm...@gmail.com ---
$ rpmlint -i -v *
snappy-player.armv7hl: I: checking
snappy-player.armv7hl: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.armv7hl: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.armv7hl: I: checking-url http://projects.gnome.org/snappy/
(timeout 10 seconds)
snappy-player.armv7hl: W: no-manual-page-for-binary snappy
Each executable in standard binary directories should have a man page.

snappy-player.i686: I: checking
snappy-player.i686: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.i686: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.i686: I: checking-url http://projects.gnome.org/snappy/ (timeout
10 seconds)
snappy-player.i686: W: no-manual-page-for-binary snappy
Each executable in standard binary directories should have a man page.

snappy-player.src: I: checking
snappy-player.src: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.src: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.src: I: checking-url http://projects.gnome.org/snappy/ (timeout
10 seconds)
snappy-player.src: I: checking-url
https://git.gnome.org/browse/snappy/snapshot/snappy-8ece98e0b8b7ea8e79b0d181fb8f79bd8895d3ed.tar.gz
(timeout 10 seconds)
snappy-player.x86_64: I: checking
snappy-player.x86_64: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.x86_64: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.x86_64: I: checking-url http://projects.gnome.org/snappy/
(timeout 10 seconds)
snappy-player.x86_64: W: no-manual-page-for-binary snappy
Each executable in standard binary directories should have a man page.

snappy-player-debuginfo.armv7hl: I: checking
snappy-player-debuginfo.armv7hl: I: checking-url
http://projects.gnome.org/snappy/ (timeout 10 seconds)
snappy-player-debuginfo.i686: I: checking
snappy-player-debuginfo.i686: I: checking-url http://projects.gnome.org/snappy/
(timeout 10 seconds)
snappy-player-debuginfo.x86_64: I: checking
snappy-player-debuginfo.x86_64: I: checking-url
http://projects.gnome.org/snappy/ (timeout 10 seconds)
snappy-player.spec: W: invalid-url Source10: snappy-Makefile.in-src.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source9: snappy-Makefile.in-data-L2.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source8:
snappy-Makefile.in-data-icons.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source7:
snappy-Makefile.in-data-icons-48.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source6:
snappy-Makefile.in-data-icons-256.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source5: snappy-m4-L1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source4: snappy-libltdl-L1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source3: snappy-config-Makefile-L1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source2: snappy-build-aux-L1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source1: snappy-aclocal.m4-L1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: I: checking-url
https://git.gnome.org/browse/snappy/snapshot/snappy-0.3.7.tar.gz (timeout 10
seconds)
7 packages and 1 

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640



--- Comment #11 from Antonio Trande anto.tra...@gmail.com ---
There is a malfunctioning in snappy, it's documented by this warnings:

(snappy:27349): GLib-GObject-WARNING **: specified class size for type
`ClutterGstVideoSink' is smaller than the parent type's `GstBaseSink' class
size
(snappy:27349): GLib-GObject-WARNING **: cannot register existing type
`GstObject'
(snappy:27349): GLib-CRITICAL **: g_once_init_leave: assertion `result != 0'
failed
(snappy:27349): GLib-GObject-CRITICAL **: g_type_register_static: assertion
`parent_type  0' failed
(snappy:27349): GLib-CRITICAL **: g_once_init_leave: assertion `result != 0'
failed
(snappy:27349): GLib-GObject-WARNING **: interface type
`GstImplementsInterface' or prerequisite type `invalid' invalid
(snappy:27349): GLib-GObject-CRITICAL **: g_type_add_interface_static:
assertion `G_TYPE_IS_INSTANTIATABLE (instance_type)' failed
(snappy:27349): GLib-GObject-CRITICAL **: g_type_add_interface_static:
assertion `G_TYPE_IS_INSTANTIATABLE (instance_type)' failed
(snappy:27349): GLib-CRITICAL **: g_once_init_leave: assertion `result != 0'
failed
(snappy:27349): GStreamer-CRITICAL **: gst_element_register: assertion
`g_type_is_a (type, GST_TYPE_ELEMENT)' failed

This problem seems caused by a conflict between gstreamer and gstreamer1 if
installed together.
snappy needs 'gstreamer1' but 'gstreamer-old' is required by 'clutter-gst' that
it is another required package.
So I changed 'clutter-gst' in 'clutter-gst2' (snappy requires  clutter-gst =
1.5.5) and conformed the .spec file to find the right header/libs files.
The warnings are disappeared and snappy works better.


I inform the upstream in order to know if this change is acceptable.

I'm sorry, Mario. I have just checked about this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

External Bug ID||GNOME Desktop 697640



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-05-14 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947640

Antonio Trande anto.tra...@gmail.com changed:

   What|Removed |Added

  Alias||snappy-player

--- Comment #8 from Antonio Trande anto.tra...@gmail.com ---
Waiting for Autotool files inclusion from upstream
(https://bugzilla.gnome.org/show_bug.cgi?id=697640) ...

Spec URL: http://sagitter.fedorapeople.org/snappy/snappy-player.spec
SRPM URL:
http://sagitter.fedorapeople.org/snappy/snappy-player-0.3.7-1.fc18.src.rpm

- Update to 0.3.7
- Package renamed as 'snappy-player' to avoid conflict with 'snappy' library
  according to upstream (https://bugzilla.gnome.org/show_bug.cgi?id=697122)
- Definited 'realname' macro
- Added missing Autotools files in source archive
- Removed Explicit Requires 
- Set the environment variables CLUTTER_GST_CFLAGS/CLUTTER_GST_LIBS
- Defined binary name conflict

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5380202

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Xk4vbIjaxHa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-04-09 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947640

--- Comment #6 from Antonio Trande anto.tra...@gmail.com ---
Two issues are pending for snappy: 

1) Fixing of the package/binary name's conflicts
2) Inclusion of Autotools pre-generated files in the source tarball

I'm waiting these fixes from upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=SGhm0FHw0Ca=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-04-09 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947640

--- Comment #7 from Antonio Trande anto.tra...@gmail.com ---
(In reply to comment #6)
 1) Fixing of the package/binary name's conflicts

Quote from https://bugzilla.gnome.org/show_bug.cgi?id=697122 :

A decision has been made in this Spice-devel mailing list thread:
http://lists.freedesktop.org/archives/spice-devel/2013-April/012953.html

I suggest for upcoming release to rename snappy to something like
snappy-spice (that would be easy enough to discover when completing for ex)

Soon a new spice-gtk release is going to come out, this will have moved the
executable to /usr/bin/snappy-spice.

Then snappy (the player) can be packaged in Fedora as...
package name = snappy-player
executable = /usr/bin/snappy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=EMYmL9s1aba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-04-08 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947640

--- Comment #4 from Antonio Trande anto.tra...@gmail.com ---
(In reply to comment #2)
 Hi, a few comment :

Hi Michael.

 - Requires:  
 gstreamer1,clutter,clutter-gtk,gstreamer1-plugins-base,clutter-gst,gtk3
 
 gtk3, gstreamer1 and clutter are likely already pulled by rpm automated
 library dependency. And gstreamer1-plugins-base is likely pulled already.
 Can you clean the Requires from redundant rpm ?

Yes.

 
 - why is autoreconf -i run in %build ?

'configure' file is not in main source directory. Indeed autoreconf command
seems not well-accepted in Fedora according to this old wiki
http://fedoraproject.org/wiki/PackagingDrafts/AutoConf. Currently I don't know
if it can be used safely in case like that.

Also, I could use 'autogen.sh' in the source but, in this way, 'configure'
would be additional.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TwLdaBNY46a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-04-08 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947640

--- Comment #5 from Michael Schwendt mschwe...@gmail.com ---
Re: comment 2

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
 - https://fedoraproject.org/wiki/Packaging:ScriptletSnippets
 --
https://fedoraproject.org/wiki/Category:Package_Maintainers#Packaging_Guidelines


 Requires:   
 gstreamer1,clutter,clutter-gtk,gstreamer1-plugins-base,clutter-gst,gtk3

The following guideline is more important here:

  https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

Readability is secondary. Some packagers like multiple dependencies per line,
but they separate them with spaces to get a minimum of readability.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=lQVQBqVRJ8a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-04-07 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947640

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 CC||m...@zarb.org

--- Comment #2 from Michael Scherer m...@zarb.org ---
Hi, a few comment :
- I personnally find that Requires and BuildRequires are more readable if there
is one per line, especially since this is cleaner when reviewing diff.

- Requires:  
gstreamer1,clutter,clutter-gtk,gstreamer1-plugins-base,clutter-gst,gtk3

gtk3, gstreamer1 and clutter are likely already pulled by rpm automated library
dependency. And gstreamer1-plugins-base is likely pulled already. Can you clean
the Requires from redundant rpm ?

- why is autoreconf -i run in %build ?

- as %post run /usr/bin/update-mime-database , shouldn't it requires
shared-mime-info as Requires(post) ? ( but I am not sure, since there is '||
:', I guess that should be checked by someone else.

- the same goes for /usr/bin/gtk-update-icon-cache ? ( especially since that's
a software in gtk2 rpm )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=anRRZSoqrba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-04-07 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947640

--- Comment #3 from Michael Scherer m...@zarb.org ---
And it doesn't build in mock on rawhide :

checking for x86_64-redhat-linux-gnu-pkg-config...
/usr/bin/x86_64-redhat-linux-gnu-pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for GST... yes
checking for CLUTTER... yes
checking for CLUTTER_GST... no
configure: error: Package requirements (clutter-gst-2.0 = 1.5.5) were not met:
No package 'clutter-gst-2.0' found
Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
Alternatively, you may set the environment variables CLUTTER_GST_CFLAGS
and CLUTTER_GST_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kq6mKMlsLIa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-04-03 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947640

--- Comment #1 from Antonio Trande anto.tra...@gmail.com ---
The snappy developer has accepted to rename snappy binary file so that
conflicts can be exceeded. 
A new release will be released soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nzTADI29eva=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review