[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Last Closed||2013-05-15 13:27:44 Status|ON_QA |CLOSED Fixed In Version||rubygem-ronn-0.7.3-3.fc19 Resolution|--- |ERRATA --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- rubygem-ronn-0.7.3-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tRj7Cqiqvca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AnrLo5y7yWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- rubygem-ronn-0.7.3-3.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X48fdZSip1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||needinfo?(rel...@redhat.com ||) --- Comment #11 from Mamoru TASAKA mtas...@fedoraproject.org --- Would you build this package on koji? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lngK1LMGLIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Flags|needinfo?(rel...@redhat.com | |) | --- Comment #12 from Ricky Elrod rel...@redhat.com --- Yep, will do so right now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NL0gJKNt7Ia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- rubygem-ronn-0.7.3-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-ronn-0.7.3-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U9F9vvnaoga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 --- Comment #14 from Mamoru TASAKA mtas...@fedoraproject.org --- Okay, thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0G9dPTScbAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Pavol Babinčák pbabi...@redhat.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1BC9k5svs6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 --- Comment #10 from Pavol Babinčák pbabi...@redhat.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pAalDPFGd1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from Mamoru TASAKA mtas...@fedoraproject.org --- Okay, clean. This package (rubygem-ronn) is APPROVED by mtasaka -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EySXdC8pw2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Ricky Elrod rel...@redhat.com --- New Package SCM Request === Package Name: rubygem-ronn Short Description: Manual authoring tool Owners: codeblock Branches: f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3Obt8cf3DZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=948105
--- Comment #6 from Mamoru TASAKA mtas...@fedoraproject.org ---
For -2:
* Requires etc
- On F-19+, rubygem-based rpm must have Requires: ruby(release)
and On F-18-, rubygem-based rpm must have Requires: ruby(abi) = 1.9.1.
One trick is
%if 0%{?fedora} = 19
Requires: ruby(release)
%else
Requires: ruby(abi) = 1.9.1
%endif
* Documentation
- What I meant is that %gem_instdir/AUTHORS and etc should be marked as %doc.
Currently these files (%gem_instdir/AUTHORS, %gem_instdir/CHANGES, etc)
are not marked as %doc, and the same files are copied into
/usr/share/doc/%{name}-%{version} (with marked as doc).
It is recommended to write %files entry more verbosely, like
%files
%dir %{gem_instdir}
%doc %{gem_instdir}/[A-Z]*
%{gem_libdir}
%{gem_instdir}/foobar
- Also, rm -rf %{buildroot}%{gem_dir}/{INSTALLING,Rakefile,test} should be
rm -rf %{buildroot}%{gem_instdir}/{INSTALLING,Rakefile,test}
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=dmGss9yssoa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 --- Comment #7 from Ricky Elrod rel...@redhat.com --- New SRPM: http://codeblock.fedorapeople.org/packages/rubygem-ronn/rubygem-ronn-0.7.3-3.fc19.src.rpm New Spec: http://codeblock.fedorapeople.org/packages/rubygem-ronn/rubygem-ronn.spec Thanks for explaining the F18- and F19+ trick. And hopefully I got the %files section right this time. :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Sa68MBq9rIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 --- Comment #5 from Ricky Elrod rel...@redhat.com --- Thanks for the feedback, and sorry I uploaded the wrong RPM, I didn't even notice. :) I believe I've addressed everything you've pointed out so far - and yes, I will happily review one of yours in return. Look for it tomorrow. New SRPM: http://codeblock.fedorapeople.org/packages/rubygem-ronn/rubygem-ronn-0.7.3-2.fc18.src.rpm New Spec: http://codeblock.fedorapeople.org/packages/rubygem-ronn/rubygem-ronn.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7168QdCB3ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added CC||mtas...@fedoraproject.org --- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org --- Hello, Ricky: If you want review swap, I would appreciate it if you would swap this bug with one of my review requests (e.g. bug 922460 ). By the way, ruby(release) is provided by ruby only on F-19+, not on F-18 and below while your srpm contains .fc18. Is this what you intended? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NK2X21kk9xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? --- Comment #2 from Mamoru TASAKA mtas...@fedoraproject.org --- Anyway taking. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hJqKnpso6Na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 --- Comment #3 from Mamoru TASAKA mtas...@fedoraproject.org --- Oh, please upload srpm, not rebuilt rpm, thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ksknSrbOr8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=948105
--- Comment #4 from Mamoru TASAKA mtas...@fedoraproject.org ---
* BuildRequires
- srpm rebuilt from your spec file won't build on koji F20.
Please add appropriate BuildRequires (at least rubygem-devel is
needed)
* Documentation etc
- Please mark AUTHORS CHANGES COPYING README.md %{gem_docdir} as %doc
(at least COPYING must be marked as %doc)
- INSTALLING file is not needed as installing is done by rpm
- Also Rakefile is not needed as Rakefile is like Makefiles in
autotools based files, which we do not package into binary rpms.
- It is recommended to split out %gem_docdir into -doc rpm.
- test/ directory should not be packaged into binary rpm:
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
* Virtual Requires
- For (Build)Requires, please use Requires: rubygem(hpricot) style instead
of
directly writing rpms' names (i.e. instead of Requires: rubygem-hpricot)
so as to be consistent of other packages.
* Running test suites
- As this gem contains test/ directory, please add %check seciton and
execute some test program in %check:
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=3go7SJRz5va=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
