Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=949154
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
Status|NEW |ASSIGNED
CC||rdie...@math.unl.edu
Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
Flags||fedora-review?
--- Comment #1 from Rex Dieter rdie...@math.unl.edu ---
I can review...
1. MUST fix license, recommend using:
License: GPLv3+
since it's a mixture of BSD and GPLv2+ and GPLv3+
$ licensecheck -r *
build/CMakeFiles/2.8.10.2/CompilerIdC/CMakeCCompilerId.c: *No copyright*
UNKNOWN
macosx/strip_bundle.sh: *No copyright* UNKNOWN
qkeysequencewidget/qkeysequencewidget.h: BSD (3 clause)
qkeysequencewidget/qkeysequencewidget.cpp: BSD (3 clause)
qkeysequencewidget/qkeysequencewidget_p.h: BSD (3 clause)
qmenuview/qmenuview_p.h: GPL (v3 or later)
qmenuview/qmenuview.h: GPL (v3 or later)
qmenuview/qmenuview.cpp: GPL (v3 or later)
src/qlippertypes.h: *No copyright* UNKNOWN
src/qlipperpreferencesdialog.h: GPL
src/qlipperpreferences.h: GPL
src/qlippernetwork.cpp: GPL
src/qlipperpreferences.cpp: GPL
src/qlippermodel.h: GPL
src/qlippermodel.cpp: GPL
src/qlipperitem.h: GPL
src/qlippernetwork.h: GPL
src/qlippermenuview.cpp: GPL
src/qlippermenuview.h: GPL
src/config.h: GPL
src/main.cpp: GPL
src/qlipperpreferencesdialog.cpp: GPL
src/qlippersystray.cpp: GPL
src/qlipperitem.cpp: GPL
src/qlippersystray.h: GPL
sources: ok
e5e256de9b8ea07e237bde9b8e3ceb75 qlipper-2.0.1.tar.bz2
2. SHOULD drop from %build:
-DCMAKE_INSTALL_PREFIX=/usr
this is redundant and already included in %cmake macro
macros: ok
builds/installs: ok
scriptlets: n/a (none)
3. SHOULD drop and cross-platform from %description, it doesn't add any
value, imo
the rest is a fairly simple package, I see no other issues.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=HPfVvWflFya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
