[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from Mamoru TASAKA mtas...@fedoraproject.org --- Okay. -- This package (python-workerpool) is APPROVED by mtasaka -- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bJ6Oq7xkjoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Orion Poplawski or...@cora.nwra.com --- New Package SCM Request === Package Name: python-workerpool Short Description: Multithreaded job distribution module Owners: orion Branches: f19 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=enYPua8rNDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HTpgH37wZ1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tBJ4tWtksea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-05-04 17:03:04 --- Comment #11 from Orion Poplawski or...@cora.nwra.com --- Checked in and built. Thanks all! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e0SJxhlR0Ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 --- Comment #6 from Mamoru TASAKA mtas...@fedoraproject.org --- Well, * So would you tell me if test directory is really needed (for %doc)? (not a blocker, however I want to see your opinition). Note that currently test_workerpool.py.test is also packaged, which at least should be removed. * After reading bug 957568 comment 2 , I now thinks that workerpool.egg-info in tarball should be removed at %prep to ensure that egg-info is really rebuilt, however for now I leave it to you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hh6RW5jVDRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 --- Comment #7 from Orion Poplawski or...@cora.nwra.com --- http://www.cora.nwra.com/~orion/fedora/python-workerpool-0.9.2-4.fc18.src.rpm * Fri May 3 2013 Orion Poplawski or...@cora.nwra.com - 0.9.2-4 - Don't ship tests - Remove shipped egg-info Yeah, probably not worth shipping these tests. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dTW4LdepLja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? --- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org --- For 0.9.2-1: * License tag - The license is MIT, not BSD. * Build failure - Does not build on either F-20 or F-19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5325042 http://koji.fedoraproject.org/koji/taskinfo?taskID=5325043 Seems python-nose, python3-nose are needed for BR. However even with these, %check still really fails randomly: http://koji.fedoraproject.org/koji/taskinfo?taskID=5325084 * $RPM_BUILD_ROOT v.s. %buildroot https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS - Please choose one style and aviod using both style. * No longer needed stuff https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag - Cleaning up %buildroot at the beginning of %install is no longer needed (on Fedora). * Suggestions * Same summary / description for python2 and python3 version package - At least it is preferable to distinguish python2 and python3 version of the packages in %description. * Needed documentations - Is test directory needed for documentation? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8gK1xZALLZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 --- Comment #2 from Mamoru TASAKA mtas...@fedoraproject.org --- By the way I appreciate it if you would review one of my review requests (bug 958149 ) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h1oiwcAEada=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 --- Comment #3 from Orion Poplawski or...@cora.nwra.com --- I've filed this issue about the test failure: https://github.com/shazow/workerpool/issues/3 Looks like the tests assume a certain ordering of operations, but it does not appear that workerpool guarantees that ordering. Hopefully I'll get a response soon. I've fixed the other stuff here: http://www.cora.nwra.com/~orion/fedora/python-workerpool.spec http://www.cora.nwra.com/~orion/fedora/python-workerpool-0.9.2-1.fc18.src.rpm * Thu May 2 2013 Orion Poplawski or...@cora.nwra.com - 0.9.2-2 - Change license to MIT - Fix macro consistency - Add BR python-nose -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BAvSpnMi0Ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 --- Comment #4 from Mamoru TASAKA mtas...@fedoraproject.org --- Well, if you are okay I will also wait for upstream response about test failure. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2O1LSfT3WMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 --- Comment #5 from Orion Poplawski or...@cora.nwra.com --- http://www.cora.nwra.com/~orion/fedora/python-workerpool.spec http://www.cora.nwra.com/~orion/fedora/python-workerpool-0.9.2-3.fc18.src.rpm * Thu May 2 2013 Orion Poplawski or...@cora.nwra.com - 0.9.2-3 - Add patch to fix tests Patch submitted and accepted upstream. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=re6k2u4V2Ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Blocks||949371 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ERZmoAJOD3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
