[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 Fedora Update System changed: What|Removed |Added Fixed In Version|rubygem-serialport-1.3.0-5. |rubygem-serialport-1.3.0-5. |fc19|fc20 --- Comment #18 from Fedora Update System --- rubygem-serialport-1.3.0-5.fc20, rubygem-icaro-1.0.6-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Fixed In Version||rubygem-serialport-1.3.0-5. ||fc19 Resolution|--- |ERRATA Last Closed||2014-03-15 11:11:31 --- Comment #17 from Fedora Update System --- rubygem-serialport-1.3.0-5.fc19, rubygem-icaro-1.0.6-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #16 from Fedora Update System --- rubygem-serialport-1.3.0-5.fc20,rubygem-icaro-1.0.6-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-serialport-1.3.0-5.fc20,rubygem-icaro-1.0.6-2.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #15 from Fedora Update System --- rubygem-serialport-1.3.0-5.fc19,rubygem-icaro-1.0.6-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-serialport-1.3.0-5.fc19,rubygem-icaro-1.0.6-2.fc19 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #14 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #13 from Alejandro_Perez --- Update the request to remove coma New Package SCM Request === Package Name: rubygem-serialport Short Description: Ruby class for using RS232 serial ports Owners: aeperezt Branches: f19 f20 el6 epel7 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #11 from Alejandro_Perez --- New Package SCM Request === Package Name: Rubygem-serialport Short Description: Ruby class for using RS232 serial ports Owners: aeperezt Branches: f19,f20 el6 epel7 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #12 from Alejandro_Perez --- Change the name to lower case. Sorry for that. New Package SCM Request === Package Name: rubygem-serialport Short Description: Ruby class for using RS232 serial ports Owners: aeperezt Branches: f19,f20 el6 epel7 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 Alejandro_Perez changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 Luis Bazan changed: What|Removed |Added Blocks|949319 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=949319 [Bug 949319] Review Request: rubygem-icaro - Ruby Api for Icaro Robotic -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 Luis Bazan changed: What|Removed |Added Blocks||949319 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=949319 [Bug 949319] Review Request: rubygem-icaro - Ruby Api for Icaro Robotic -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 Luis Bazan changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Luis Bazan --- Hi Alejandro You have met all the requested changes. I just did one last review and all comply with the guidelines. Approved! Best Regards! -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 Luis Bazan changed: What|Removed |Added Status|NEW |ASSIGNED CC||bazanlui...@gmail.com Assignee|nob...@fedoraproject.org|bazanlui...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #9 from Alejandro_Perez --- Updated to the new version of gem serialport 1.3.0 http://aeperezt.fedorapeople.org/rpmdev/rubygem-serialport.spec http://aeperezt.fedorapeople.org/rpmdev/rubygem-serialport-1.3.0-5.fc20.src.rpm Koji build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=6487513 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #8 from Alejandro_Perez --- Sorry wrong koji link, this one is correct http://koji.fedoraproject.org/koji/taskinfo?taskID=6337919 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #7 from Alejandro_Perez --- Koji Rawhide build http://koji.fedoraproject.org/koji/taskinfo?taskID=6337956 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 Alejandro_Perez changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #6 from Alejandro_Perez --- Added the changes. About the test not sure how to execute the test, this test is to use the serial port so to execute the test we need to give serial port device , bauds and all that. So we cannot run it or at least I don't know how to do it. Spec: http://aeperezt.fedorapeople.org/rpmdev/rubygem-serialport.spec SRPM: http://aeperezt.fedorapeople.org/rpmdev/rubygem-serialport-1.1.0-4.fc19.src.rpm Thanks for you help. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hTQy6CKH6Y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317
--- Comment #5 from Vít Ondruch ---
* Separate changelog entries by empty line
- It is common
- It is easier to read
- Some tools cannot handle the changelog properly. Try "$ fedpkg clog" for
example.
* Remove BuildRoot
- This tag is not needed for Fedora. It is useful just for EPEL5.
* Remove %defattr
- This is now default. No need to specify. Please remove the macro.
* Exclude %{gem_cache}
- Please %exclude %{gem_cache}. This file has no purpose on Fedora.
* Please execute test suite if possible.
* Backslash in %description is not needed IMO.
* %{gem_instdir} ownership
- I typically suggest to structure %files section as follows
%dir %{gem_instdir}
%{gem_libdir}
- You own directly the %{gem_instdir}, but that means you own whole content
of that directory. It means that during further updates, there might slip
through your hands important additions etc. This is not a show stopper, but
good practice IMO.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Tyq3srsp12&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #4 from Alejandro_Perez --- I added the ExcludeArch to be safe had not tested on those plataforms, removed from the spec file, added recomended changes. Spec: http://aeperezt.fedorapeople.org/rpmdev/rubygem-serialport.spec SRPM: http://aeperezt.fedorapeople.org/rpmdev/rubygem-serialport-1.1.0-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GgeL9ryCrh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317
Vít Ondruch changed:
What|Removed |Added
CC||vondr...@redhat.com
--- Comment #3 from Vít Ondruch ---
(In reply to Eduardo Echeverria from comment #2)
> There are some issues in fedora-review which appear to be false positives
> - Pure Ruby package must be built as noarch
> See:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support
> this package contains C extensions, therefore are dependent arch
The package is not marked as noarch as far as I can say, but the -doc
subpackage should be noarch IMO.
BTW why is there "ExcludeArch: ppc ppc64"? Is that known that these package
does not work on PPC? Sorry, I did not checked, I'm just wondering.
> - Compiler flags do not honor fedora specific. please add
> export CONFIGURE_ARGS="--with-cflags='%{optflags}'"
> above %gem_install
The CONFIGURE_ARGS variable now part of %gem_install macro, so it is OK to be
omitted.
* Please use %{gem_instdir} in place of %{gem_dir}/gems/%{gem_name}-%{version}/
- We have macro for this construct, no need to be so verbose
- Moreover, we use to prepend %dir to this macro and include the content of
this directory explicitly. Although it is more work, it gives you a bit
more
fine grained control during updates, what goes into package and what was
changed, etc.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=7VNPRFiTxn&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
https://bugzilla.redhat.com/show_bug.cgi?id=949317
Eduardo Echeverria changed:
What|Removed |Added
CC||echevemas...@gmail.com
Flags|needinfo? |
--- Comment #2 from Eduardo Echeverria ---
There are some issues in fedora-review which appear to be false positives
- Pure Ruby package must be built as noarch
See: https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support
this package contains C extensions, therefore are dependent arch
if you don't want ship the package to el5:
- %clean is not needed
- BuildRoot is not needed
- cleaning of buildroot in %install is not needed
- %defattr is not needed
- Compiler flags do not honor fedora specific. please add
export CONFIGURE_ARGS="--with-cflags='%{optflags}'"
above %gem_install
- Please exclude cached Gem with %exclude %{gem_cache}
- There are tests in the package, should be executed
- Add the license file, exists in the source.
- the files README CHANGELOG are twice listed, please fix it
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=nbAdeEkU5c&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949317 Alejandro_Perez changed: What|Removed |Added Flags||needinfo? --- Comment #1 from Alejandro_Perez --- rpmlint Output: rpmlint SPECS/rubygem-serialport.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/rubygem-serialport-1.1.0-1.fc19.src.rpm rubygem-serialport.src: W: strange-permission rubygem-serialport.spec 0600L 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint RPMS/x86_64/rubygem-serialport-1.1.0-1.fc19.x86_64.rpm rubygem-serialport.x86_64: W: no-soname /usr/lib64/gems/ruby/serialport-1.1.0/lib/serialport.so 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CLeiREBX9b&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
