[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- libsidplayfp-1.0.1-2.fc17, sidplayfp-1.0.1-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XSYJbylRDsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- libsidplayfp-1.0.1-2.fc18, sidplayfp-1.0.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0L7gW7Mjiva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 Bug 951823 depends on bug 951820, which changed state. Bug 951820 Summary: Review Request: libsidplayfp - SID chip music module playing library https://bugzilla.redhat.com/show_bug.cgi?id=951820 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KwLVlFYX7na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-26 23:21:44 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ql01t3GYG7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- libsidplayfp-1.0.1-2.fc19, sidplayfp-1.0.1-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0ahQMd2XtSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NgAEl5EMQ1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IoCv74JcK2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- libsidplayfp-1.0.1-2.fc19, sidplayfp-1.0.1-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0RJv8K7JZKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZHYnqwn05pa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ckEIB3UWZta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- libsidplayfp-1.0.1-2.fc19,sidplayfp-1.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libsidplayfp-1.0.1-2.fc19,sidplayfp-1.0.1-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V9XRwsy7HXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- libsidplayfp-1.0.1-2.fc18,sidplayfp-1.0.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libsidplayfp-1.0.1-2.fc18,sidplayfp-1.0.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z4nmgNuxcQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- libsidplayfp-1.0.1-2.fc17,sidplayfp-1.0.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libsidplayfp-1.0.1-2.fc17,sidplayfp-1.0.1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gNx9lmTa16a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #1 from Michael Schwendt mschwe...@gmail.com --- * rpmlint only finds a few incorrect-fsf-address issues: https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address Reported: https://sourceforge.net/tracker/?group_id=257241atid=1551608 * sidplayfp options --none and --nosid segfault. Reported: https://sourceforge.net/tracker/?func=detailaid=3611237group_id=257241atid=1551608 * stilview usage txt refers to USAGE.txt file that isn't packaged. Reported: https://sourceforge.net/tracker/?group_id=257241atid=1551608 Run-time test: $ HVSC_BASE=/home/ms19a/Music/INCOMING/HVSC/C64Music stilview -e=/DEMOS/0-9/3_Oversample.sid TITLE: Get Ready ARTIST: Jeroen Tel COMMENT: Same as /MUSICIANS/T/Tel_Jeroen/HCS_etc/Get_Ready.sid, but with digis added and with voice 1 largely muted. * Build with pulseaudio and ALSA? $ grep alsa sidplayfp.spec BuildRequires: libsidplayfp-devel alsa-lib-devel pulseaudio-libs-devel $ rpm -qR sidplayfp|grep alsa $ Somebody has reported it already: https://sourceforge.net/tracker/?func=detailaid=3609103group_id=257241atid=1551608 * Run-time test: It's expected that with no ROM images available, some sids that did play with libsidplay1 are just silent (since old libsidplay set up fake interrupts, e.g. CIA Timer IRQs, for non VBI-speed playback). Installing the non-free vice-data package makes those test tunes work. Since a few users have asked about such silent sids before in upstream tracker, I will contact upstream about whether it is known how much exactly is missing (e.g. just default IRQ handlers in kernal space or larger parts?). * Untested: The Songlength Database which is also touched by one of the patches. I dunno what may have changed over the past years, whether it works and whether it is still updated. make install DESTDIR=$RPM_BUILD_ROOT Just for the record, nowadays there's %make_install for that. * Other than that, I see no packaging mistakes. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HpTOEyLUdpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 --- Comment #2 from Hans de Goede hdego...@redhat.com --- (In reply to comment #1) * Untested: The Songlength Database which is also touched by one of the patches. I dunno what may have changed over the past years, whether it works and whether it is still updated. I've tested this and it works :) The patch is only so that the Songlenghts.txt file can be optionally put under /usr/share/sidplayfp, so that it is available for all users, rather then each user needing to put it in ~/.local/share/sidplayfp separately. Also it has been send upstream and accepted there. make install DESTDIR=$RPM_BUILD_ROOT Just for the record, nowadays there's %make_install for that. I know, but whomever came up with that should have given it a better name, this is way too much like the bad %makeinstall, so I prefer the old way. APPROVED Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t7A1spKQHFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Hans de Goede hdego...@redhat.com --- New Package SCM Request === Package Name: sidplayfp Short Description: SID chip music module player Owners: jwrdegoede Branches: f17 f18 f19 InitialCC: mschwendt -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gWNVQjxNBBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mschwe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ECdgi17cjpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951823] Review Request: sidplayfp - SID chip music module player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951823 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Depends On||951820 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LM07Pe03QEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
