[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 Petr Šabata changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? --- Comment #1 from Petr Šabata --- Taking the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1ER1ugGz4e&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #2 from Petr Šabata --- Missing buildtime deps: perl(base), ./inc/FirebirdMaker.pm:6, ./t/TestFirebird.pm:22, ./TestFirebirdEmbedded.pm:17 perl(Carp), ./Makefile.PL:63, ./Firebird.pm:13, ./Firebird.pm:163, ./t/TestFirebirdEmbedded.pm:8, perl(constant), ./t/TestFirebird.pm:31-33, ./t/TestFirebirdEmbedded.pm:27-28, ./t/dbi-table_info.t:17,42 perl(Data::Dumper), ./t/91-txinfo.t:7 perl(DBI::DBD), ./Makefile.PL:184 perl(Encode), ./t/75-utf8.t:17 perl(Exporter), ./inc/FirebirdMaker.pm:6, ./Firebird.pm:17, ./lib/DBD/Firebird/TypeInfo.pm:13, ./t/TestFirebird.pm:22, ./t/TestFirebirdEmbedded.pm:17 perl(File::Temp), ./t/TestFirebird.pm:18, ./t/TestFirebirdEmbedded.pm:13 perl(Getopt::Long), ./Makefile.PL:66 perl(lib), most tests (+ Config, DynaLoader, File::Basename, File::Spec, Math::BigFloat, POSIX, strict, utf8, vars, warnings; see the same comment in DBD::InterBase) Perl v5.10.1 is required (./Firebird.pm:9), therefore your perl >= 5.8.1 BR is incorrect. This is another reason why this can't go to EPEL5. I also think specifying the version here is not necessary. %defattr is not required, could be dropped. The same for line 35. You could add the 'eg' directory to %doc. Since this isn't going to EPEL5, drop the Buildroot-related stuff. It's not needed. (lines 17, 31, 42, and 43) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xASC8wynYh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #3 from Robert Scheck --- Thank you for taking the review. I have applied all suggested changes, except the 'eg' directory - because building of DBD::FirebirdEmbed doesn't work from my point of view (and it is IMHO not needed anyway). Spec URL: http://labs.linuxnetz.de/bugzilla/perl-DBD-Firebird.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/perl-DBD-Firebird-1.11-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5hZYJ6tAQW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 Petr Šabata changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Petr Šabata --- Ok, everything's fixed. Approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R0QZuxTZbx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 Robert Scheck changed: What|Removed |Added CC||red...@linuxnetz.de Flags||fedora-cvs? --- Comment #5 from Robert Scheck --- Thank you very much for the package review! New Package SCM Request === Package Name: perl-DBD-Firebird Short Description: A Firebird interface for perl Owners: robert Branches: el6 f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Su1ql3onUI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5fiRxJGkJn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rLdIDDCJhe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #11 from Fedora Update System --- perl-DBD-Firebird-1.11-2.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jNS1xZIKnj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IEDdKoTIA2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sgoLjpQpQt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #7 from Fedora Update System --- perl-DBD-Firebird-1.11-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-DBD-Firebird-1.11-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FXgyAzqMxM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #8 from Fedora Update System --- perl-DBD-Firebird-1.11-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-DBD-Firebird-1.11-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=435MtlqFYI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #9 from Fedora Update System --- perl-DBD-Firebird-1.11-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-DBD-Firebird-1.11-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vgUa4vXupu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #10 from Fedora Update System --- perl-DBD-Firebird-1.11-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-DBD-Firebird-1.11-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W76emGRRYO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-26 23:19:17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EYTzDIeuIQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #12 from Fedora Update System --- perl-DBD-Firebird-1.11-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6CEOjW4EWO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #14 from Fedora Update System --- perl-DBD-Firebird-1.11-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0T4SSFs8Db&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #13 from Fedora Update System --- perl-DBD-Firebird-1.11-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W3xYtEo6l1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951874] Review Request: perl-DBD-Firebird - A Firebird interface for perl
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951874 --- Comment #15 from Fedora Update System --- perl-DBD-Firebird-1.11-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jsPqHvQVZV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
