[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-08-10 08:31:04 --- Comment #13 from Ralph Bean rb...@redhat.com --- Updates have been pushed to stable. Closing this ticket. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IlbPXwB2xMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 Bug 952355 depends on bug 952343, which changed state. Bug 952343 Summary: Review Request: python-svg-path - SVG path objects and parser https://bugzilla.redhat.com/show_bug.cgi?id=952343 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9rwpZQ8ngca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- hovercraft-1.1-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HzNNOHgNx7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- hovercraft-1.1-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n4n9N7pfsua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 Bug 952355 depends on bug 951711, which changed state. Bug 951711 Summary: Review Request: impressjs - Javascript presentation framework https://bugzilla.redhat.com/show_bug.cgi?id=951711 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=plt5R2CdKBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- hovercraft-1.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/hovercraft-1.1-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SQl8OjQd7Ia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 --- Comment #3 from Patrick Uiterwijk puiterw...@gmail.com --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. NO, See below - License CC0/BSD NO - License field in spec matches NO, See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream sha256sum: This package: c21eb09e6e0e5b8fd34275fda08fdd30e52dcf09b22b2ab3293a16287fd212c6 Upstream package: c21eb09e6e0e5b8fd34275fda08fdd30e52dcf09b22b2ab3293a16287fd212c6 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK, See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Rpmlint output: Checking: hovercraft-1.1-1.fc20.noarch.rpm hovercraft.noarch: W: spelling-error Summary(en_US) reStructuredText - restructured Text, restructured-text, restructure hovercraft.noarch: W: spelling-error %description -l en_US reStructuredText - restructured Text, restructured-text, restructure hovercraft.noarch: W: spelling-error %description -l en_US repositioning - re positioning, re-positioning, positioning hovercraft.noarch: W: dangling-symlink /usr/lib/python3.3/site-packages/hovercraft/templates/simple/js/impress.js /usr/share/impressjs/impress.js hovercraft.noarch: W: dangling-symlink /usr/lib/python3.3/site-packages/hovercraft/templates/default/js/impress.js /usr/share/impressjs/impress.js hovercraft.noarch: W: no-manual-page-for-binary hovercraft 1 packages and 0 specfiles checked; 0 errors, 6 warnings. The dangling symlinks are bogus: after installation they work. Spelling errors can be neglected in this case. Issues: 1. This package contains reST.xsl, which is licensed BSD. Maybe add this as well to the spec file? 2. The package does not contain a COPYING file. Please ask upstream to include it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3dzDQl5tA4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 --- Comment #2 from Patrick Uiterwijk puiterw...@gmail.com --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. NO, See below - License CC0/BSD NO - License field in spec matches NO, See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream sha256sum: This package: c21eb09e6e0e5b8fd34275fda08fdd30e52dcf09b22b2ab3293a16287fd212c6 Upstream package: c21eb09e6e0e5b8fd34275fda08fdd30e52dcf09b22b2ab3293a16287fd212c6 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK, See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Rpmlint output: Checking: hovercraft-1.1-1.fc20.noarch.rpm hovercraft.noarch: W: spelling-error Summary(en_US) reStructuredText - restructured Text, restructured-text, restructure hovercraft.noarch: W: spelling-error %description -l en_US reStructuredText - restructured Text, restructured-text, restructure hovercraft.noarch: W: spelling-error %description -l en_US repositioning - re positioning, re-positioning, positioning hovercraft.noarch: W: dangling-symlink /usr/lib/python3.3/site-packages/hovercraft/templates/simple/js/impress.js /usr/share/impressjs/impress.js hovercraft.noarch: W: dangling-symlink /usr/lib/python3.3/site-packages/hovercraft/templates/default/js/impress.js /usr/share/impressjs/impress.js hovercraft.noarch: W: no-manual-page-for-binary hovercraft 1 packages and 0 specfiles checked; 0 errors, 6 warnings. The dangling symlinks are bogus: after installation they work. Spelling errors can be neglected in this case. Issues: 1. This package contains reST.xsl, which is licensed BSD. Maybe add this as well to the spec file? 2. The package does not contain a COPYING file. Please ask upstream to include it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lidCkowMIXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 --- Comment #5 from Ralph Bean rb...@redhat.com --- Regarding python3-lxml, noted. I'll only request an f19 branch. License ping with upstream This is non-blocking, correct? https://github.com/regebro/hovercraft/issues/25 Here's a new release with the BSD comment added: Spec URL: http://threebean.org/rpm/hovercraft.spec SRPM URL: http://threebean.org/rpm/hovercraft-1.1-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wmTXjhtwCia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Patrick Uiterwijk puiterw...@gmail.com --- Regarding python3-lxml: feel free to request F18/F17 branches, as you will be able to build/push those as soon as the python3-lxml 3.2.1 builds that are currently in testing land in stable. Thanks for updating spec file with license. This package is APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fQ6fp3k5Yea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Ralph Bean rb...@redhat.com --- New Package SCM Request === Package Name: hovercraft Short Description: Makes impress.js presentations from reStructuredText Owners: ralph Branches: f19 f18 f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LSqkQ8ZBBDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Nm36SizlWSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ojugiiBCIxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c5iyHOh5Q4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
https://bugzilla.redhat.com/show_bug.cgi?id=952355 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- hovercraft-1.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/hovercraft-1.1-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5pjgT3QQ1Va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=952355 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||puiterw...@gmail.com Assignee|nob...@fedoraproject.org|puiterw...@gmail.com Flags||fedora-review? --- Comment #1 from Patrick Uiterwijk puiterw...@gmail.com --- Since this sounds really nice and useful, I'll take the review! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z3ciKISDpla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952355] Review Request: hovercraft - Makes impress.js presentations from reStructuredText
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=952355 Ralph Bean rb...@redhat.com changed: What|Removed |Added Depends On||951711, 952343 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jF46RUV22oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
