[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
https://bugzilla.redhat.com/show_bug.cgi?id=953101 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #73 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
https://bugzilla.redhat.com/show_bug.cgi?id=953101 Eugene A. Pivnev changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #72 from Eugene A. Pivnev --- Package Change Request == Package Name: razorqt New Branches: epel7 Owners: tieugene -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
https://bugzilla.redhat.com/show_bug.cgi?id=953101 Fedora Update System changed: What|Removed |Added Fixed In Version|razorqt-0.5.2-8.fc18|razorqt-0.5.2-9.el6 --- Comment #71 from Fedora Update System --- razorqt-0.5.2-9.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2C8xYtUO3P&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Fedora Update System changed: What|Removed |Added Fixed In Version|razorqt-0.5.2-8.fc17|razorqt-0.5.2-8.fc18 --- Comment #70 from Fedora Update System --- razorqt-0.5.2-8.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=K9avzQuiMD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Fedora Update System changed: What|Removed |Added Fixed In Version|razorqt-0.5.2-8.fc19|razorqt-0.5.2-8.fc17 --- Comment #69 from Fedora Update System --- razorqt-0.5.2-8.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TWIqyQ5h9U&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #68 from Fedora Update System --- razorqt-0.5.2-9.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/razorqt-0.5.2-9.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SMyLpLmrkF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||razorqt-0.5.2-8.fc19 Resolution|--- |ERRATA Last Closed||2013-05-14 00:37:33 --- Comment #67 from Fedora Update System --- razorqt-0.5.2-8.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2HBK4AH0v7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #66 from Fedora Update System --- razorqt-0.5.2-8.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D838meM5eb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V10C9RoMA0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #65 from Fedora Update System --- razorqt-0.5.2-8.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/razorqt-0.5.2-8.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dEzcHCl5vI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #64 from Fedora Update System --- razorqt-0.5.2-8.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/razorqt-0.5.2-8.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=llL4g0TXrK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #63 from Fedora Update System --- razorqt-0.5.2-8.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/razorqt-0.5.2-8.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2Q7wr6bfWr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZsfgLusCsc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #62 from Kevin Kofler --- I don't think this is being used consistently, but %lang(sr@latin) is probably more correct, so you can use it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hFQ6Wia0xM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #61 from Eugene A. Pivnev ---
(In reply to comment #57)
> Well, it's a bug in %find_lang that it doesn't find those files. Just list
> them manually, they're just 2 files:
> %lang(sr) %{_datadir}/razor/razor-config/razor-config-appearance...@latin.qm
> %lang(sr) %{_datadir}/razor/razor-panel/razor-panel...@latin.qm
> (Use %lang(sr) to tag them.)
Fedora uses "%lang (sr@latin) ..."
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Y10CypEurh&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #60 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wzY074ZydN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OOOi8pah1M&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Eugene A. Pivnev changed: What|Removed |Added Flags||fedora-cvs? --- Comment #59 from Eugene A. Pivnev --- New Package SCM Request === Package Name: razorqt Short Description: Lightweight desktop toolbox Owners: tieugene Branches: f17 f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=53i60lali2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #58 from Eugene A. Pivnev --- (In reply to comment #57) Ok - will fix both things befor commiting to bodhi. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Gw2g3myuEb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #57 from Kevin Kofler ---
> http://kojipkgs.fedoraproject.org//work/tasks/2314/5332314/build.log
> /usr/share/razor/razor-config/razor-config-appearance...@latin.qm
> /usr/share/razor/razor-panel/razor-panel...@latin.qm
Well, it's a bug in %find_lang that it doesn't find those files. Just list them
manually, they're just 2 files:
%lang(sr) %{_datadir}/razor/razor-config/razor-config-appearance...@latin.qm
%lang(sr) %{_datadir}/razor/razor-panel/razor-panel...@latin.qm
(Use %lang(sr) to tag them.)
> I'd like to choose something one - "section > subpackage" or "package >
> section" order. In 2nd case I'm to put package > %description > %files
> (together). I prefere _strict_ "section > subpackage" order, sorry.
Almost all packages in Fedora use the ordering as in:
http://pkgs.fedoraproject.org/cgit/qt.git/tree/qt.spec
In other words:
Definition of the main package
%description
%package foo1
%description foo1
%package foo2
%description foo2
…
%package fooN
%description fooN
%prep
%build
%install
%check (if used)
%clean (if used)
%pre/%post/%preun/%postun/%posttrans (for the main package) as needed
%pre/%post/%preun/%postun/%posttrans foo1 as needed
%pre/%post/%preun/%postun/%posttrans foo2 as needed
…
%pre/%post/%preun/%postun/%posttrans fooN as needed
%files
%files foo1
%files foo2
…
%files fooN
%changelog
I see no valid reason to do this differently. It's much easier to read other
people's specfiles if they all use the agreed ordering.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=yTvMCA8DIL&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Brendan Jones changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #56 from Brendan Jones --- (In reply to comment #55) > (In reply to comment #51) > > * all of your sub-packages need to Require razorqt-data such that the > > license is always installed. > > Fixed. > Note #1: instead of adding -data to Requires I added licenses to libqxtdg > and -libs. According to dependency graph > (http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.svg or > http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.dot) any other > subpackage requires one/some/all of them. > Note #2: -xdg is not part of razorqt - it is just fixed version of xdg-utils > for EL6. Works for me. This package is APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DWqlhmyNGK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #55 from Eugene A. Pivnev --- (In reply to comment #51) > * all of your sub-packages need to Require razorqt-data such that the > license is always installed. Fixed. Note #1: instead of adding -data to Requires I added licenses to libqxtdg and -libs. According to dependency graph (http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.svg or http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.dot) any other subpackage requires one/some/all of them. Note #2: -xdg is not part of razorqt - it is just fixed version of xdg-utils for EL6. > * could clean up your change log and commetns. Use %% where appropriate and > you've got some double hyphenating Fixed. > I'm used to seeing the %description right after the %package declaration but > thats a matter of style. I'd like to choose something one - "section > subpackage" or "package > section" order. In 2nd case I'm to put package > %description > %files (together). I prefere _strict_ "section > subpackage" order, sorry. > Fix the license requires and I'll approve. Good job Whew... Thank you very much. Koji builds (dist-6E-epel, f17..rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=5332318 http://koji.fedoraproject.org/koji/taskinfo?taskID=5332332 http://koji.fedoraproject.org/koji/taskinfo?taskID=5332337 http://koji.fedoraproject.org/koji/taskinfo?taskID=5332360 http://koji.fedoraproject.org/koji/taskinfo?taskID=5332365 Spec URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.spec SRPM URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt-0.5.2-7.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7Kp5mEcpfW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #54 from Eugene A. Pivnev --- (In reply to comment #20) > You MUST use %find_lang to handle locales if possible. http://kojipkgs.fedoraproject.org//work/tasks/2314/5332314/build.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wRvspqZfL0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #53 from Eugene A. Pivnev --- Hm... I tried in my own host - packages with lang files are installing ok. Seems that fedora-review has bugs. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jwCBzFVEO8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #52 from Eugene A. Pivnev --- (In reply to comment #51) > OK, this scratch builds OK, so I'm not going to worry about th install log > in fedora-review Koji just builds packages but not tries to install them. Not? So - what final resume will be: to use lang files - or not? I propose to leave _prepared_ spec - but not use them. Untill fedora-review will be ok. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SNtZNoLEMV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #51 from Brendan Jones ---
OK, this scratch builds OK, so I'm not going to worry about th install log in
fedora-review
Just two things:
* all of your sub-packages need to Require razorqt-data such that the license
is always installed.
* could clean up your change log and commetns. Use %% where appropriate and
you've got some double hyphenating
I'm used to seeing the %description right after the %package declaration but
thats a matter of style.
You could also consider using an epoch to trump the razorqt repo, but thats
entirely up to you.
Fix the license requires and I'll approve. Good job
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
Make sure macros are escaped with %% and you have some double hypenating going
on
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libqtxdg ,
libqtxdg-devel , razorqt-devel , razorqt-data , razorqt-about , razorqt-
appswitcher , lightdm-razorqt , razorqt-theme-amego , razorqt-theme-
ambiance , razorqt-theme-green , razorqt-theme-light , razorqt-themes
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL", "LGPL (v2 or later)", "Unknown or generated", "*No copyright*
WTFPL WTFPL (v2)", "LGPL (v2.1 or later)", "GPL (v3)", "GPL (v2)". 7
files have unknown license. Detailed output of licensecheck in
/home/bsjones/review-razorqt/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked when required
Note: desktop file(s) in razorqt-about, razorqt-appswitcher, lightdm-
razorqt
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 112640 bytes in 13 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Pa
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #50 from Eugene A. Pivnev --- Ok. * This is srpm with generated but not included lang files: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt-0.5.2-5.fc18.src.rpm * This is the same but runner includes lang: http://tieugene.fedorapeople.org/rpms/razorqt.runner/razorqt-0.5.2-6.fc18.src.rpm * This is all lang files included: http://tieugene.fedorapeople.org/rpms/razorqt.lang/razorqt-0.5.2-6.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GataBJYzb0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #49 from Brendan Jones --- Please just post a link to your complete SRPM. Do the same with all the other file sections as you have done with runner and I'll look at it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9wjUhKeSvv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #48 from Eugene A. Pivnev --- (In reply to comment #46) > (In reply to comment #45) > > Hi Eugene can you please post your latest SRPM > > Including %files x -f x.lang etc and I'll have a look http://tieugene.fedorapeople.org/rpms/razorqt/ - latest reviewable release (5). Testing release (with included langs): http://tieugene.fedorapeople.org/rpms/razorqt.lang/ - release 6 (something like "not published"). Patch in comment #43 appliable to release 5. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4u37jE6NPz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #47 from Brendan Jones --- (In reply to comment #43) > > Result: > > Error: Package: razorqt-0.5.2-5.fc18.i686 (/razorqt-0.5.2-5.fc18.i686) > Requires: razorqt-runner = 0.5.2-5.fc18 I'm not seeing this with your test. How are yu installign it? Is this simply an issue with fedora-review ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WHwZA9mh9E&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #46 from Brendan Jones --- (In reply to comment #45) > Hi Eugene can you please post your latest SRPM Including %files x -f x.lang etc and I'll have a look -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rFiXu4aRSk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #45 from Brendan Jones --- Hi Eugene can you please post your latest SRPM -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nk3CCMUcoy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #44 from Eugene A. Pivnev --- Show must go on (c) F. Mercury. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LLr6PiIUlN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #43 from Eugene A. Pivnev ---
(In reply to comment #41)
> Then you can use:
> %files autosuspend -f razor-autosuspend.lang
> and everything will work fine.
Trivial test (for http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.spec):
--- razorqt.spec.orig2013-04-28 14:09:01.752525655 +0400
+++ razorqt.spec2013-04-28 15:11:08.544630933 +0400
@@ -522,9 +522,9 @@
%{_datadir}/razor/razor-power/
%{_datadir}/applications/razor-power.desktop
-%files runner
+%files runner -f razor-runner.lang
%{_bindir}/razor-runner
-%{_datadir}/razor/razor-runner/
+%dir %{_datadir}/razor/razor-runner/
%{_sysconfdir}/xdg/autostart/razor-runner.desktop
%files session
Result:
Error: Package: razorqt-0.5.2-5.fc18.i686 (/razorqt-0.5.2-5.fc18.i686)
Requires: razorqt-runner = 0.5.2-5.fc18
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=BfFvjvEjMJ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #42 from Eugene A. Pivnev ---
(In reply to comment #41)
> Brendan:
> > No translations found for --with-qt in
> > /home/bsjones/rpmbuild/BUILDROOT/razorqt-0.5.2-4.fc18.x86_64
>
> Your %find_lang syntax is wrong, the order of the parameters matters.
> Try:
> %find_lang razorqt --with-qt --without-mo
You tested too old sources.
http://tieugene.fedorapeople.org/rpms/razorqt.lang/razorqt-0.5.2-6.spec :
for i in `cat %{SOURCE1}`; do %find_lang $i --with-qt --without-mo; done
> > %files autosuspend -f razor-autosuspend.lang -f
> > razor-config-autosuspend.lang
> This is not going to work, you can use only one -f file.
1. As for
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Handling_Locale_Files
:
%files -f %{name}.lang -f bar.lang
2. Anyway - I tried to add lang to lib subpackage:
%fileslibs -f librazorqt.lang
And no one can find this library.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=qLM1bP8lzb&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #41 from Kevin Kofler --- Brendan: > No translations found for --with-qt in > /home/bsjones/rpmbuild/BUILDROOT/razorqt-0.5.2-4.fc18.x86_64 Your %find_lang syntax is wrong, the order of the parameters matters. Try: %find_lang razorqt --with-qt --without-mo Eugene: > %files autosuspend -f razor-autosuspend.lang -f razor-config-autosuspend.lang This is not going to work, you can use only one -f file. So you need to do this after calling %find_lang: cat razor-config-autosuspend.lang >>razor-autosuspend.lang Then you can use: %files autosuspend -f razor-autosuspend.lang and everything will work fine. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ebTdFZFJIG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #40 from Eugene A. Pivnev --- Some fixes, find_lang ready: Spec URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.spec SRPM URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt-0.5.2-5.fc18.src.rpm Note about find_lang: I tried some tens times - dependency error. You can try yourself: http://tieugene.fedorapeople.org/rpms/razorqt.lang/ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UBN6ADXn1I&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #39 from Eugene A. Pivnev ---
(In reply to comment #33)
> I'm pretty sure %find_lang is not going to find them and you will need to
> tag them as Kevin has suggested
I don't know why, but adding translations using lang-files break dependecies.
Like this:
= spec =
-%files autosuspend
+%files autosuspend -f razor-autosuspend.lang -f razor-config-autosuspend.lang
...
-%{_datadir}/razor/razor-autosuspend/
-%{_datadir}/razor/razor-config-autosuspend/
+%dir %{_datadir}/razor/razor-autosuspend/
+%dir %{_datadir}/razor/razor-config-autosuspend/
= fedora-review =
(manual translation to En)
...
Installation errors
---
...
Error: Package: razorqt-0.5.2-6.fc18.i686 (/razorqt-0.5.2-6.fc18.i686)
Requires: razorqt-autosuspend = 0.5.2-6.fc18
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=65hXeShcFb&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #38 from Eugene A. Pivnev --- (In reply to comment #37) > No translations found for --with-qt in > /home/bsjones/rpmbuild/BUILDROOT/razorqt-0.5.2-4.fc18.x86_64 > error: Bad exit status from /var/tmp/rpm-tmp.q04v0G (%install) > > > RPM build errors: > Bad exit status from /var/tmp/rpm-tmp.q04v0G (%install) Sorry - razorqt -5 not ready yet. Try this: http://tieugene.fedorapeople.org/rpms/qxkb/ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yAnOpFgPVK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #37 from Brendan Jones --- No translations found for --with-qt in /home/bsjones/rpmbuild/BUILDROOT/razorqt-0.5.2-4.fc18.x86_64 error: Bad exit status from /var/tmp/rpm-tmp.q04v0G (%install) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.q04v0G (%install) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ouQRGMmjNq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #36 from Eugene A. Pivnev --- (In reply to comment #35) > I tried it and it didn't work for me here. What I am to do to repeate "didn't work"? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1EDEBMccDw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #35 from Brendan Jones --- I tried it and it didn't work for me here. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5a2V6ZYbfG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #34 from Eugene A. Pivnev --- (In reply to comment #33) > I'm pretty sure %find_lang is not going to find them and you will need to > tag them as Kevin has suggested Maybe - I read him inattentively: "You MUST use %find_lang to handle locales if possible. And if it is not possible, you MUST tag every single .qm (and/or .mo etc.) file with a %lang tag for the appropriate language, e.g.: %lang(de) /path/to/de.qm But in this case, %find_lang should work fine, so there is no need to do it manually." In this case - fine - no need manually. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gfacchiOtW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #33 from Brendan Jones ---
(In reply to comment #32)
> (In reply to comment #31)
> > Its quite significant actually because I imagine you will need to tag all of
> > these files within each sub-package.
> >
> > The rest looks pretty good. I personally am looking forward to the a future
> > Fedora Audio spin based on razor rather than KDE
>
> Ok - I'll prepare and upload new (final?) pre-applying package release
> tomorrow today (now is MSK 00:22):
> - xdg-utils workaround back (for rhel) in separate subpakage;
> - find_lang;
>
> as for simple project - find_lang approving looks like this:
> %install
> +%find_lang %{name} --with-qt
> ...
> -%files
> +%files -f %{name}.lang
I'm pretty sure %find_lang is not going to find them and you will need to tag
them as Kevin has suggested
>
> PS. you can start Fedora Turbo Audio spin here:
> http://qtdesktop.googlecode.com/svn/trunk/spins/
Cool! Its probably a bit late for this release but count me in for the next
one. Consider joining the music_creation group if interested
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=iVKGqcBqvQ&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #32 from Eugene A. Pivnev ---
(In reply to comment #31)
> Its quite significant actually because I imagine you will need to tag all of
> these files within each sub-package.
>
> The rest looks pretty good. I personally am looking forward to the a future
> Fedora Audio spin based on razor rather than KDE
Ok - I'll prepare and upload new (final?) pre-applying package release tomorrow
today (now is MSK 00:22):
- xdg-utils workaround back (for rhel) in separate subpakage;
- find_lang;
as for simple project - find_lang approving looks like this:
%install
+%find_lang %{name} --with-qt
...
-%files
+%files -f %{name}.lang
...
-%{_datadir}/%{name}
+#{_datadir}/%{name}
+%dir %{_datadir}/%{name}
+%{_datadir}/%{name}/theme/
So - I am to exclude all of %_datadir/%name - but to include all of subfolders
_excluding_ translations.
PS. you can start Fedora Turbo Audio spin here:
http://qtdesktop.googlecode.com/svn/trunk/spins/
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=FIMFGoFEn3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #31 from Brendan Jones --- Its quite significant actually because I imagine you will need to tag all of these files within each sub-package. The rest looks pretty good. I personally am looking forward to the a future Fedora Audio spin based on razor rather than KDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=C5yVgOPcEB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #30 from Eugene A. Pivnev --- (In reply to comment #29) > You still have not tagged the locale files? Kevin stands me corrected on > this count. "Under construction" :-( If this is the only bug... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qOUDDghPeu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #29 from Brendan Jones --- You still have not tagged the locale files? Kevin stands me corrected on this count. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9iGyeKWdjS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #28 from Brendan Jones --- Patience Eugene -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YDs6dk6nm5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #27 from Eugene A. Pivnev --- (In reply to comment #13) > I'll take this review on. Just a few things before I get started: I'm sorry but... what can I do to speed up reviewing process? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LibJSVBmS8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #26 from Kevin Kofler --- Oh, and the current version of Mac OS does in fact have /usr/share. :-) (And I think QNX does too, and Android behind the scenes too, but I'm not sure about those.) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pavXQBGpDT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #25 from Kevin Kofler --- Keep in mind that crappy non-*nix OSes are completely irrelevant when it comes to the FHS. :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Yukbl4HZ65&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #24 from Eugene A. Pivnev ---
(In reply to comment #23)
> So I had written:
> > This is a very crappy and broken way to handle translations, but that's an
> > upstream issue.
>
> But actually, unfortunately, there doesn't seem to be any standard location
> for .qm files. To be honest, the real problem is Qt reinventing gettext in
> the first place… Most normal software including KDE software installs
> gettext .mo files to /usr/share/locale/$LANG/LC_MESSAGES/*.mo, but putting
> .qm files in there is probably not that great an idea anyway. And I see that
> most Qt-only stuff puts the translations somewhere under %{_datadir}/name.
> So I guess keep things the way they are. I think it would theoretically be
> better to have something under /use/share/locale (maybe
> /usr/share/locale/$LANG/QT_MESSAGES or something like that?), but if only
> one package uses that, it's not very helpful.
Keep in mind that:
* Windows has no /usr/share/...
* MacOS - has no...
* Symbian...
* QNX
* Android
* ...
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=mKXgSuSYpH&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #23 from Kevin Kofler ---
So I had written:
> This is a very crappy and broken way to handle translations, but that's an
> upstream issue.
But actually, unfortunately, there doesn't seem to be any standard location for
.qm files. To be honest, the real problem is Qt reinventing gettext in the
first place… Most normal software including KDE software installs gettext .mo
files to /usr/share/locale/$LANG/LC_MESSAGES/*.mo, but putting .qm files in
there is probably not that great an idea anyway. And I see that most Qt-only
stuff puts the translations somewhere under %{_datadir}/name. So I guess keep
things the way they are. I think it would theoretically be better to have
something under /use/share/locale (maybe /usr/share/locale/$LANG/QT_MESSAGES or
something like that?), but if only one package uses that, it's not very
helpful.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Eftte3bnAz&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #22 from Eugene A. Pivnev --- Package updated - -O3 solved. Spec URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.spec SRPM URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt-0.5.2-4.fc18.src.rpm As for me - there is no [critical] errors in it :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gclLPQqA0a&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #21 from Eugene A. Pivnev --- (In reply to comment #20) > All that YOU need to care about is using %find_lang so the > correct %lang metadata gets generated. Ok, I get - metadata are important. I will try to use find_lang and then will update all of my packages. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vlIKkGd3DA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #20 from Kevin Kofler ---
> Sorry - "You _can_ then use that file to include all of the locales".
You misunderstand the guidelines. You MUST use %find_lang to handle locales if
possible. And if it is not possible, you MUST tag every single .qm (and/or .mo
etc.) file with a %lang tag for the appropriate language, e.g.:
%lang(de) /path/to/de.qm
But in this case, %find_lang should work fine, so there is no need to do it
manually.
> All qms in all subpackages are installing with make_install to proper folders
> and I need no to do something special with them.
It's not a matter of where the files are installed, but how they're tagged for
RPM. Translations need to be tagged with the appropriate language so the RPM
feature of only installing translations for a subset of languages (useful for
very space-constrained environments) works.
> As they are not being stored in %{_datadir}/locale/ you are right.
Wrong. The location of the files does not matter. The language they're in does.
> As I found - preferred way for qt-aps developers - to put translations into
> _datadir/%{name}/{translations,l10n,i18n,locale,etc).
> This is easier for cross-platform applications.
This is a very crappy and broken way to handle translations, but that's an
upstream issue. All that YOU need to care about is using %find_lang so the
correct %lang metadata gets generated.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=THK0Q2dDDv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #19 from Eugene A. Pivnev ---
(In reply to comment #18)
> As they are not being stored in %{_datadir}/locale/ you are right.
No one.
As I found - preferred way for qt-aps developers - to put translations into
_datadir/%{name}/{translations,l10n,i18n,locale,etc).
This is easier for cross-platform applications.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=JrEXesdTym&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #18 from Brendan Jones ---
As they are not being stored in %{_datadir}/locale/ you are right.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=egzMAGgfwd&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #17 from Eugene A. Pivnev --- (In reply to comment #14) > For sub-packages that package .qm help files you will need to use the > %find_lang macro: > > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Handling_Locale_Files Sorry - "You _can_ then use that file to include all of the locales". All qms in all subpackages are installing with make_install to proper folders and I need no to do something special with them. IMO. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vb18DsuEia&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #16 from Eugene A. Pivnev --- (In reply to comment #14) > For sub-packages that package .qm help files you will need to use the > %find_lang macro: I am to make some "researches". Will be in next package release (-4). > Also some issues in rpmlint that can be handled (should the metapackage be > noarch? thus negating my previous comment) > razorqt.x86_64: E: no-binary Setting main package (=== meta-packages) in noarch make all subpackages noarch too. Same "error" is in wine metapackage. > razorqt-data.x86_64: W: only-non-binary-in-usr-lib Fixed - razorqt-data is noarch now and binaries removed. Note: that binaries was xdg-utils replacement. After hot discussion (https://groups.google.com/forum/?fromgroups#!topic/razor-qt/c_AFBYwJSM8) I desided to remove these utils from package. This means that razorqt will be ok in Fedora17+, but _can_ be not fine in EL6 (without fresh xdg-utils). Spec URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.spec SRPM URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt-0.5.2-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iExIV4oYyy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #15 from Eugene A. Pivnev --- (In reply to comment #13) > * Again, there are -O3 optimizations present in the build Seems that it is really %cmake macro bug/feature. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hkHsHQl9Kz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #13 from Brendan Jones --- I'll take this review on. Just a few things before I get started: * Consider https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package for your arch specific sub-packages * Again, there are -O3 optimizations present in the build -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=70oy6H8Cec&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #14 from Brendan Jones --- For sub-packages that package .qm help files you will need to use the %find_lang macro: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Handling_Locale_Files Also some issues in rpmlint that can be handled (should the metapackage be noarch? thus negating my previous comment) razorqt.x86_64: E: no-binary and razorqt-data.x86_64: W: only-non-binary-in-usr-lib -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tEsBxQSc2T&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Brendan Jones changed: What|Removed |Added CC||brendan.jones...@gmail.com Assignee|nob...@fedoraproject.org|brendan.jones...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LI5EuiNlTO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #12 from Christopher Meng --- (In reply to comment #11) OK. Let's talk in pivate later. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2qUVSJwVIP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #11 from Eugene A. Pivnev --- (In reply to comment #10) > I think this is feature name cover a lot of things listed here: > http://www.qtdesktop.org/applist > Right? Yes. > If so, I think bring so many packages into Fedora can be a feature, and of > course this is a feature, just talk about razor-qt, it's a desktop > environment, after porting this into Fedora we can also make spins...or > whatever. QtDesktop contains a lot of tools and of course many of them is > not in Fedora, I've done search via pkgs.org. Main idea was to add new environment to main distros. And application set unified as for Windows as for MacOS as for Linux. Then - it must be not-gtk and not-kde. OBS repo was created for this task - to push qt apps into rpm-based distros. Only thing that was absent - pure qt WM. After razorqt appears QtDesktop is all-sufficient. Next stage was to push packages from OBS to Fedora and OpenSUSE (as OBS repo is comaintained by Petr Vanek (razorqt leading developer and OpenSUSE user) and me (not developer and RH-based user)). But all of these are not subject of this (953101) bug. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zdIFoCj19N&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #10 from Christopher Meng --- (In reply to comment #9) > I never used fedora wiki. I think this is feature name cover a lot of things listed here: http://www.qtdesktop.org/applist Right? If so, I think bring so many packages into Fedora can be a feature, and of course this is a feature, just talk about razor-qt, it's a desktop environment, after porting this into Fedora we can also make spins...or whatever. QtDesktop contains a lot of tools and of course many of them is not in Fedora, I've done search via pkgs.org. > After 4 years of maintaining in OBS. I know of course~ In fact I'm using your spec as my source yesterday. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nR70tgVnB1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #9 from Eugene A. Pivnev --- (In reply to comment #8) > DONE. http://fedoraproject.org/wiki/Features/QtDesktop Thank you. > And please add your name here. This page still need modification. Where? Into "Owner"? I never used fedora wiki. > In fact I tried to package it yesterday...But now you've done what I tried to > do. I spent two weeks to prepare razorqt for fedora review. After 4 years of maintaining in OBS. It is not so trivial :-) > I will comaintain this when available. Thank #2. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yraX9TMKVn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #8 from Christopher Meng --- (In reply to comment #7) > (In reply to comment #6) > > Oh > > > > I just wrote a feature page for this, anything can I help here? > > To review :-) > > I think - to rename Razor-qt wiki into QtDesktop will be better. > Because razorqt is not real DE (as KDE or GNOME) - it is "desktop toolbox". > But "QtDesktop" environment is collection of qt-based applications. With > RazorQt ahead, yes. DONE. http://fedoraproject.org/wiki/Features/QtDesktop And please add your name here. This page still need modification. In fact I tried to package it yesterday...But now you've done what I tried to do. I will comaintain this when available. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7AATXroYHd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #7 from Eugene A. Pivnev --- (In reply to comment #6) > Oh > > I just wrote a feature page for this, anything can I help here? To review :-) I think - to rename Razor-qt wiki into QtDesktop will be better. Because razorqt is not real DE (as KDE or GNOME) - it is "desktop toolbox". But "QtDesktop" environment is collection of qt-based applications. With RazorQt ahead, yes. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uia6dkFRYZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Christopher Meng changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #6 from Christopher Meng --- Oh I just wrote a feature page for this, anything can I help here? http://fedoraproject.org/wiki/Features/Razor-qt -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PQGFlRgSUj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #5 from Eugene A. Pivnev ---
Release 2 - total cleanup.
I think - this package is ready for real review.
Spec URL: http://tieugene.fedorapeople.org/rpms/razorqt/razorqt.spec
SRPM URL:
http://tieugene.fedorapeople.org/rpms/razorqt/razorqt-0.5.2-2.fc18.src.rpm
Koji (dist-6E-epel f17 f18 f19 rawhide):
http://koji.fedoraproject.org/koji/taskinfo?taskID=5284369
http://koji.fedoraproject.org/koji/taskinfo?taskID=5284392
http://koji.fedoraproject.org/koji/taskinfo?taskID=5284405
http://koji.fedoraproject.org/koji/taskinfo?taskID=5284420
http://koji.fedoraproject.org/koji/taskinfo?taskID=5284430
fedora-review result:
http://tieugene.fedorapeople.org/rpms/razorqt/razorqt_review-0.5.2-2.txt
= Explanations =
* "Package installs a %{name}.desktop using desktop-file-install if there is
such a file."
There is no %{name}.desktop. Other *.desktops are installing with "make".
* "Large data in /usr/share should live in a noarch subpackage if package is
arched."
Most of them are translations. razorqt-data can be noarch but contents
executable /usr/lib/razor-xdg-tools/*.
* "W: no-documentation", "W: no-manual-page-for-binary"
I know.
* "W: spelling-error", "W: non-conffile-in-etc /etc/xdg/autostart/", "W:
devel-file-in-non-devel-package /usr/bin/razor-config"
rpmlint is wrong.
* "razorqt.i686: E: no-binary"
I don't know how to solve this. Same error is producing for "wine" meta
package.
* "razorqt-data.i686: W: only-non-binary-in-usr-lib"
These are patched xdg bash scripts - "it will be removed when it becomes part
of upstream".
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=o2wKPYJkS0&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 --- Comment #4 from Mario Blättermann --- (In reply to comment #1) > a general comment about many of the subpackages here... I personally would > drop many of the subpackages as I can't imagine many users wanting only > parts of razorqt. Having the main metapackage helps though. Could you > describe the justifications and/or use-case for the fine-grained splitting? > (I have an idea what you may say, but it will be nice to document it here > for posterity anyway). (In reply to comment #2) > 1. End-user will just install "razorqt" meta-package. All-inclusive. > 2. But you can tune package set for your machine. E.g. - minimal razorqt set > - http://qtdesktop.googlecode.com/svn/trunk/spins/F17_QDE-min-0.5.ks I agree. Most of the razor-qt parts are usable standalone. We shouldn't force users to install the whole razor-qt stuff if they just want to use one of the modules in a different environment. They might want to use the app launcher to replace the ugly one in Fluxbox, for example. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DXgA5nuuYU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #3 from Eugene A. Pivnev ---
(In reply to comment #1)
> 1. in fedora at least, you can omit:
> %dir %{_datadir}/apps/
I check live (working) EL6 (CentOS6) - seems that it uses _datadir/xsessions/
too.
So - my current todo for razorqt:
http://tieugene.fedorapeople.org/rpms/razorqt/razorqt_todo.txt
Any additional comments?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=fkQ3krxLz2&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #2 from Eugene A. Pivnev ---
(In reply to comment #1)
> 1. in fedora at least, you can omit:
> %dir %{_datadir}/apps/
> %dir %{_datadir}/apps/kdm/
> %dir %{_datadir}/apps/kdm/sessions/
> %{_datadir}/apps/kdm/sessions/razor*.desktop
I'm aimed to EL6+ and f17..rawhide.
> kdm is configured to use /usr/share/xsessions exclusively in fedora (and
> besides, fedora's kde4 uses a /usr/share/kde4/apps prefix instead of
> /usr/share/apps)
I can 1) move files using spec, 2) patch cmakefiles, 3) to bother upstream.
What would be the best option?
> 2. -autosuspend subpkg includes icons, but there are no icon scriptlets
Will be fixed.
Current todolist:
http://tieugene.fedorapeople.org/rpms/razorqt/razorqt_todo.txt
> a general comment about many of the subpackages here... I personally would
> drop many of the subpackages as I can't imagine many users wanting only
> parts of razorqt. Having the main metapackage helps though. Could you
> describe the justifications and/or use-case for the fine-grained splitting?
> (I have an idea what you may say, but it will be nice to document it here
> for posterity anyway).
No problem.
1. End-user will just install "razorqt" meta-package. All-inclusive.
2. But you can tune package set for your machine. E.g. - minimal razorqt set -
http://qtdesktop.googlecode.com/svn/trunk/spins/F17_QDE-min-0.5.ks
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=WAw7AmF61T&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953101
--- Comment #1 from Rex Dieter ---
Some initial comments:
1. in fedora at least, you can omit:
%dir %{_datadir}/apps/
%dir %{_datadir}/apps/kdm/
%dir %{_datadir}/apps/kdm/sessions/
%{_datadir}/apps/kdm/sessions/razor*.desktop
kdm is configured to use /usr/share/xsessions exclusively in fedora (and
besides, fedora's kde4 uses a /usr/share/kde4/apps prefix instead of
/usr/share/apps)
2. -autosuspend subpkg includes icons, but there are no icon scriptlets
a general comment about many of the subpackages here... I personally would drop
many of the subpackages as I can't imagine many users wanting only parts of
razorqt. Having the main metapackage helps though. Could you describe the
justifications and/or use-case for the fine-grained splitting? (I have an idea
what you may say, but it will be nice to document it here for posterity
anyway).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=vYWx7e9uWl&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Alias||razorqt -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pUiufTRTsX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953101] Review Request: razorqt - Lightweight desktop toolbox
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953101 Eugene A. Pivnev changed: What|Removed |Added Blocks||928937 (qt-reviews) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DMIXKNDjgR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
