[Bug 953514] Review Request: vmod-querystring - QueryString VMOD for Varnish
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953514 --- Comment #5 from Dridi Boukelmoune dridi.boukelmo...@gmail.com --- As requested, the build is no more conditional, and I've renamed the package to varnish-vmod-querystring (and incidentally removed varnish's version in the release tag). Spec and source RPM: http://dl.bintray.com/dridi/sources/varnish-vmod-querystring/0.2.5c5dc14/ I've also added missing build dependencies (namely autoconf, automake and libtool) and now it builds with mock :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NmhChUjgLLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953514] Review Request: vmod-querystring - QueryString VMOD for Varnish
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953514 --- Comment #3 from Kevin Fenzi ke...@scrye.com --- Is varnish-libs-devel what you need? Or something more? If it's something more, you should consult with the varnish maintainer(s) and ask for them to expose the functions you need. Bundling varnish is not possible in a Fedora package. Yes, you would then need to rebuild this package anytime varnish updated. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BhPm1oXHnMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953514] Review Request: vmod-querystring - QueryString VMOD for Varnish
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953514 --- Comment #4 from Dridi Boukelmoune dridi.boukelmo...@gmail.com --- I hope this will answer your questions. I still have to provide a new spec and source rpm for review. (In reply to comment #3) Is varnish-libs-devel what you need? It seems that varnish-libs-devel only contains what's usually needed to use a shared object (specifically libvarnishapi for this package). Or something more? It is definitely something more, as of today, if you want to build any vmod that I've heard of, you need a varnish build: - the source tree contains vmod build scripts - tests need varnishtest and varnishd (built from the source) If it's something more, you should consult with the varnish maintainer(s) and ask for them to expose the functions you need. It would require a change in the upstream (varnish) build system in order to install and then package what's needed (this can be solved with a patch of course). It would also require changes in the vmod build. I'll wait for your answer before asking the varnish maintainer(s). Bundling varnish is not possible in a Fedora package. I am not sure I understand this one. I don't package (if that's what you mean with bundling) varnish with the module, it is just an additional upstream required at buildtime. On my laptop, the resulting package contains: $ rpm -ql vmod-querystring /usr/lib64/varnish/vmods/libvmod_querystring.so /usr/share/doc/vmod-querystring-0.2 /usr/share/doc/vmod-querystring-0.2/CONTRIBUTORS /usr/share/doc/vmod-querystring-0.2/LICENSE /usr/share/man/man3/vmod_querystring.3.gz -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PppNExvEGra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953514] Review Request: vmod-querystring - QueryString VMOD for Varnish
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953514 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added CC||ke...@scrye.com --- Comment #1 from Kevin Fenzi ke...@scrye.com --- So, some general comments. ;) - Usually when we package extensions or plugins for a package they have the base package name in the name of the extension or plugin. So, you might consider renaming this: varnish-extension-querystring or varnish-vmod-querystring? - You cannot do conditional builds like that in the Fedora buildsystem. I'd suggest doing a 'BuildRequires: varnish-exact-version' and set it to that version. Then, when varnish is updated, you update that to the new version and rebuild. - This needs patches to varnish? Have you opened a bug to get the Fedora varnish maintainer(s) feedback on applying those? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KVNRSLGxQFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953514] Review Request: vmod-querystring - QueryString VMOD for Varnish
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953514 --- Comment #2 from Dridi Boukelmoune dridi.boukelmo...@gmail.com --- (In reply to comment #1) So, some general comments. ;) Thank you for your answer, I'll provide new spec and source rpm asap. But first I can answer your questions. - Usually when we package extensions or plugins for a package they have the base package name in the name of the extension or plugin. So, you might consider renaming this: varnish-extension-querystring or varnish-vmod-querystring? I see the point, and varnish-vmod-querystring sounds better (and more community-ish) to me, I'll use that. - You cannot do conditional builds like that in the Fedora buildsystem. I'd suggest doing a 'BuildRequires: varnish-exact-version' and set it to that version. Then, when varnish is updated, you update that to the new version and rebuild. Ok then it would be my responsibility to follow varnish's releases and make the vmod stay in sync ? Also, the varnish package is not useful at build time, unless there's a devel package I've missed with all the bits needed by vmods. This is the reason why I also build varnish from the source. - This needs patches to varnish? Have you opened a bug to get the Fedora varnish maintainer(s) feedback on applying those? No I have not, I've discovered a segfault issue when I started building the vmod against different versions of varnish on different archs. Since at the time I opened this issue only varnish 3.0.3 was available in the repo, I took the patches from the source RPM for Fedora 18. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UzCR6wdck3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953514] Review Request: vmod-querystring - QueryString VMOD for Varnish
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953514 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BVmbbOCaJLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953514] Review Request: vmod-querystring - QueryString VMOD for Varnish
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953514 Dridi Boukelmoune dridi.boukelmo...@gmail.com changed: What|Removed |Added URL||https://www.varnish-cache.o ||rg/vmod/querystring CC||dridi.boukelmo...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LgGmylokJ4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
