[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
https://bugzilla.redhat.com/show_bug.cgi?id=953885 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-05-24 16:37:23 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- vim-jedi-0.5.0-5.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q3EBDXxDZpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 Petr Hracek phra...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Petr Hracek phra...@redhat.com --- New Package SCM Request === Package Name: vim-jedi Short Description: Python autocompletion plugin for VIM Owners: phracek Branches: f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NKmaydIyiCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1YFSGbtYD3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3wkwSb0C54a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 Petr Hracek phra...@redhat.com changed: What|Removed |Added Status|ASSIGNED|MODIFIED Fixed In Version||vim-jedi-0.5.0-5.fc19 Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #13 from Petr Hracek phra...@redhat.com --- scm-commit (http://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130506/1016210.html) - MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vfTN2SutJ9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- vim-jedi-0.5.0-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/vim-jedi-0.5.0-5.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R66Ug0QZCVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Clearing flag. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AvcBruQTeea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IAlvMhyTsRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- vim-jedi-0.5.0-5.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P6qeVsP1kca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 Robert Kuska rku...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #10 from Robert Kuska rku...@redhat.com --- Looks good now. Approving. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5JxOyqN83ja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=953885
--- Comment #8 from Robert Kuska rku...@redhat.com ---
- you forgot to delete BuildRoot:
- also please unify macro using, in install section use
%{buildroot}%{vimfiles_root} instead of $RPM_BUILD_ROOT/%{vimfiles_root}
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Y4LyurFfsWa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 --- Comment #9 from Petr Hracek phra...@redhat.com --- Macro's are unify. BuildRoot field is deleted Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-5.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L3vt6ZKFCVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 --- Comment #7 from Petr Hracek phra...@redhat.com --- Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-4.fc18.src.rpm Corrected License field. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i1OvO6WlBia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 --- Comment #3 from Petr Hracek phra...@redhat.com --- Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-2.fc18.src.rpm Correction: - Files are stored in vimfiles directory - Requires: vim-common - post and postun sections - Corrected version which is the same as on git. phracek@kiasportyw: ~/work/jedi-vim (master %)$ rpmlint /home/phracek/rpmbuild/SRPMS/vim-jedi-0.5.0-2.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. phracek@kiasportyw: ~/work/jedi-vim (master %)$ --- Comment #4 from Petr Hracek phra...@redhat.com --- Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-2.fc18.src.rpm Correction: - Files are stored in vimfiles directory - Requires: vim-common - post and postun sections - Corrected version which is the same as on git. phracek@kiasportyw: ~/work/jedi-vim (master %)$ rpmlint /home/phracek/rpmbuild/SRPMS/vim-jedi-0.5.0-2.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. phracek@kiasportyw: ~/work/jedi-vim (master %)$ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UIli9XyZRAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 --- Comment #3 from Petr Hracek phra...@redhat.com --- Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-2.fc18.src.rpm Correction: - Files are stored in vimfiles directory - Requires: vim-common - post and postun sections - Corrected version which is the same as on git. phracek@kiasportyw: ~/work/jedi-vim (master %)$ rpmlint /home/phracek/rpmbuild/SRPMS/vim-jedi-0.5.0-2.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. phracek@kiasportyw: ~/work/jedi-vim (master %)$ --- Comment #4 from Petr Hracek phra...@redhat.com --- Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-2.fc18.src.rpm Correction: - Files are stored in vimfiles directory - Requires: vim-common - post and postun sections - Corrected version which is the same as on git. phracek@kiasportyw: ~/work/jedi-vim (master %)$ rpmlint /home/phracek/rpmbuild/SRPMS/vim-jedi-0.5.0-2.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. phracek@kiasportyw: ~/work/jedi-vim (master %)$ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JtRcGKyicCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 Robert Kuska rku...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? --- Comment #5 from Robert Kuska rku...@redhat.com --- Few things to improve - I found out better SourceURL [1], 0.5.0 is better than master IMO - You are missing upstream docs (README.rst, LICENSE.txt, AUTHORS.txt) in files section - Post and postun section are not needed since there are no txt file to generate tags from for vim-jedi - IMO you should delete Buildroot, Clean and rm -rf $RPM_BUILD_ROOT if you are not packaging for EPEL they are not needed in Fedora (more info [2]) - There is unused command pwd in install section [1] https://github.com/davidhalter/jedi-vim/tarball/0.5.0 [2] https://fedoraproject.org/wiki/How_to_create_an_RPM_package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RhhZp72cwDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 --- Comment #6 from Petr Hracek phra...@redhat.com --- Spec URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-0.5.0-3.fc18.src.rpm Correction were corrected and changelog were updated as well. phracek@kiasportyw: ~/work/jedi-vim (master %)$ rpmlint vim-jedi.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. phracek@kiasportyw: ~/work/jedi-vim (master %)$ rpmlint /home/phracek/rpmbuild/SRPMS/vim-jedi-0.5.0-3.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. phracek@kiasportyw: ~/work/jedi-vim (master %)$ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6jKoWqKrmJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 --- Comment #1 from Robert Kuska rku...@redhat.com --- - According [1] you should avoid using Epoch - You are missing BuildArch [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Use_of_Epochs -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NoBXkOFz1Xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 --- Comment #2 from Petr Hracek phra...@redhat.com --- New SRPM URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi-7.3-2.fc18.src.rpm New SPEC URL: http://phracek.fedorapeople.org/vim-jedi/vim-jedi.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rG1XClXkYva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 953885] Review Request: vim-jedi - awesome Python autocompletion with VIM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=953885 Petr Hracek phra...@redhat.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|rku...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lqzpV0sFjaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
