[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7z6cXPodKXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LnuHaLex8oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p5bok1FfYxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z5A9yR1s24a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AoOEDvTasoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-26 23:16:19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4qeb5E9jZta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 Petr Šabata psab...@redhat.com changed: What|Removed |Added CC||psab...@redhat.com --- Comment #4 from Petr Šabata psab...@redhat.com --- Just my two cents: - As far as I know, not even el5 requires %defattr, so that's okay - There's no need to BR perl(Net::XMPP) and perl(Getopt::Long) in this package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wt2Mct0qoFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Unretired, take ownership and submit package change request for EL branches. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bLbdeuFY5na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1x5DPjxpcCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Robert Scheck red...@linuxnetz.de --- Jon, thank you - also for the pointer. And here we go: Package Change Request == Package Name: sendxmpp New Branches: el5 el6 Owners: robert InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9U5yduNPeba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DdE4hozrs1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CWuJowVYiEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CZbFKnIxMta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.el5 has been pushed to the Fedora EPEL 5 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NzzjQWtY9ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QAvcEH1F7za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/sendxmpp-1.23-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A2EDDtJJsZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/sendxmpp-1.23-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z8wyQce2b7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/sendxmpp-1.23-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SM8bILL4QDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/sendxmpp-1.23-1.el6 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/sendxmpp-1.23-1.el5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zr8H9g4EVra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- sendxmpp-1.23-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/sendxmpp-1.23-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CldzzgRX00a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=954100
Fabian Affolter m...@fabian-affolter.ch changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||m...@fabian-affolter.ch
Flags||fedora-review+
--- Comment #2 from Fabian Affolter m...@fabian-affolter.ch ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[!]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[x]: Buildroot is not present
Note: Buildroot: present but not needed
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
= EXTRA items =
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
---
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Robert Scheck red...@linuxnetz.de --- Thank you very much for the package review! New Package SCM Request === Package Name: sendxmpp Short Description: A Perl script to send XMPP messages Owners: robert Branches: el5 el6 f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c97nE7IAtta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ypq9JfyDV3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954100] Review Request: sendxmpp - A Perl script to send XMPP messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954100 --- Comment #1 from Robert Scheck redhat-bugzi...@linuxnetz.de --- Please note that this is a re-review as the existing package was orphaned. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zo8WqVUvUEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
