[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-12-21 03:03:38 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #39 from Fedora Update System upda...@fedoraproject.org --- gimp-gap-2.7.0-8.GITe75bd46.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #38 from Mario Blättermann mario.blaetterm...@gmail.com --- Except the el6 one, all the other packages are marked as stable, so this ticket is ON_QA. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #37 from Fedora Update System upda...@fedoraproject.org --- gimp-gap-2.7.0-8.GITe75bd46.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #36 from Fedora Update System upda...@fedoraproject.org --- gimp-gap-2.7.0-8.GITe75bd46.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #33 from Fedora Update System upda...@fedoraproject.org --- gimp-gap-2.7.0-8.GITe75bd46.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/gimp-gap-2.7.0-8.GITe75bd46.el6 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #34 from Fedora Update System upda...@fedoraproject.org --- gimp-gap-2.7.0-8.GITe75bd46.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/gimp-gap-2.7.0-8.GITe75bd46.fc19 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #35 from Fedora Update System upda...@fedoraproject.org --- gimp-gap-2.7.0-8.GITe75bd46.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/gimp-gap-2.7.0-8.GITe75bd46.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #28 from Mario Blättermann mario.blaetterm...@gmail.com --- rpmlint output, omitting the wrong FSF address errors: gimp-gap.i686: W: file-not-utf8 /usr/share/doc/gimp-gap-2.7.0/ChangeLog gimp-gap.src: W: invalid-url Source0: gimp-gap-e75bd46.tar.xz gimp-gap.x86_64: E: incorrect-fsf-address /usr/share/gimp/2.0/scripts/gap-dup-continue.scm gimp-gap.x86_64: W: file-not-utf8 /usr/share/doc/gimp-gap-2.7.0/ChangeLog gimp-gap-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_mov_exec.c gimp-gap-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_story_att_trans_dlg.c gimp-gap-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_story_undo_types.h gimp-gap-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_story_undo.h gimp-gap-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_story_undo.c gimp-gap-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_mov_xml_par.c gimp-gap-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_story_main.h gimp-gap-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_mov_exec.c gimp-gap-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_mov_dialog.c gimp-gap-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_story_att_trans_dlg.c gimp-gap-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_story_undo_types.h gimp-gap-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_story_undo.h gimp-gap-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_story_undo.c gimp-gap-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gimp-gap/gap/gap_mov_xml_par.c gimp-gap.spec: W: invalid-url Source0: gimp-gap-e75bd46.tar.xz 6 packages and 1 specfiles checked; 286 errors, 25 warnings. There are a few source files where the executable bit is set. Please remove them. Besides that, convert the Changelog file to UTF-8. For the wrong FSF addresses contact upstream. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #29 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- Incorrect FSF address issue filled: https://bugzilla.gnome.org/show_bug.cgi?id=711402 There still present rpmlint warning on debuginfo subpackage: gimp-gap-debuginfo.x86_64: E: non-standard-dir-perm /usr/src/debug/gimp-gap/gap/iter_ALT/gen 0775L despite my change directory permissions in %prep. But I think it is not serious issue to dig why it happened. File permissions and encoding addressed. Changes: https://github.com/Hubbitus/Fedora-packaging/commit/2fd7121a7a2a3b84789859b752fb3a6cb2034cd2 Spec: https://raw.github.com/Hubbitus/Fedora-packaging/2fd7121a7a2a3b84789859b752fb3a6cb2034cd2/SPECS/gimp-gap.spec Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6136258 Srpm: http://hubbitus.info/rpm/Fedora19/gimp-gap/gimp-gap-2.7.0-8.GITe75bd46.fc19.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #30 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #29)
Incorrect FSF address issue filled:
https://bugzilla.gnome.org/show_bug.cgi?id=711402
OK.
There still present rpmlint warning on debuginfo subpackage:
gimp-gap-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/gimp-gap/gap/iter_ALT/gen 0775L
despite my change directory permissions in %prep.
But I think it is not serious issue to dig why it happened.
I can see the invalid-url warnings only. OK, here we go:
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
20bfa0084f6a681169b7471639e33a04c7c3cefbcd553076c59d53d3f5a0a5ea
gimp-gap-115d5d9.tar.xz.orig
31f076cac22e2f8ade28e7203af9d4a94256d1b94702f2f73eac4909a7948495
gimp-gap-e75bd46.tar.xz
Of course, the checksums differ due to different commit numbers. Actually you
have to tweak the script so that it uses a certain commit. Don't bother, I
trust you and don't recognize it as a review blocker :)
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[+] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Flags||fedora-cvs? --- Comment #31 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- Mario thank you very much for the review. Would you like I also review some of you packages? New Package SCM Request === Package Name: gimp-gap Short Description: The GIMP Animation Package Owners: hubbitus Branches: F-19 F-20 EL-6 InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #32 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #25 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- Ready for review. Feel free to take. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2RyKljC1jla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 Luya Tshimbalanga l...@fedoraproject.org changed: What|Removed |Added CC||l...@fedoraproject.org Depends On||1000885 (DESIGN-SW) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yAUKSoFEsCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
https://bugzilla.redhat.com/show_bug.cgi?id=954108 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #24 from Christopher Meng cicku...@gmail.com --- Status? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=irRhG5vYB4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=954108
--- Comment #18 from Michael Schwendt mschwe...@gmail.com ---
Perhaps you can be convinced with this spec file patch then:
--- gimp-gap.spec.orig2013-04-30 11:48:37.0 +0200
+++ gimp-gap.spec2013-05-02 00:06:56.846396039 +0200
@@ -40,7 +40,6 @@
%prep
%setup -q -n %{name}
-%patch0 -p1 -b .automake-1.12
%patch1 -p1 -b .unbundle
# Bundled libs (list from SUSE)
@@ -50,7 +49,8 @@
%build
-./autogen.sh --disable-libavformat --libdir=%{_libdir}
CFLAGS=${CFLAGS:-%optflags} LDFLAGS=${LDFLAGS:-%__global_ldflags}
+autoreconf -i -f
+%configure --disable-libavformat
# Parralel build terminated with error
make LIBS=$LIBS -lm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=wawEZu6htaa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #19 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- What it is change really? Only omit some runtime versions requirement checks (I agree it may be some excessive as it listed in spec-file too, but it may be changed in future releases, so it good to have it from upstream too)? I'm not expert really and can't say if autoreconf -i -f do exactly the same things like call auto*-stuff, glib-gettextize, intltoolize with same arguments. If you think it is not and have issues, please be more specific on problems in autogen.sh script - we then need to report them upstream [1] instead of make workarounds. 1 https://fedoraproject.org/wiki/Staying_close_to_upstream_projects -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rajQ6Bt1Mea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #20 from Michael Schwendt mschwe...@gmail.com --- What it is change really? See rpm --eval %configure. Using %configure does a bit more than plain ./configure. For example, it adds and corrects some parameters, such as localedir, which is wrong with your spec file: DLOCALEDIR=\/usr/local/share/locale\ If you insist on using autogen.sh, at least patch it to not run configure automatically, so you can use %configure in the spec file. ;-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tIYdNxzb9Ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #21 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- As stated before on my mind it is not problem run it twice, but if you insist: Srpm: http://hubbitus.info/rpm/Fedora18/gimp-gap/gimp-gap-2.7.0-6.GITe75bd46.fc18.src.rpm Spec changes: https://github.com/Hubbitus/Fedora-packaging/commit/f744fc6d00e9c77dd673bb05d92f3ba66d0c163b -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RNYIuFRAbga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #22 from Michael Schwendt mschwe...@gmail.com --- Well, since configure scripts cache some values (some things automatically, some as implemented by the author), it can be problematic to re-run it with heavily changed options. Btw, gimp-gap-2.7.0-5.GITe75bd46.fc18.src.rpm did _not_ run %configure at all and therefore built with wrong parameters (comment 20). So, it's a good thing to fix that, and I hope you agree with that. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=da7E0oie9Na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #23 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- (In reply to comment #22) Btw, gimp-gap-2.7.0-5.GITe75bd46.fc18.src.rpm did _not_ run %configure at all and therefore built with wrong parameters (comment 20). So, it's a good thing to fix that, and I hope you agree with that. Yes, it was changed early. See comment 9. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2hgHDdBaUra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #14 from Michael Schwendt mschwe...@gmail.com --- * I strongly recommend running autoreconf -f in the gimp-gap directory and fixing all the errors and warnings and submitting the fixes upstream. * sh autogen.sh on F19 (perhaps not only there) runs into problems detecting automake = 1.7. It fails despite F19 coming with Automake 1.13. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DHBAlbl4V6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #15 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- (In reply to comment #13) (In reply to comment #12) @Antonio gimp-gap does not contain .configure script as it from git and not release, so I need generate it. You may work with upstream in order to release gimp-gap with a preconfigured script (like most upstreams do) As I known it is common practice to distribute in tarball configure scripts only for released versions. otherwise by managing scripts locally, ensuring yourself they have been generated fine especially after a new Autotools release; autogen.sh already prefer most new available version. It especially for F19 and rawhide i need patch it. Please see in spec patch and comment on upstream bugreport about it. integrating all changes as patches or additional files. Changes in what? It is because I prefer do not run separate command instead of upstream autor generation script. (In reply to comment #14) * I strongly recommend running autoreconf -f in the gimp-gap directory and fixing all the errors and warnings and submitting the fixes upstream. autoreconf -f silent on gimp-gap directory after run autogen.sh (before it fails and require run automake, autoheader and so on). * sh autogen.sh on F19 (perhaps not only there) runs into problems detecting automake = 1.7. It fails despite F19 coming with Automake 1.13. Yes, it why patch provided. See spec and comment before. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SOcXzbHCvaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #16 from Michael Schwendt mschwe...@gmail.com --- autoreconf -f silent on gimp-gap directory after run autogen.sh (before it fails and require run automake, autoheader and so on). Please read man autoreconf, so you know what it does. A first run of sh autogen.sh prints the same stuff, because it also runs the individual autotools. Those are issues that should get fixed. Especially the deprecated stuff may lead to problems sometime in the future, and then you will be unable to create the configure script. There is no need to use the autogen.sh script anyway, which also executes the configure script, because you should be able to run autoreconf instead (or autoreconf -f). And you can use %configure appropriately, too. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QJHcOIh9OMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #17 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- (In reply to comment #16) A first run of sh autogen.sh prints the same stuff, because it also runs the individual autotools. Those are issues that should get fixed. Especially the deprecated stuff may lead to problems sometime in the future, and then you will be unable to create the configure script. I think we may focusing on fixing such issues when it happened. Sometime in future when it really will lead to problems and will unable to generate configure script, is not? There is no need to use the autogen.sh script anyway, which also executes the configure script, because you should be able to run autoreconf instead (or autoreconf -f). And you can use %configure appropriately, too. I sure what I may omit upstream author work and run command from autogen.sh directly from spec. But for what? I don't see any advantages to do that. Run configure script in any case is appropriate and desired as I call make then. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R8sJsx9FRPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #11 from Vasiliy Glazov vasc...@gmail.com --- Remove xvidcore from dependency. It available only in rpmfusion repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KfkDPoCGqra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #12 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- @Antonio gimp-gap does not contain .configure script as it from git and not release, so I need generate it. @Vasiliy, thanks. Done. Spec changes: https://github.com/Hubbitus/Fedora-packaging/commit/f1c0077fbb6dc2da5feee6251c81f511313e8f1e Srpm: http://hubbitus.info/rpm/Fedora18/gimp-gap/gimp-gap-2.7.0-5.GITe75bd46.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YJcEb8BWd5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #13 from Antonio Trande anto.tra...@gmail.com --- (In reply to comment #12) @Antonio gimp-gap does not contain .configure script as it from git and not release, so I need generate it. You may work with upstream in order to release gimp-gap with a preconfigured script (like most upstreams do) otherwise by managing scripts locally, ensuring yourself they have been generated fine especially after a new Autotools release; integrating all changes as patches or additional files. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JGkv9ei3cya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- (In reply to comment #5) These latest two points must be taken in consideration in my opinion, especially for next rebuildings. You should re-configure locally makefile instead to use autogen.sh that runs --configure-- command already before %configure macro during RPM building. I think using upstream script is good idea to do not introduce well known bugs again. As I rerun configure after call autogen.sh it should not be problem I think? All other issues addressed, thank you. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5312048 Spec changes: https://github.com/Hubbitus/Fedora-packaging/commit/c62ab84ea7f39496c75b95dc8bb80fbce48827cd Srpm: http://hubbitus.info/rpm/Fedora18/gimp-gap/gimp-gap-2.7.0-3.GITe75bd46.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GaYji5wHpta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=954108
--- Comment #7 from Vasiliy Glazov vasc...@gmail.com ---
1. In Release: add dist tag. Like
Release:2%{?dist}
2. Use parallel make:
make %{?_smp_mflags}
3. Update srpm package with the same spec file as in Spec URL.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OdOPcz5AtIa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #8 from Antonio Trande anto.tra...@gmail.com --- (In reply to comment #6) (In reply to comment #5) These latest two points must be taken in consideration in my opinion, especially for next rebuildings. You should re-configure locally makefile instead to use autogen.sh that runs --configure-- command already before %configure macro during RPM building. I think using upstream script is good idea to do not introduce well known bugs again. Well, it's the shortest way but https://bugzilla.redhat.com/buglist.cgi?quicksearch=autoconf :) As I rerun configure after call autogen.sh it should not be problem I think? In primis, it prolongs building time. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kYWDaIxhCca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=954108
--- Comment #9 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info ---
(In reply to comment #7)
1. In Release: add dist tag. Like
Release:2%{?dist}
Thanks. Done.
2. Use parallel make:
make %{?_smp_mflags}
It break build. Spec file already stated it in comment.
3. Update srpm package with the same spec file as in Spec URL.
It is.
(In reply to comment #8)
(In reply to comment #6)
(In reply to comment #5)
Well, it's the shortest way but
https://bugzilla.redhat.com/buglist.cgi?quicksearch=autoconf
:)
Sorry, but I don't understand what you want said. What will really different if
I copypaste most of that's command in spec file instead of call it in intendes
script?
As I rerun configure after call autogen.sh it should not be problem I think?
In primis, it prolongs building time.
On my mind it have no worth for optimization but it have some rationale though.
I pass arguments to autogen.sh to configure it in single step.
Spec changes:
https://github.com/Hubbitus/Fedora-packaging/commit/39d43b4a65ea980f121abab4d2c1254ca55d756d
Srpm:
http://hubbitus.info/rpm/Fedora18/gimp-gap/gimp-gap-2.7.0-4.GITe75bd46.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ijtCqsFOHia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=954108
--- Comment #10 from Antonio Trande anto.tra...@gmail.com ---
(In reply to comment #9)
(In reply to comment #7)
1. In Release: add dist tag. Like
Release:2%{?dist}
Thanks. Done.
2. Use parallel make:
make %{?_smp_mflags}
It break build. Spec file already stated it in comment.
3. Update srpm package with the same spec file as in Spec URL.
It is.
(In reply to comment #8)
(In reply to comment #6)
(In reply to comment #5)
Well, it's the shortest way but
https://bugzilla.redhat.com/buglist.cgi?quicksearch=autoconf
:)
Sorry, but I don't understand what you want said. What will really different
if I copypaste most of that's command in spec file instead of call it in
intendes script?
Although it is an old page, this wiki summarizes the issue:
http://fedoraproject.org/wiki/PackagingDrafts/AutoConf
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=0OGazqctIba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=954108
--- Comment #5 from Antonio Trande anto.tra...@gmail.com ---
- 'libjpeg-turbo-devel' is missing among BuildRequires
- Your package doesn't build in mock on rawhide, it needs 'automake17'.
Also,
- there are some warnings during configure tasks:
configure.in:34: installing './config.guess'
configure.in:34: installing './config.sub'
configure.in:30: installing './install-sh'
configure.in:30: installing './missing'
Makefile.am: installing './INSTALL'
Makefile.am: installing './COPYING' using GNU General Public License v3 file
Makefile.am: Consider adding the COPYING file to the version control system
Makefile.am: for your code, to avoid questions about which license your
project uses
gap/Makefile.am: installing './depcomp'
Symlinking file mkinstalldirs
Symlinking file po/Makefile.in.in
Please add the files
codeset.m4 gettext.m4 glibc21.m4 iconv.m4 isc-posix.m4 lcmessage.m4
progtest.m4
from the /usr/share/aclocal directory to your autoconf macro directory
or directly to your aclocal.m4 file.
You will also need config.guess and config.sub, which you can get from
ftp://ftp.gnu.org/pub/gnu/config/.
checking for a BSD-compatible install... /usr/bin/install -c
...
These latest two points must be taken in consideration in my opinion,
especially for next rebuildings. You should re-configure locally makefile
instead to use autogen.sh that runs --configure-- command already before
%configure macro during RPM building.
- %{_datadir}/locale/*/*/*
It is not necessary when you already use %files -f gimp20-gap.lang
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=nuoi3kLKmUa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #3 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- It is primary build for Gimp 1.8 on Fedora. And its tested by some peoples from my repository http://hubbitus.info/rpm/Fedora18/gimp-gap/ And I had deleted version mention from description to avoid confusing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9mlTwT5TKMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 --- Comment #4 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- Sorry, for gimp 2.8 off course, not 1.8. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FRIYFho1bva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added CC||anto.tra...@gmail.com --- Comment #2 from Antonio Trande anto.tra...@gmail.com --- Hi Pavel. gimp-gap's project seems idle since several months ... Is it just for GIMP 2.6 ? Or even for its following releases ? If it works with Gimp 2.8 (currently available in Fedora) too, '%description' in the .spec file is deceptive: The GIMP-GAP (GIMP Animation Package) is a collection of Plug-Ins to extend GIMP 2.6 with capabilities to edit and create animations as sequences of single frames. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6j3im9wAoua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954108 Vasiliy Glazov vasc...@gmail.com changed: What|Removed |Added CC||vasc...@gmail.com --- Comment #1 from Vasiliy Glazov vasc...@gmail.com --- Change spec URL to direct https://raw.github.com/Hubbitus/Fedora-packaging/master/SPECS/gimp-gap.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ONqaElMfkWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
