[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- mybatis-parent-18-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AiSzCAVJpSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- mybatis-parent-18-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bCn60fuOUZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-26 23:04:22 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cuvrQidgJba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b96ZR6f7Iwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8EFsMvyvjKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zMgjchwxMFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- mybatis-parent-18-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mybatis-parent-18-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DHfOm3MzMVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- mybatis-parent-18-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mybatis-parent-18-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WBAHdWoQR3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=APhroGn6H1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- mybatis-parent-18-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gylXtzji3xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 --- Comment #3 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/mybatis-parent/18/1/mybatis-parent.spec SRPM URL: http://gil.fedorapeople.org/mybatis-parent/18/1/mybatis-parent-18-2.fc18.src.rpm - fix requires (all active plugin listed in the pom) - changed SOURCE0 as suggested thanks! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZDRjHF9kIma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #4 from Orion Poplawski or...@cora.nwra.com --- Looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fEYczTLigFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from gil cattaneo punto...@libero.it --- New Package SCM Request === Package Name: mybatis-parent Short Description: The MyBatis parent POM Owners: gil Branches: f18 f19 f20 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uinRmey2Qga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=954134
Orion Poplawski or...@cora.nwra.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||or...@cora.nwra.com
Assignee|nob...@fedoraproject.org|or...@cora.nwra.com
--- Comment #1 from Orion Poplawski or...@cora.nwra.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Use https://github.com/mybatis/parent/archive/%{name}-%{version}.tar.gz for
Source0.
- Needs to require all active plugin listed in the pom.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 3 files.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[?]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
= EXTRA items =
Generic:
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 --- Comment #2 from Orion Poplawski or...@cora.nwra.com --- Suggestion from irc - run %mvn_build in %build to automatically add the needed deps. Unfortunately, %mvn_build will not be in f18. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0D0X1FtKeha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 954134] Review Request: mybatis-parent - The MyBatis parent POM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954134 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||815566 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YIWM0XOyl8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
