[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 Fedora Update System changed: What|Removed |Added Fixed In Version|nifti2dicom-0.4.5-4.fc18|nifti2dicom-0.4.5-4.fc19 --- Comment #14 from Fedora Update System --- nifti2dicom-0.4.5-4.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UOrDK8blln&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nifti2dicom-0.4.5-4.fc18 Resolution|--- |ERRATA Last Closed||2013-06-06 23:03:49 --- Comment #13 from Fedora Update System --- nifti2dicom-0.4.5-4.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YNo7DQM9h5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 --- Comment #11 from Fedora Update System --- nifti2dicom-0.4.5-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nifti2dicom-0.4.5-4.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OODxQJkLzu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 --- Comment #10 from Fedora Update System --- nifti2dicom-0.4.5-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nifti2dicom-0.4.5-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d57WkpBqlD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=itT6qYM5rB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 Dan Vrátil changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qyvO8Nwzug&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- Package nifti2dicom-0.4.5-4.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nifti2dicom-0.4.5-4.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-9491/nifti2dicom-0.4.5-4.fc18 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n6CWddMsCU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qFq90GMepE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TjbA9XOT1b&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 --- Comment #8 from Dan Vrátil --- New Package SCM Request === Package Name: nifti2dicom Short Description: Converts 3D medical images to DICOM 2D series Owners: dvratil Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UaWzQBda4o&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201 Volker Fröhlich changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #7 from Volker Fröhlich --- Fails to build in Rawhide: Various gdcm headers are not found Otherwise it's good to go. I trust you'll take care of that and therefore APPROVE the packge. Some details you could improve: - Use the name macro on Patch0 - Comment about the status of that ITK linking issue upstream -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dRih6Q2QWG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
https://bugzilla.redhat.com/show_bug.cgi?id=956201
--- Comment #6 from Dan Vrátil ---
Updated Spec: http://fedorapeople.org/~dvratil/spec/nifti2dicom.spec
Updated SRPM:
http://fedorapeople.org/~dvratil/spec/nifti2dicom-0.4.5-4.fc18.src.rpm
- added AUTHORS, NEWS and COPYING to docs
- removed InsightToolkit-examples from BR (it was required due to packaging
issue in InsightToolkit which is fixed now), removed graphviz
- using %{_mandir}
- using .tar.gz
- rename downloaded tarball to %{name}-%{version}.tar.gz
- excluded PPC and PPC64 (there's ARM build of InsightToolkit available, but I
haven't tried it)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=6xs1PQtr38&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956201
--- Comment #5 from Volker Fröhlich ---
Ship AUTHORS, NEWS and COPYING as documentation!
As far as I can see, InsightToolkit-examples is not a BR; Neither is graphviz.
Prefer .tar.gz, as it is slightly smaller. You can use the name macro in
Source0.
Please find other comments inline below.
Cosmetics:
- You can remove the slash in "%{buildroot}/%{_datadir}"
- Insert an empty line between the two paragraphs of the description
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in
/media/speicher1/makerpm/956201-nifti2dicom/diff.txt
See: http://fedoraproject.org/wiki/Packaging/SourceURL
That's the outcome of getting a tarball for a Git tag. The resulting file has
a different name. I don't know if something can be done about that.
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[!]: Package is not known to require ExcludeArch.
Due to missing InsightToolkit builds don't succeed on PPC/PPC64 at the moment.
The cause is a missing gdcm build. I haven't investigated ARM, but it doesn't
have InsightToolkit either. I informed the maintainer of gdcm and
InsightToolkit. If that can't be settled somehow, you should add an ExcludeArch
tag.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v3 or later)", "Unknown or generated". 2 files have unknown
license. Detailed output of licensecheck in
/media/speicher1/makerpm/956201-nifti2dicom/licensecheck.txt
[!]: Package consistently uses macro is (instead of hard-coded directory
names).
Use mandir instead of datadir/man
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[-]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[!]: Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in
/media/speicher1/makerpm/956201-nifti2dicom/diff.txt
See above!
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Use
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956201 Volker Fröhlich changed: What|Removed |Added Assignee|nob...@fedoraproject.org|volke...@gmx.at Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bSiKIDY4gx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956201 --- Comment #4 from Dan Vrátil --- Sorry, now tested with Koji build. Updated Spec: http://fedorapeople.org/~dvratil/spec/nifti2dicom.spec Updated SRPM: http://fedorapeople.org/~dvratil/spec/nifti2dicom-0.4.5-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cTK09bJout&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956201 --- Comment #3 from Volker Fröhlich --- Build fails in Rawhide: /usr/bin/ld: cannot find -lQtWebKit collect2: error: ld returned 1 exit status BR qt4-webkit-devel! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cUAT1gYadr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956201 --- Comment #2 from Dan Vrátil --- Thanks for the review, all mentioned issues should be fixed now. I guess "Hints" from desktop-file-validate are not a problem? > The patch is from upstream? Not directly, but it's based on an upstream git commit that fixes the linking. Updated Spec: http://fedorapeople.org/~dvratil/spec/nifti2dicom.spec Updated SRPM: http://fedorapeople.org/~dvratil/spec/nifti2dicom-0.4.5-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rLGXPHuzl5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956201] Review Request: nifti2dicom - Converts 3D medical images to DICOM 2D series
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956201
Volker Fröhlich changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #1 from Volker Fröhlich ---
BR cmake, otherwise it won't build.
licensecheck reveals GPLv3+.
You need to validate the desktop file, as of
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
and BR desktop-file-utils.
With the icons installed where they are:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
I suggest to use %{_datadir}/man/man1/*.1* to allow for changes in compression
method.
The patch is from upstream?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=AcnxZ6sF8y&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
