[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956654
Pádraig Brady changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||p...@draigbrady.com
Assignee|nob...@fedoraproject.org|p...@draigbrady.com
Flags||fedora-review+
--- Comment #1 from Pádraig Brady ---
It's debatable that this is worth packaging as it only seems needed to build
the upstream openstack tarballs?
Anyway package looks good
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated". 2 files have unknown license.
Detailed output of licensecheck in /home/padraig/t/review-python-
pbr/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 194560 bytes in 24 files.
[-]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English la
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 Matthias Runge changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Matthias Runge --- Thank you for the quick review! New Package SCM Request === Package Name: python-pbr Short Description: Python Build Reasonableness Owners: mrunge Branches: f19 el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kFr1A1PtUI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oBCfD20FPe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M08HMffasH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c6lYyTL5SW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 --- Comment #4 from Fedora Update System --- python-pbr-0.5.8-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-pbr-0.5.8-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c1mtplgAc0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Xpeqi79W7I&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 --- Comment #5 from Fedora Update System --- python-pbr-0.5.8-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZYPbhK4C96&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 Matthias Runge changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #6 from Matthias Runge --- Package Change Request == Package Name: python-pbr New Branches: f18 Owners: mrunge -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0OpghEAF6w&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4yHeWX30lr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wurh3BveSY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 --- Comment #8 from Fedora Update System --- python-pbr-0.5.8-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-pbr-0.5.8-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9eNOMYqWYR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956654] Review Request: python-pbr - Python Build Reasonableness
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956654 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-pbr-0.5.8-1.fc18 Resolution|--- |ERRATA Last Closed||2013-05-13 21:21:09 --- Comment #9 from Fedora Update System --- python-pbr-0.5.8-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JDC95h42In&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
