[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 Juan Manuel changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Juan Manuel --- New Package SCM Request === Package Name: rf Short Description: Read feeds from any source Owners: juanmabc Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L4fj3Rco0H&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y4XWhbUCdg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VGhAAhBRrX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 --- Comment #6 from Fedora Update System --- rf-0.4.18-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rf-0.4.18-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RojunlOBY8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x4CZC99oF9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 --- Comment #7 from Fedora Update System --- rf-0.4.18-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rf-0.4.18-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m9rLrhb6Fr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 --- Comment #8 from Fedora Update System --- rf-0.4.18-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rf-0.4.18-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s3zMnD2K91&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 --- Comment #9 from Fedora Update System --- rf-0.4.18-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rf-0.4.18-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NeVDySsvAa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- rf-0.4.18-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aHeACJ8DsF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rf-0.4.18-2.fc17 Resolution|--- |ERRATA Last Closed||2013-06-26 21:58:21 --- Comment #11 from Fedora Update System --- rf-0.4.18-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GsrhjDbbI3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 Fedora Update System changed: What|Removed |Added Fixed In Version|rf-0.4.18-2.fc17|rf-0.4.18-2.fc18 --- Comment #12 from Fedora Update System --- rf-0.4.18-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AyaPhr5mYw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 Fedora Update System changed: What|Removed |Added Fixed In Version|rf-0.4.18-2.fc18|rf-0.4.18-2.fc19 --- Comment #13 from Fedora Update System --- rf-0.4.18-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QWX00Xbcir&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957520
Antonio Trande changed:
What|Removed |Added
CC||anto.tra...@gmail.com
--- Comment #1 from Antonio Trande ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: Texinfo files are properly installed
Note: Texinfo .info file(s) in rf
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v3 or later)". 1 files have unknown license. Detailed output of
licensecheck in /home/sagitter/957520-rf/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 6 files.
[!]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
--> Your package needs just
BuildRequires: xmlstarlet
Requires:curl
Requires:lynx
Requires(post): info
Requires(preun): info
bash, sed, ... can be omitted.
http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[-]: Each %files section contains %defattr if rpm < 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
--> A new release results available:
https://readfeed.googlecode.com/files/rf-0.4.16.tar.bz2
[-]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package build
[Bug 957520] Review Request: rf - read feeds from any source
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957520 --- Comment #2 from Juan Manuel --- Spec URL: http://juanmabc.fedorapeople.org/packages/rf/rf.spec SRPM URL: http://juanmabc.fedorapeople.org/packages/rf/rf-0.4.16-1.fc18.src.rpm Description: command line scriptable feed reader with default feeds ( http://code.google.com/p/readfeed ) Fedora Account System Username: juanmabc *** --> Your package needs just BuildRequires: xmlstarlet Requires:curl Requires:lynx Requires(post): info Requires(preun): info bash, sed, ... can be omitted. http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 ***: Quoting: "Exceptions:There is no need to include the following packages or their dependencies as *BuildRequires* because they would occur too often. These packages are considered the minimum build environment." I use them in *Requires*, which is completely different and has no exceptions. Note that BuildRequires xmlstarlet i assume is a typo, since there is no BuildRequire dependency for it, and the fact that has no BuildRequires is precissely because of the Exceptions. Requires are what is needed at runtime, BuildRequires at compile time. *** --> A new release results available: https://readfeed.googlecode.com/files/rf-0.4.16.tar.bz2 ***: This is correct and fixed. *** --> Source link is wrong. https://readfeed.googlecode.com/files/rf-0.4.12.tar.bz2 ***: googlecode happens to be really like this on fedora scripts, the link is valid (as you can see clicking) and the issue is known, packages get approved with this complain, see: https://bugzilla.redhat.com/show_bug.cgi?id=890733#c3 , quoting: "The download URL is valid, the tarball is downloadable. That's a common problem with Googlecode stuff." Thanks for the interest. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EaBc03bcqR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957520 Antonio Trande changed: What|Removed |Added Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review+ --- Comment #3 from Antonio Trande --- (In reply to comment #2) > Spec URL: http://juanmabc.fedorapeople.org/packages/rf/rf.spec > SRPM URL: > http://juanmabc.fedorapeople.org/packages/rf/rf-0.4.16-1.fc18.src.rpm > Description: command line scriptable feed reader with default feeds ( > http://code.google.com/p/readfeed ) > Fedora Account System Username: juanmabc > > *** --> Your package needs just > > BuildRequires: xmlstarlet > Requires:curl > Requires:lynx > Requires(post): info > Requires(preun): info > > bash, sed, ... can be omitted. > > http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 > > ***: > Quoting: "Exceptions:There is no need to include the following packages or > their dependencies as *BuildRequires* because they would occur too often. > These > packages are considered the minimum build environment." > > I use them in *Requires*, which is completely different and has no > exceptions. Note that BuildRequires xmlstarlet i assume is a typo, since > there is no BuildRequire dependency for it, and the fact that has no > BuildRequires is precissely because of the Exceptions. Requires are what is > needed at runtime, BuildRequires at compile time. > Gee whiz! I'm sorry, I have mixed them. :P I think your package can be approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0gm0KMbLJl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
