[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-05-06 00:24:36 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b37vgyj2d2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- java-base64-2.3.8-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yhTf3wmEIka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 --- Comment #4 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/java-base64.spec SRPM URL: http://gil.fedorapeople.org/java-base64-2.3.8-2.fc18.src.rpm - fix artifact name, added symlink - fix javadoc name, added symlink -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qXGWlADBMfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957544
--- Comment #3 from Orion Poplawski or...@cora.nwra.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Maven packages should use new style packaging
Note: If possible update your package to latest guidelines
See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven
I understand you are keeping old style for F18 compat. Fine by me.
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Note: No /usr/share/javadoc/java-base64 found
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
Need a symlink. Also for the jar file:
https://fedoraproject.org/wiki/Packaging:Java#Filenames :
If the package provides a single JAR and the filename provided by the build is
neither %{name}-%{version}.jar nor %{name}.jar then this file MUST be installed
as %{name}.jar and a symbolic link with the usual name must be provided.
- Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
See: https://fedoraproject.org/wiki/Packaging:Java
I can go eiher way.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java-
base64-javadoc
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 2 files have unknown license. Detailed output of
licensecheck in /export/home/orion/redhat/java-base64-2.3.8/957544-java-
base64/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Bundled jar/class files should be removed before
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Orion Poplawski or...@cora.nwra.com --- Approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F8njiSK0Jma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from gil cattaneo punto...@libero.it --- New Package SCM Request === Package Name: java-base64 Short Description: Java class for encoding and decoding Base64 notation Owners: gil Branches: f18 f19 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5cJDppaKGNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ONEOepYZHoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y44DsXZvh2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VpXPFXIIJUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- java-base64-2.3.8-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/java-base64-2.3.8-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TfIJN3OyZFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- java-base64-2.3.8-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/java-base64-2.3.8-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DUBqdbv4D1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- java-base64-2.3.8-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4eHxBXYoLra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qZV2pgM5iLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957544] Review Request: java-base64 - Java class for encoding and decoding Base64 notation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957544 gil cattaneo punto...@libero.it changed: What|Removed |Added Summary|Review Request: base64 -|Review Request: java-base64 |Java class for encoding and |- Java class for encoding |decoding Base64 notation|and decoding Base64 ||notation --- Comment #2 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/java-base64.spec SRPM URL: http://gil.fedorapeople.org/java-base64-2.3.8-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7UqomWTKg6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
