[Bug 958006] Review Request: zanata-common - zanata common modules
https://bugzilla.redhat.com/show_bug.cgi?id=958006 Ding-Yi Chen dc...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs- --- Comment #21 from Ding-Yi Chen dc...@redhat.com --- Package Change Request == Package Name: zanata-common New Branches: epel7 Owners: pahuang dchen -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
https://bugzilla.redhat.com/show_bug.cgi?id=958006 Ding-Yi Chen dc...@redhat.com changed: What|Removed |Added Flags|fedora-cvs- |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
https://bugzilla.redhat.com/show_bug.cgi?id=958006 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #22 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- zanata-common-2.2.1-5.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6vH2GKF3ooa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|zanata-common-2.2.1-5.fc18 |zanata-common-2.2.1-5.fc17 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- zanata-common-2.2.1-5.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TnqfQrK3dDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||zanata-common-2.2.1-5.fc18 Resolution|--- |ERRATA Last Closed||2013-05-15 13:28:40 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- zanata-common-2.2.1-5.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cqaSq4p4eBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- zanata-common-2.2.1-5.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e7i6W6COrba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wlr7HqA1Cka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jYty4uR3tza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gVsndxGHwpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- zanata-common-2.2.1-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/zanata-common-2.2.1-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GnVOyBbtTaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- zanata-common-2.2.1-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/zanata-common-2.2.1-5.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oE49GtpBjoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- zanata-common-2.2.1-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/zanata-common-2.2.1-5.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a6u30zfwaXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006
Ding-Yi Chen dc...@redhat.com changed:
What|Removed |Added
Assignee|dc...@redhat.com|pahu...@redhat.com
Flags||fedora-review+
--- Comment #11 from Ding-Yi Chen dc...@redhat.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Packages have proper BuildRequires/Requires on jpackage-utils
See: https://fedoraproject.org/wiki/Packaging:Java
- Spec file lacks Packager, Vendor, PreReq tags.
Note: Found : Packager: Ding-Yi Chen dc...@redhat.com Found : Vendor: Red
Hat, Inc.
See: (this test has no URL)
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in zanata-
common-javadoc
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in /home/dchen/958006-zanata-
common/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: Pom files have correct add_maven_depmap call
Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 Patrick Huang pahu...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Patrick Huang pahu...@redhat.com --- New Package SCM Request === Package Name: zanata-common Short Description: Zanata common modules including various i18n file readers and writers Owners: pahuang seanf Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DFq7ov2Fu4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #9 from Ding-Yi Chen dc...@redhat.com --- There is still zanata-common.src:28: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 28) Please either : rpmlint -i zanata-common.spec or editor that show tabs to locate and remove the rest of tabs. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FofanWs2t1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #10 from Patrick Huang pahu...@redhat.com --- Fixed Spec URL: http://fedorapeople.org/~pahuang/zanata-common.spec SRPM URL: http://fedorapeople.org/~pahuang/zanata-common-2.2.1-5.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8XYoKtN4o2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #3 from Ding-Yi Chen dc...@redhat.com --- Following error occurred when building with rawhide (f20): Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.Qoqk6d + umask 022 + cd /builddir/build/BUILD + cd zanata-common-common-2.2.1 + mvn-build Exception in thread main java.lang.NoClassDefFoundError: org/sonatype/aether/transfer/AbstractTransferListener at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:791) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:449) at java.net.URLClassLoader.access$100(URLClassLoader.java:71) at java.net.URLClassLoader$1.run(URLClassLoader.java:361) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:386) at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:244) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:230) at java.lang.Class.getDeclaredMethods0(Native Method) at java.lang.Class.privateGetDeclaredMethods(Class.java:2451) at java.lang.Class.getMethod0(Class.java:2694) at java.lang.Class.getMethod(Class.java:1622) at org.codehaus.plexus.classworlds.launcher.Launcher.getEnhancedMainMethod(Launcher.java:173) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:269) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357) Caused by: java.lang.ClassNotFoundException: org.sonatype.aether.transfer.AbstractTransferListener at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:244) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:230) ... 22 more RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.Qoqk6d (%build) Bad exit status from /var/tmp/rpm-tmp.Qoqk6d (%build) Child return code was: 1 EXCEPTION: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps builddir/build/SPECS/zanata-common.spec'] Traceback (most recent call last): File /usr/lib/python2.6/site-packages/mockbuild/trace_decorator.py, line 70, in trace result = func(*args, **kw) File /usr/lib/python2.6/site-packages/mockbuild/util.py, line 359, in do raise mockbuild.exception.Error, (Command failed. See logs for output.\n # %s % (command,), child.returncode) Error: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps builddir/build/SPECS/zanata-common.spec'] LEAVE do -- EXCEPTION RAISED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6KB0aiXVtFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #4 from Patrick Huang pahu...@redhat.com --- works for me locally and in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=5323356 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KqGNbFy7X6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006
--- Comment #5 from Ding-Yi Chen dc...@redhat.com ---
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
javadoc sub package cannot be installed. Please remove %{?_isa} from
Requires: %{name}%{?_isa} = %{version}-%{release}
Because %{?_isa} is for indicating dependency should be arch-specific,
which is not for noarch packages.
- Packages have proper BuildRequires/Requires on jpackage-utils
See: https://fedoraproject.org/wiki/Packaging:Java
BuildRequires: java-devel is missing
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Note: No /usr/share/javadoc/zanata-common found
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
All the javadoc should be placed under directory of
/usr/share/javadoc/zanata-common
- Package consistently uses macro is (instead of hard-coded directory names).
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
Choose either %{buildroot} or $RPM_BUILD_ROOT, they are the same thing.
- : License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in /home/dchen/958006-zanata-
Change license to LGPLv2+
Output of rpmlint
--
1. zanata-common-javadoc.noarch: E: description-line-too-long C
zanata-common-util, zanatzanata-common-javadoc.noarch:
Use linebreak to split the description.
2. zanata-common.src:90: W: macro-in-comment %setup
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
zanata-common.src:90: W: macro-in-comment %{name}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
zanata-common.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab:
line 21)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance. Use either spaces or tabs for indentation, not both.
Regards,
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=KoBSUNzkHea=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #6 from Patrick Huang pahu...@redhat.com --- Re point 2: # BR java-devel only if you need specific version # otherwise, java-devel will be pulled in automatically by maven-local [BuildRequires: java-devel = java version] Fixed other issues Spec URL: http://fedorapeople.org/~pahuang/zanata-common.spec SRPM URL: http://fedorapeople.org/~pahuang/zanata-common-2.2.1-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2EUaUA6BETa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #7 from Ding-Yi Chen dc...@redhat.com --- Two minor issues from rpmlint: 1. zanata-common.src:92: W: macro-in-comment %setup There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. Remove the comment if it is no longer needed. 2. zanata-common.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 21) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Replace tabs in line 21 of zanata-common.spec with spaces. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8iku7scUP0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #8 from Patrick Huang pahu...@redhat.com --- Fixed. Spec URL: http://fedorapeople.org/~pahuang/zanata-common.spec SRPM URL: http://fedorapeople.org/~pahuang/zanata-common-2.2.1-4.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2ICjCLKGHEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #1 from Patrick Huang pahu...@redhat.com --- f19 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5316649 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RY9qJfQ88Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 --- Comment #2 from Patrick Huang pahu...@redhat.com --- Tested under f18. Need to make a change. Koji build:http://koji.fedoraproject.org/koji/taskinfo?taskID=5319907 Spec URL: http://fedorapeople.org/~pahuang/zanata-common.spec SRPM URL: http://fedorapeople.org/~pahuang/zanata-common-2.2.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qq7qY1USm0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958006] Review Request: zanata-common - zanata common modules
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958006 Ding-Yi Chen dc...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||dc...@redhat.com Assignee|nob...@fedoraproject.org|dc...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aKjLZRKDaqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
