[Bug 958132] Review Request: soxr - The SoX Resampler library
https://bugzilla.redhat.com/show_bug.cgi?id=958132 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
https://bugzilla.redhat.com/show_bug.cgi?id=958132 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
https://bugzilla.redhat.com/show_bug.cgi?id=958132 Richard Shaw changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Richard Shaw --- Package Change Request == Package Name: soxr New Branches: epel7 Owners: hobbes1069 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 Fedora Update System changed: What|Removed |Added Fixed In Version|soxr-0.1.1-1.fc18 |soxr-0.1.1-1.fc17 --- Comment #13 from Fedora Update System --- soxr-0.1.1-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yZsrH7XQKF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||soxr-0.1.1-1.fc18 Resolution|--- |ERRATA Last Closed||2013-05-13 21:26:19 --- Comment #12 from Fedora Update System --- soxr-0.1.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aTvVl0TtrT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 --- Comment #11 from Fedora Update System --- soxr-0.1.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/soxr-0.1.1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZUGAqGQUHZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eHyBr8LNKY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cuM5gfwLgk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 Richard Shaw changed: What|Removed |Added Flags|fedora-cvs- | Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=msIviM5jNW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 Richard Shaw changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs- --- Comment #9 from Richard Shaw --- Package Change Request == Package Name: soxr New Branches: f17 Owners: hobbes1069 InitialCC: For F17 audacity update... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uHOwpA03Ip&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 Hans de Goede changed: What|Removed |Added CC||hdego...@redhat.com --- Comment #8 from Hans de Goede --- Great that this got packaged so quickly. kudos to all involved! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DiUZdk5auv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 --- Comment #7 from Fedora Update System --- soxr-0.1.1-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cDGjf6un28&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=08V9zMTmbm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 --- Comment #6 from Fedora Update System --- soxr-0.1.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/soxr-0.1.1-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b91rmTOw1x&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 --- Comment #5 from Fedora Update System --- soxr-0.1.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/soxr-0.1.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ko4EuXvkTR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KnHIyrRvq8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b5DWPvnFKc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l0Px9HrbUW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 Richard Shaw changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Richard Shaw --- New Package SCM Request === Package Name: soxr Short Description: The SoX Resampler library Owners: hobbes1069 Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hdzepEdwMq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 --- Comment #2 from Richard Shaw --- > [ ]: rpmlint warns of an unused direct shlib dependency. > > This is not a blocker issue, but it may be possible to fix this. See: > > https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib- > dependency This is very common with cmake projects, I'll add -Wl,--as-needed to the linker flags to fix this when I do the official build. Thanks for the quick review! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J6oQ1C1p8p&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958132
T.C. Hollingsworth changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #1 from T.C. Hollingsworth ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Status: APPROVED
= Things to Consider =
[ ]: rpmlint warns of an unused direct shlib dependency.
This is not a blocker issue, but it may be possible to fix this. See:
https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later)", "Unknown or generated". 2 files have unknown
license. Detailed output of licensecheck in
/home/fedora/patches/FedoraReview/958132-soxr/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No
[Bug 958132] Review Request: soxr - The SoX Resampler library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958132 T.C. Hollingsworth changed: What|Removed |Added Status|NEW |ASSIGNED CC||tchollingswo...@gmail.com Assignee|nob...@fedoraproject.org|tchollingswo...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lZkbdomg6A&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
